Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose hideBin helper for CJS #1768

Merged
merged 13 commits into from Oct 12, 2020
Merged

feat: expose hideBin helper for CJS #1768

merged 13 commits into from Oct 12, 2020

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Sep 25, 2020

Exposes the hideBin helper for CJS, so that we can standardize the documentation for ESM, CJS, and Deno.

Updates documentation to suggest this approach by default.

Fixes #1648

TODO: update the rest of the examples in the documentation.

Copy link
Contributor

@roryokane roryokane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my feedback on this PR’s documentation changes. I don’t know Yargs internals well enough to comment on the code changes, beyond saying I don’t see anything obviously wrong in the diff.

README.md Outdated Show resolved Hide resolved
docs/api.md Outdated Show resolved Hide resolved
docs/api.md Show resolved Hide resolved
docs/api.md Outdated Show resolved Hide resolved
docs/api.md Outdated Show resolved Hide resolved
docs/advanced.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote the non-singleton interface, require('yargs/yargs'), as the default
2 participants