Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(usage): single char aliases first in help #1574

Merged
merged 3 commits into from Aug 5, 2020

Conversation

mleguen
Copy link
Member

@mleguen mleguen commented Mar 4, 2020

Display short switches first in usage,
and indent long switches only options.

Fix #1403

@bcoe
Copy link
Member

bcoe commented Mar 7, 2020

this seems great to me, I'm wondering if we should call it a breaking change though, as it will require a lot of upstream folks to change their unit tests. I was thinking we'd drop Node 8 relatively soon any ways.

@mleguen
Copy link
Member Author

mleguen commented Mar 11, 2020

I rebased and handled conflicts with #1580.

It was the occasion to change somehow my way of doing this (no longer compatible with #1580), which is not bad as I personally find it more readable.

@mleguen mleguen force-pushed the 1403-single-char-aliases-first-in-help branch from 252dacc to 0175cc2 Compare March 19, 2020 13:57
@mleguen mleguen force-pushed the 1403-single-char-aliases-first-in-help branch from 0175cc2 to af31ebc Compare April 3, 2020 08:16
@mleguen
Copy link
Member Author

mleguen commented Apr 3, 2020

Rebased to adapt to usage being a typescript module now.

@mleguen mleguen force-pushed the 1403-single-char-aliases-first-in-help branch 2 times, most recently from 20f7535 to 1ea7f3a Compare April 9, 2020 07:19
@mleguen mleguen force-pushed the 1403-single-char-aliases-first-in-help branch from 1ea7f3a to f6aeccc Compare April 17, 2020 07:53
@mleguen mleguen force-pushed the 1403-single-char-aliases-first-in-help branch from f6aeccc to c78872c Compare May 6, 2020 09:07
@mleguen mleguen force-pushed the 1403-single-char-aliases-first-in-help branch from c78872c to 855078e Compare May 20, 2020 06:59
@bcoe
Copy link
Member

bcoe commented Jul 19, 2020

@mleguen bother you to rebase this, now that we're moving towards the next major.

@mleguen mleguen force-pushed the 1403-single-char-aliases-first-in-help branch from 855078e to 6b28fc5 Compare August 3, 2020 10:10
@mleguen
Copy link
Member Author

mleguen commented Aug 3, 2020

@bcoe done.

First time in 2 months I had time to have a look at yargs, sorry...

@bcoe bcoe merged commit a552990 into master Aug 5, 2020
@bcoe bcoe deleted the 1403-single-char-aliases-first-in-help branch August 5, 2020 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: show single-char aliases first in help
2 participants