fix(exports): node 13.0-13.6 require a string fallback #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json’s "engines" field claims yargs supports node >= 10; node v13.0-v13.6 are included in this semver range. This change is required to be able to require() from yargs successfully in these versions.
bcoe
approved these changes
Oct 11, 2020
ljharb
added a commit
to ljharb/yargs-parser
that referenced
this pull request
Oct 11, 2020
package.json’s "engines" field claims yargs-parser supports node >= 10; node v13.0-v13.6 are included in this semver range. This change is required to be able to require() from yargs-parser successfully in these versions. See yargs/yargs#1776
This was referenced Oct 11, 2020
lukeed
pushed a commit
to lukeed/escalade
that referenced
this pull request
Oct 13, 2020
) package.json’s "engines" field claims cliui supports node >= 6; node v13.0-v13.6 are included in this semver range. This change is required to be able to require() from escalade successfully in these versions. See yargs/yargs#1776
bcoe
pushed a commit
to yargs/yargs-parser
that referenced
this pull request
Oct 14, 2020
package.json’s "engines" field claims yargs-parser supports node >= 10; node v13.0-v13.6 are included in this semver range. This change is required to be able to require() from yargs-parser successfully in these versions. See yargs/yargs#1776
bcoe
pushed a commit
to yargs/cliui
that referenced
this pull request
Oct 14, 2020
package.json’s "engines" field claims cliui supports node >= 10; node v13.0-v13.6 are included in this semver range. This change is required to be able to require() from cli-ui successfully in these versions. See yargs/yargs#1776
ljharb
added a commit
to ljharb/yargs
that referenced
this pull request
Oct 15, 2020
bcoe
pushed a commit
that referenced
this pull request
Oct 15, 2020
ljharb
added a commit
to ljharb/y18n
that referenced
this pull request
Oct 16, 2020
package.json’s "engines" field claims yargs-parser supports node >= 10; node v13.0-v13.6 are included in this semver range. This change is required to be able to require() from yargs-parser successfully in these versions. See yargs/yargs#1776
bcoe
pushed a commit
to yargs/y18n
that referenced
this pull request
Oct 16, 2020
package.json’s "engines" field claims yargs-parser supports node >= 10; node v13.0-v13.6 are included in this semver range. This change is required to be able to require() from yargs-parser successfully in these versions. See yargs/yargs#1776
ljharb
added a commit
to ljharb/y18n
that referenced
this pull request
Oct 16, 2020
…_ a string fallback package.json’s "engines" field claims yargs-parser supports node >= 10; node v13.0 and v13.1 are included in this semver range. This change is required to be able to require() from yargs-parser successfully in these versions. See yargs/yargs#1776
ljharb
added a commit
to ljharb/yargs-parser
that referenced
this pull request
Oct 16, 2020
…_ a string fallback package.json’s "engines" field claims yargs-parser supports node >= 10; node v13.0 and v13.1 are included in this semver range. This change is required to be able to require() from yargs-parser successfully in these versions. See yargs/yargs#1776
This was referenced Oct 16, 2020
bcoe
pushed a commit
to yargs/cliui
that referenced
this pull request
Oct 16, 2020
…_ a string fallback (#93) package.json’s "engines" field claims yargs-parser supports node >= 10; node v13.0 and v13.1 are included in this semver range. This change is required to be able to require() from yargs-parser successfully in these versions. See yargs/yargs#1776
bcoe
pushed a commit
to yargs/y18n
that referenced
this pull request
Oct 16, 2020
…_ a string fallback (#105) package.json’s "engines" field claims yargs-parser supports node >= 10; node v13.0 and v13.1 are included in this semver range. This change is required to be able to require() from yargs-parser successfully in these versions. See yargs/yargs#1776
bcoe
pushed a commit
to yargs/yargs-parser
that referenced
this pull request
Oct 16, 2020
…_ a string fallback (#336) package.json’s "engines" field claims yargs-parser supports node >= 10; node v13.0 and v13.1 are included in this semver range. This change is required to be able to require() from yargs-parser successfully in these versions. See yargs/yargs#1776
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package.json’s "engines" field claims yargs supports node >= 10; node v13.0-v13.6 are included in this semver range. This change is required to be able to require() from yargs successfully in these versions.
I'm running into this because I'm trying to build tests for
list-exports/ls-exports, andresolve, to cover resolution behavior in these node versions.I've manually tested this; combined with a similar change in
y18n,yargs-parser,cliui, andescalade, it fixes the bug. Since the behavior can only be observed by installing yargs into a node_modules folder and then trying torequireit, it's exceedingly difficult to test in CI.I'll be happy to make those PRs as well, if you'll accept them, and will then update this PR to bump the dep versions once published.