fix(bucket): Only disable resumable uploads for bucket.upload (fixes #1133) #1135

rhodgkins · 2020-03-28T12:26:45Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #1133

I've added a test case for this by stubbing fs.stat - I hope that's ok!

src/bucket.ts

JustinBeckwith · 2020-04-13T16:58:58Z

@jkwlui any movement on this PR?

jkwlui · 2020-04-22T01:02:51Z

@stephenplusplus let's move forward with this PR, if everything looks okay to you.

stephenplusplus · 2020-04-23T18:15:18Z

Thanks @rhodgkins! Great work on the tests 👍

stephenplusplus · 2020-04-23T18:53:36Z

@rhodgkins would you mind updating the PR against our latest master? You might also have the option on this page to give us write access to your fork, which would allow us to make the change. (I'm not sure that's a thing, but I recall seeing the option somewhere before)

googlebot · 2020-04-23T19:04:39Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-04-23T19:06:10Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

codecov · 2020-04-23T19:06:11Z

Codecov Report

Merging #1135 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1135   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files          12       12           
  Lines       11437    11440    +3     
  Branches      524      589   +65     
=======================================
+ Hits        11345    11348    +3     
  Misses         92       92

Impacted Files	Coverage Δ
src/bucket.ts	`99.58% <100.00%> (+<0.01%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a92b7bb...0e57621. Read the comment docs.

rhodgkins · 2020-04-23T19:08:29Z

@stephenplusplus done (sorry about the noise, I tired to update via GitHub UI and it wasn't the email I signed the CLA with, so I rebased and force pushed...!)

And I know the option you mean re allowing maintainers to edit, but I can't find the option (I recall it being there when I created the PR).
Any ideas as to why the linter is now failing?

stephenplusplus · 2020-04-27T15:48:40Z

The linter had a small issue with how fs was being imported, but when I looked closer at the tests, I thought I would do a small refactor of the mocking logic to sync with how we're currently doing it. Here's a diff you can apply, which should 🤞 get us green lights from CI.

Here's a gist: https://gist.github.com/stephenplusplus/3dd358c7f98aeca2b55a7355750a3e5f

And to quickly apply it:

$ curl https://gist.githubusercontent.com/stephenplusplus/3dd358c7f98aeca2b55a7355750a3e5f/raw/05525a9344c6151b1e7d9b362980dceb658f58f3/storage-1135.diff | git apply 
`

rhodgkins · 2020-04-29T09:33:01Z

@stephenplusplus patch applied - also rebased from master

test/testdata/dummylargetestfile.txt

…35 (comment)

* Add Cloud Speech sample. * Switched from JSHint to Semistandard and upgraded dependencies. * Finished a bunch more Readme files. * Add Speech API streaming sample. (#144) * Add Speech API streaming example. * Remove comment. * Add test. * Fix failing test. * Rename variable. * Switch Speech sample to v1beta1 (#146) * Switch Speech samples to v1beta1 * Now consuming Speech v1beta1 proto file from NPM package. * Make lint happy. * Fix relative path. * speech/recognize.js: upgrade googleapis * Refactored tests (#159) * Refactor tests. * Tweak build. * Tweak build. * More tests. * Tweak build. * Tweak build. * Fix build. * Fix build. * Speed up build. * Fix build. * Remove extra dep. * Investigate why 0.12 fails. * Scripts. * More tests. * Upgrades * Upgrades * Update readme * * Refactored Pub/Sub samples into nice command-line programs, like the new Cloud Storage samples (#164) * Brought Pub/Sub samples code coverage up to 98.66% * Upgrade Speech samples. (#217) * Upgrade Speech samples. * Address comments. * New quickstarts. (#226) * New quickstarts. * Address comments. * Updated copyright headers and dependencies. * Update Speech samples. (#257) * Update storage samples. (#263) * Update storage samples. * Update dependencies. * Switch from Mocha to Ava for faster tests (#289) * Switch from Mocha to Ava * Concurrency: 5 * Switch to Yarn for CI build. (#290) * Vision snippets. (#294) * Update Speech samples. (#307) * Update dependencies. * Update samples to match new Speech API (#342) Update samples to match new Speech API * Bring ML APIs up to standard. (#346) * Add SoX instructions. * Fixes #348 * Cleanup App Engine samples and re-work tests. (#354) * Bring Speech API samples up to standard. (#362) * Upgrade to repo tools v1.4.7 (#370) * Fixes typo (#377) * Upgrade repo tools and regenerate READMEs. (#384) * Upgrade repo tools and regenerate READMEs. * Add + run dependency updating (bash) script (#401) * Add + run dependency updating script * Address comments Change-Id: I67af9d3ab9e461b579dbaee92274b6163d73c23e * Run dependency script again Change-Id: Icbec4acb2cc6bcfa40e0a3a705c5a1059d64efa5 * Update license Change-Id: Ic1dd0a1bd34356e415bdbf005b81a71a8d2695c2 * Update (more) dependencies Change-Id: Idaed95b9cfe486797fa75946b6f55e7e702217b8 * Speech upgrade (#427) * Upgrades speech client to semi-gapic * Adds library with streaming fixes * Adds example with word time offsets. (#437) * Added enableWordTimeOffsets: true to async (file) (#440) * Avoid setting optional parameters to their default values. * More word time offset samples. (#443) * Update dependencies + fix a few tests (#448) * Add semistandard as a devDependency * Fix storage tests * Fix language tests * Update (some) dependencies * Fix language slackbot tests * Build updates. (#462) * Speech: Use all results, instead of just the first. (#466) * Update dependencies (#468) * Fix docs-samples tests, round 1 * Fix circle.yml * Add RUN_ALL_BUILDS flag * More container builder bugfixes * Tweak env vars + remove manual proxy install * Env vars in bashrc don't evaluate dynamically, so avoid them * Add semicolons for command ordering * Add appengine/static-files test to circle.yaml * Fix failing container builder tests * Address comments * Quickstart - print all results. (#479) * Repository Migration (#4) * Bump version to 0.11.0 (#5) * release 1.0.0 for GA (#9) * Update timeouts (#18) * regenerating v1 code - timeouts increased * regenerate scaffolding, bump patch version * bump version for samples package * updating version in samples (#25) * Add Speech Recognition v1p1beta1 samples (#33) * Add Speech Recognition v1p1beta1 samples * Upgrade eslint-plugin-prettier to ^2.6.0 * Upgrade repo-tools and regenerate scaffolding. (#39) * Upgrade repo-tools and regenerate scaffolding. * updating package-lock.json * make lint task work in circleci * v1.2.0 (#41) * chore: make samples depend on the current version (#43) * generated new lock files * Update sinon to the latest version 🚀 (#44) * regenerate GAPIC v1p1beta1 generated code (#48) * updating GAPIC v1p1beta1 generated code * updating GAPIC v1p1beta1 generated code * lint, package-lock * Remove projectId argument in samples (#47) * Remove projectId argument in samples * release 1.3.0 (#49) * release 1.3.0 ## Features In this minor release we updated some protos used by `v1p1beta1` endpoint (added optional `metadata` field to `RecognitionConfig` message). There is no need to change any existing code. Also, `v1` endpoint is still default. If you want to try using the new `v1p1beta1` endpoint, you need to request it in your code: ```js const speech = require('@google-cloud/nodejs-speech).v1p1beta1; ``` * updating dependency in samples/package.json * locks. again. * release 1.4.0 * Added a sample code to show auto punctuation (#57) * Added a sample code to show auto punctuation * Ran prettier * Added metadata sample code (#58) * Added metadata sample code * Fixed function name. * Ran prettier. * Sample code for Audio Logging (Enhanced Model) (#61) * Sample code for Audio Logging (Enhanced Model) * Ran prettier * bump version to 1.5.0 (#67) * Added the TODO comment suggested by Alex & Rebecca (#64) * Added the TODO comment suggested by Alex & Rebecca * Removed the duplicate import comments * chore: lock files maintenance (#70) * chore: lock files maintenance * chore: lock files maintenance * chore: lock files maintenance (#74) * chore: lock files maintenance * chore: lock files maintenance * chore: lock files maintenance (#80) * chore: lock files maintenance * chore: lock files maintenance * chore: update to the latest version of most dependencies (#90) * chore: update sample lockfiles (#95) * refactor: drop repo-tool as an exec wrapper (#96) * chore(deps): update dependency sinon to v6.0.1 (#97) * chore(deps): update dependency uuid to v3.3.0 (#98) * chore(deps): update dependency uuid to v3.3.0 * Update package.json * fix(deps): update dependency yargs to v12 (#101) * Check in synth script and update google-gax (#100) * codegen: check in synth.py * chore: update google-gax to 0.17.0 * chore(deps): lock file maintenance (#102) * chore(deps): lock file maintenance (#104) * chore(deps): lock file maintenance (#105) * chore(deps): lock file maintenance (#107) * fix: drop support for node.js 4.x and 9.x (#106) * fix: drop support for node.js 4.x and 9.x * fix my blunder * chore(deps): lock file maintenance (#108) * chore(deps): lock file maintenance (#109) * bump version to 2.0.0 (#113) * chore(deps): lock file maintenance (#117) * chore(deps): lock file maintenance (#123) * chore: require node 8 for samples (#128) * chore(deps): lock file maintenance (#129) * Code Samples for new v1p1beta1 features (#118) * MicrophoneStreamTest, and basic .ava tests- * Just cosmetic, removed some notes, added note about Event style for test. * removed .test, cleaned up yaaarghs * Cleaned up test within MicStream.js, .ava tests forthcoming * Pruned down to core streaming function, yaargs rebuilt, .ava upcoming * newest .ava test, just makes sure yaargs loads, comments addressed * Added Readme * BetaFeatures for Test, fixed from yesterday * Updated Readme * Updated Readme, fixed old paths used in testing * Updated Readme again * Updated Yaargs Examples to fit readme * Fixed Diarization bug * Speech Fixes * fixing eslint settings to merge * eslint again * testing lint quick fix * more ESlint shennanigans * cleaned up region tags * Removed audiochannelGCS * Removed Comments, also multiChannel GCS * Removed Comments, GCS MultiChannel * Removed multi Audio Channel * Added mono-channel multi Language file to sample * removed old console.log * fixed todos and filename -> fileName * removed docstrings * removed enableWordTimeOffsets in WordLvlConfidence * rebuild * fixed space * fixed package.lock for node8 circleCI * Attempted fix for circleCI node 8 * attempted mime-types fix * possible mime/CLI fix * Merged Latest package chore stuff, for circleCI * all outstanding comments, except eslint issue * confidence test fix * fixed eslinting in betaFeatures.js * eslint again * Fixed MultiChannel transcribe * multiChannelGCS test * Updated readme * updated readme, scaffolding * readme again * Re-generate library using /synth.py (#130) * chore(deps): lock file maintenance (#136) * chore: ignore package-lock.json (#138) * Speech region tag update (#145) * updates word time offsets region tag (#146) * fix: use regex to test output (#150) * fix(deps): update dependency @google-cloud/storage to v2 (#159) * Add streaming microphone sample for Speech (#87) Add streaming microphone sample for Speech * Release v2.1.0 (#165) * fix(samples): storage import (#166) * fix(tests): match regex (#174) * Speech GA – auto_punctuation & model selection (#179) * Speech-GA : speech_transcribe_auto_punctuation speech_transcribe_enhanced_model speech_transcribe_model_selection * Speech-GA : Fixing review issues. * fix: send streamingConfig as a separate write before audioContent (#176) * Release v2.1.1 (#195) * fix typo in sample (#203) * chore(deps): update dependency sinon to v7 (#202) * docs(samples): updated samples code to use async await (#214) * fix: fix the sample tests (#217) * fix: fix the sample tests again (#218) * chore(deps): update dependency @google-cloud/nodejs-repo-tools to v3 (#233) * refactor: convert samples test from ava to mocha (#221) * docs: fixed encoding typo (#263) docs: Fixed Encoding Typo * refactor: modernize the sample tests (#265) * Release v2.1.2 (#271) * Release v2.2.0 (#277) * Release v2.3.0 (#290) * fix(deps): update dependency yargs to v13 (#301) * chore(deps): update dependency mocha to v6 (#305) * Multi-channel GA sample (#295) * chore: update proto comments and fix tests (#316) * Release v2.3.1 (#324) * test: update tests to support inconsistent diarization results (#326) * refactor: use execSync for tests refactor: use execSync for tests #332 automerged by dpebot * new sample for infinite streaming command line app (#333) * new sample for infinite streaming command line app * adding infinite streaming sample to samples folder * added comments and error handling and ran eslint * corrected region tag * fixed reverted merge conflicts and made changes again. * fixed lint errors * removed stream from package.json, it is not necessary * cleaned up comment placements and removed unneeded debugging * made lint updates * made lint updates * chore: release 3.0.0 (#358) * updated CHANGELOG.md * updated package.json * updated samples/package.json * chore: release 3.1.0 (#364) * updated CHANGELOG.md * updated package.json * updated samples/package.json * chore: release 3.1.1 (#368) * updated CHANGELOG.md * updated package.json * updated samples/package.json * chore: release 3.2.0 (#378) * updated CHANGELOG.md * updated package.json * updated samples/package.json * refactor: changes formatting of various statements * Increase timeout to 5 mins (#382) * docs(samples): fix infinite streaming example typo (#387) * chore: release 3.2.1 (#386) * updated CHANGELOG.md * updated package.json * updated samples/package.json * chore: release 3.2.2 (#394) * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] * chore: release 3.2.3 (#401) * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] * docs(samples): update node-record-lpcm16 and related changes (#403) * chore: release 3.2.4 (#410) * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] * chore(deps): update dependency @google-cloud/storage to v3 (#408) * chore: release 3.2.5 (#418) * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] * fix(deps): update dependency yargs to v14 * chore: release 3.2.6 (#423) * chore: release 3.3.0 (#429) * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] * test: switch tests to new resource names (#440) * fix(deps): update dependency @google-cloud/storage to v4 (#449) * chore: release 3.3.2 (#450) * chore(deps): update dependency chalk to v3 (#461) * feat(samples): bump auto-punctuation sample to v1 and move diarization to v1 (#463) * bumped diarization and autocapitalization samples to v1 * Remove extra commited file * fixed linting error * chore: release 3.4.0 (#464) * fix(deps): update dependency yargs to v15 (#469) * feat: convert to TypeScript (#472) * feat: convert library to TypeScript * test: system tests in TypeScript * fix: run synthtool * fix: no posttest please * fix: docs * fix: pr feedback, synthtool * chore: release 3.5.0 (#474) * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] * docs: update changelog * chore: update license headers (#476) * chore: release 3.5.1 (#481) * chore: release 3.5.2 (#486) * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] * fix: added clarity around needing SoX for 'streamingMicRecognize' sample * chore: release 3.5.3 (#488) * refactor: use explicit mocha imports (#496) * chore(deps): update dependency c8 to v7 (#493) * chore: release 3.5.4 * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] * chore(deps): update dependency mocha to v7 (#498) * feat: created sample for speechcontext classes (#515) * Created sample for speechContext classes Co-authored-by: Benjamin E. Coe <bencoe@google.com> * chore: release 3.6.0 (#521) * chore(deps): update dependency uuid to v7 * feat!: drop node8 support (#562) * feat!: drop node8 support BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM. * fix: lint * fix(deps): update dependency chalk to v4 (#567) * chore(deps): update dependency uuid to v8 (#588) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [uuid](https://togithub.com/uuidjs/uuid) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/uuid/7.0.3/8.0.0) | --- ### Release Notes <details> <summary>uuidjs/uuid</summary> ### [`v8.0.0`](https://togithub.com/uuidjs/uuid/blob/master/CHANGELOG.md#800-httpsgithubcomuuidjsuuidcomparev703v800-2020-04-29) [Compare Source](https://togithub.com/uuidjs/uuid/compare/v7.0.3...v8.0.0) ##### ⚠ BREAKING CHANGES - For native ECMAScript Module (ESM) usage in Node.js only named exports are exposed, there is no more default export. ```diff -import uuid from 'uuid'; -console.log(uuid.v4()); // -> 'cd6c3b08-0adc-4f4b-a6ef-36087a1c9869' +import { v4 as uuidv4 } from 'uuid'; +uuidv4(); // ⇨ '9b1deb4d-3b7d-4bad-9bdd-2b0d7b3dcb6d' ``` - Deep requiring specific algorithms of this library like `require('uuid/v4')`, which has been deprecated in `uuid@7`, is no longer supported. Instead use the named exports that this module exports. For ECMAScript Modules (ESM): ```diff -import uuidv4 from 'uuid/v4'; +import { v4 as uuidv4 } from 'uuid'; uuidv4(); ``` For CommonJS: ```diff -const uuidv4 = require('uuid/v4'); +const { v4: uuidv4 } = require('uuid'); uuidv4(); ``` ##### Features - native Node.js ES Modules (wrapper approach) ([#423](https://togithub.com/uuidjs/uuid/issues/423)) ([2d9f590](https://togithub.com/uuidjs/uuid/commit/2d9f590ad9701d692625c07ed62f0a0f91227991)), closes [#245](https://togithub.com/uuidjs/uuid/issues/245) [#419](https://togithub.com/uuidjs/uuid/issues/419) [#342](https://togithub.com/uuidjs/uuid/issues/342) - remove deep requires ([#426](https://togithub.com/uuidjs/uuid/issues/426)) ([daf72b8](https://togithub.com/uuidjs/uuid/commit/daf72b84ceb20272a81bb5fbddb05dd95922cbba)) ##### Bug Fixes - add CommonJS syntax example to README quickstart section ([#417](https://togithub.com/uuidjs/uuid/issues/417)) ([e0ec840](https://togithub.com/uuidjs/uuid/commit/e0ec8402c7ad44b7ef0453036c612f5db513fda0)) ##### [7.0.3](https://togithub.com/uuidjs/uuid/compare/v7.0.2...v7.0.3) (2020-03-31) ##### Bug Fixes - make deep require deprecation warning work in browsers ([#409](https://togithub.com/uuidjs/uuid/issues/409)) ([4b71107](https://togithub.com/uuidjs/uuid/commit/4b71107d8c0d2ef56861ede6403fc9dc35a1e6bf)), closes [#408](https://togithub.com/uuidjs/uuid/issues/408) ##### [7.0.2](https://togithub.com/uuidjs/uuid/compare/v7.0.1...v7.0.2) (2020-03-04) ##### Bug Fixes - make access to msCrypto consistent ([#393](https://togithub.com/uuidjs/uuid/issues/393)) ([8bf2a20](https://togithub.com/uuidjs/uuid/commit/8bf2a20f3565df743da7215eebdbada9d2df118c)) - simplify link in deprecation warning ([#391](https://togithub.com/uuidjs/uuid/issues/391)) ([bb2c8e4](https://togithub.com/uuidjs/uuid/commit/bb2c8e4e9f4c5f9c1eaaf3ea59710c633cd90cb7)) - update links to match content in readme ([#386](https://togithub.com/uuidjs/uuid/issues/386)) ([44f2f86](https://togithub.com/uuidjs/uuid/commit/44f2f86e9d2bbf14ee5f0f00f72a3db1292666d4)) ##### [7.0.1](https://togithub.com/uuidjs/uuid/compare/v7.0.0...v7.0.1) (2020-02-25) ##### Bug Fixes - clean up esm builds for node and browser ([#383](https://togithub.com/uuidjs/uuid/issues/383)) ([59e6a49](https://togithub.com/uuidjs/uuid/commit/59e6a49e7ce7b3e8fb0f3ee52b9daae72af467dc)) - provide browser versions independent from module system ([#380](https://togithub.com/uuidjs/uuid/issues/380)) ([4344a22](https://togithub.com/uuidjs/uuid/commit/4344a22e7aed33be8627eeaaf05360f256a21753)), closes [#378](https://togithub.com/uuidjs/uuid/issues/378) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-speech). * fix(samples): use writable stream (#597) * fix(deps): update dependency @google-cloud/storage to v5 (#595) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@google-cloud/storage](https://togithub.com/googleapis/nodejs-storage) | dependencies | major | [`^4.0.0` -> `^5.0.0`](https://renovatebot.com/diffs/npm/@google-cloud%2fstorage/4.7.0/5.0.0) | --- ### Release Notes <details> <summary>googleapis/nodejs-storage</summary> ### [`v5.0.0`](https://togithub.com/googleapis/nodejs-storage/blob/master/CHANGELOG.md#500-httpswwwgithubcomgoogleapisnodejs-storagecomparev470v500-2020-05-13) [Compare Source](https://togithub.com/googleapis/nodejs-storage/compare/v4.7.0...v5.0.0) ##### ⚠ BREAKING CHANGES - automatically detect contentType if not provided ([#1190](https://togithub.com/googleapis/nodejs-storage/issues/1190)) - drop keepAcl parameter in file copy ([#1166](https://togithub.com/googleapis/nodejs-storage/issues/1166)) - drop support for node.js 8.x ##### Features - automatically detect contentType if not provided ([#1190](https://www.github.com/googleapis/nodejs-storage/issues/1190)) ([b31ba4a](https://www.github.com/googleapis/nodejs-storage/commit/b31ba4a11399b57538ddf0d6ca2e10b2aa3fbc3a)) - enable bytes read tracking ([#1074](https://www.github.com/googleapis/nodejs-storage/issues/1074)) ([0776a04](https://www.github.com/googleapis/nodejs-storage/commit/0776a044f3b2149b485e114369e952688df75645)) ##### Bug Fixes - **bucket:** Only disable resumable uploads for bucket.upload (fixes [#1133](https://www.github.com/googleapis/nodejs-storage/issues/1133)) ([#1135](https://www.github.com/googleapis/nodejs-storage/issues/1135)) ([2c20148](https://www.github.com/googleapis/nodejs-storage/commit/2c201486b7b2d3146846ac96c877a904c4a674b0)), closes [/github.com/googleapis/nodejs-storage/pull/1135#issuecomment-620070038](https://www.github.com/googleapis//github.com/googleapis/nodejs-storage/pull/1135/issues/issuecomment-620070038) - add whitespace to generateV4SignedPolicy ([#1136](https://www.github.com/googleapis/nodejs-storage/issues/1136)) ([dcee78b](https://www.github.com/googleapis/nodejs-storage/commit/dcee78b98da23b02fe7d2f13a9270546bc07bba8)) - apache license URL ([#468](https://www.github.com/googleapis/nodejs-storage/issues/468)) ([#1151](https://www.github.com/googleapis/nodejs-storage/issues/1151)) ([e8116d3](https://www.github.com/googleapis/nodejs-storage/commit/e8116d3c6fa7412858692e67745b514eef78850e)) - Point to team in correct org ([#1185](https://www.github.com/googleapis/nodejs-storage/issues/1185)) ([0bb1909](https://www.github.com/googleapis/nodejs-storage/commit/0bb19098013acf71cc3842f78ff333a8e356331a)) - **deps:** update dependency [@google-cloud/common](https://togithub.com/google-cloud/common) to v3 ([#1134](https://www.github.com/googleapis/nodejs-storage/issues/1134)) ([774ac5c](https://www.github.com/googleapis/nodejs-storage/commit/774ac5c75f02238418cc8ed7242297ea573ca9cb)) - **deps:** update dependency [@google-cloud/paginator](https://togithub.com/google-cloud/paginator) to v3 ([#1131](https://www.github.com/googleapis/nodejs-storage/issues/1131)) ([c1614d9](https://www.github.com/googleapis/nodejs-storage/commit/c1614d98e3047db379e09299b1014e80d73ed52f)) - **deps:** update dependency [@google-cloud/promisify](https://togithub.com/google-cloud/promisify) to v2 ([#1127](https://www.github.com/googleapis/nodejs-storage/issues/1127)) ([06624a5](https://www.github.com/googleapis/nodejs-storage/commit/06624a534cd1fdbc38455eee8d89f9f60ba75758)) - **deps:** update dependency uuid to v8 ([#1170](https://www.github.com/googleapis/nodejs-storage/issues/1170)) ([6a98d64](https://www.github.com/googleapis/nodejs-storage/commit/6a98d64831baf1ca1ec2f03ecc4914745cba1c86)) - **deps:** update gcs-resumable-upload, remove gitnpm usage ([#1186](https://www.github.com/googleapis/nodejs-storage/issues/1186)) ([c78c9cd](https://www.github.com/googleapis/nodejs-storage/commit/c78c9cde49dccb2fcd4ce10e4e9f8299d65f6838)) - **v4-policy:** encode special characters ([#1169](https://www.github.com/googleapis/nodejs-storage/issues/1169)) ([6e48539](https://www.github.com/googleapis/nodejs-storage/commit/6e48539d76ca27e6f4c6cf2ac0872970f7391fed)) - sync to [googleapis/conformance-tests@`fa559a1`](https://togithub.com/googleapis/conformance-tests/commit/fa559a1) ([#1167](https://www.github.com/googleapis/nodejs-storage/issues/1167)) ([5500446](https://www.github.com/googleapis/nodejs-storage/commit/550044619d2f17a1977c83bce5df915c6dc9578c)), closes [#1168](https://www.github.com/googleapis/nodejs-storage/issues/1168) ##### Miscellaneous Chores - drop keepAcl parameter in file copy ([#1166](https://www.github.com/googleapis/nodejs-storage/issues/1166)) ([5a4044a](https://www.github.com/googleapis/nodejs-storage/commit/5a4044a8ba13f248fc4f791248f797eb0f1f3c16)) ##### Build System - drop support for node.js 8.x ([b80c025](https://www.github.com/googleapis/nodejs-storage/commit/b80c025f106052fd25554c64314b3b3520e829b5)) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-speech). * chore: release 4.0.0 (#566) * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore(deps): update dependency mocha to v8 (#606) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [mocha](https://mochajs.org/) ([source](https://togithub.com/mochajs/mocha)) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/mocha/7.2.0/8.0.1) | --- ### Release Notes <details> <summary>mochajs/mocha</summary> ### [`v8.0.1`](https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#801--2020-06-10) [Compare Source](https://togithub.com/mochajs/mocha/compare/v8.0.0...v8.0.1) The obligatory patch after a major. #### :bug: Fixes - [#4328](https://togithub.com/mochajs/mocha/issues/4328): Fix `--parallel` when combined with `--watch` ([**@boneskull**](https://togithub.com/boneskull)) ### [`v8.0.0`](https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#800--2020-06-10) [Compare Source](https://togithub.com/mochajs/mocha/compare/v7.2.0...v8.0.0) In this major release, Mocha adds the ability to _run tests in parallel_. Better late than never! Please note the **breaking changes** detailed below. Let's welcome [**@giltayar**](https://togithub.com/giltayar) and [**@nicojs**](https://togithub.com/nicojs) to the maintenance team! #### :boom: Breaking Changes - [#4164](https://togithub.com/mochajs/mocha/issues/4164): **Mocha v8.0.0 now requires Node.js v10.0.0 or newer.** Mocha no longer supports the Node.js v8.x line ("Carbon"), which entered End-of-Life at the end of 2019 ([**@UlisesGascon**](https://togithub.com/UlisesGascon)) - [#4175](https://togithub.com/mochajs/mocha/issues/4175): Having been deprecated with a warning since v7.0.0, **`mocha.opts` is no longer supported** ([**@juergba**](https://togithub.com/juergba)) :sparkles: **WORKAROUND:** Replace `mocha.opts` with a [configuration file](https://mochajs.org/#configuring-mocha-nodejs). - [#4260](https://togithub.com/mochajs/mocha/issues/4260): Remove `enableTimeout()` (`this.enableTimeout()`) from the context object ([**@craigtaub**](https://togithub.com/craigtaub)) :sparkles: **WORKAROUND:** Replace usage of `this.enableTimeout(false)` in your tests with `this.timeout(0)`. - [#4315](https://togithub.com/mochajs/mocha/issues/4315): The `spec` option no longer supports a comma-delimited list of files ([**@juergba**](https://togithub.com/juergba)) :sparkles: **WORKAROUND**: Use an array instead (e.g., `"spec": "foo.js,bar.js"` becomes `"spec": ["foo.js", "bar.js"]`). - [#4309](https://togithub.com/mochajs/mocha/issues/4309): Drop support for Node.js v13.x line, which is now End-of-Life ([**@juergba**](https://togithub.com/juergba)) - [#4282](https://togithub.com/mochajs/mocha/issues/4282): `--forbid-only` will throw an error even if exclusive tests are avoided via `--grep` or other means ([**@arvidOtt**](https://togithub.com/arvidOtt)) - [#4223](https://togithub.com/mochajs/mocha/issues/4223): The context object's `skip()` (`this.skip()`) in a "before all" (`before()`) hook will no longer execute subsequent sibling hooks, in addition to hooks in child suites ([**@juergba**](https://togithub.com/juergba)) - [#4178](https://togithub.com/mochajs/mocha/issues/4178): Remove previously soft-deprecated APIs ([**@wnghdcjfe**](https://togithub.com/wnghdcjfe)): - `Mocha.prototype.ignoreLeaks()` - `Mocha.prototype.useColors()` - `Mocha.prototype.useInlineDiffs()` - `Mocha.prototype.hideDiff()` #### :tada: Enhancements - [#4245](https://togithub.com/mochajs/mocha/issues/4245): Add ability to run tests in parallel for Node.js (see [docs](https://mochajs.org/#parallel-tests)) ([**@boneskull**](https://togithub.com/boneskull)) :exclamation: See also [#4244](https://togithub.com/mochajs/mocha/issues/4244); [Root Hook Plugins (docs)](https://mochajs.org/#root-hook-plugins) -- _root hooks must be defined via Root Hook Plugins to work in parallel mode_ - [#4304](https://togithub.com/mochajs/mocha/issues/4304): `--require` now works with ES modules ([**@JacobLey**](https://togithub.com/JacobLey)) - [#4299](https://togithub.com/mochajs/mocha/issues/4299): In some circumstances, Mocha can run ES modules under Node.js v10 -- _use at your own risk!_ ([**@giltayar**](https://togithub.com/giltayar)) #### :book: Documentation - [#4246](https://togithub.com/mochajs/mocha/issues/4246): Add documentation for parallel mode and Root Hook plugins ([**@boneskull**](https://togithub.com/boneskull)) #### :bug: Fixes (All bug fixes in Mocha v8.0.0 are also breaking changes, and are listed above) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-speech). * chore: release 4.1.0 (#607) * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 4.1.1 (#614) * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * fix(samples): end stream before destroying it (#611) I've been getting this error until I put call of end() for the stream before destroying it. `API request error 14 UNAVAILABLE: 408:Request Timeout` Co-authored-by: Alexander Fenster <fenster@google.com> * chore: release 4.1.2 (#641) * chore: updated samples/package.json [ci skip] * chore: updated CHANGELOG.md [ci skip] * chore: updated package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * fix(deps): update dependency yargs to v16 (#646) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [yargs](https://yargs.js.org/) ([source](https://togithub.com/yargs/yargs)) | dependencies | major | [`^15.0.0` -> `^16.0.0`](https://renovatebot.com/diffs/npm/yargs/15.4.1/16.0.1) | --- ### Release Notes <details> <summary>yargs/yargs</summary> ### [`v16.0.1`](https://togithub.com/yargs/yargs/blob/master/CHANGELOG.md#1601-httpswwwgithubcomyargsyargscomparev1600v1601-2020-09-09) [Compare Source](https://togithub.com/yargs/yargs/compare/v16.0.0...v16.0.1) ### [`v16.0.0`](https://togithub.com/yargs/yargs/blob/master/CHANGELOG.md#1600-httpswwwgithubcomyargsyargscomparev1542v1600-2020-09-09) [Compare Source](https://togithub.com/yargs/yargs/compare/v15.4.1...v16.0.0) ##### ⚠ BREAKING CHANGES - tweaks to ESM/Deno API surface: now exports yargs function by default; getProcessArgvWithoutBin becomes hideBin; types now exported for Deno. - find-up replaced with escalade; export map added (limits importable files in Node >= 12); yarser-parser@19.x.x (new decamelize/camelcase implementation). - **usage:** single character aliases are now shown first in help output - rebase helper is no longer provided on yargs instance. - drop support for EOL Node 8 ([#1686](https://togithub.com/yargs/yargs/issues/1686)) ##### Features - adds strictOptions() ([#1738](https://www.github.com/yargs/yargs/issues/1738)) ([b215fba](https://www.github.com/yargs/yargs/commit/b215fba0ed6e124e5aad6cf22c8d5875661c63a3)) - **helpers:** rebase, Parser, applyExtends now blessed helpers ([#1733](https://www.github.com/yargs/yargs/issues/1733)) ([c7debe8](https://www.github.com/yargs/yargs/commit/c7debe8eb1e5bc6ea20b5ed68026c56e5ebec9e1)) - adds support for ESM and Deno ([#1708](https://www.github.com/yargs/yargs/issues/1708)) ([ac6d5d1](https://www.github.com/yargs/yargs/commit/ac6d5d105a75711fe703f6a39dad5181b383d6c6)) - drop support for EOL Node 8 ([#1686](https://www.github.com/yargs/yargs/issues/1686)) ([863937f](https://www.github.com/yargs/yargs/commit/863937f23c3102f804cdea78ee3097e28c7c289f)) - i18n for ESM and Deno ([#1735](https://www.github.com/yargs/yargs/issues/1735)) ([c71783a](https://www.github.com/yargs/yargs/commit/c71783a5a898a0c0e92ac501c939a3ec411ac0c1)) - tweaks to API surface based on user feedback ([#1726](https://www.github.com/yargs/yargs/issues/1726)) ([4151fee](https://www.github.com/yargs/yargs/commit/4151fee4c33a97d26bc40de7e623e5b0eb87e9bb)) - **usage:** single char aliases first in help ([#1574](https://www.github.com/yargs/yargs/issues/1574)) ([a552990](https://www.github.com/yargs/yargs/commit/a552990c120646c2d85a5c9b628e1ce92a68e797)) ##### Bug Fixes - **yargs:** add missing command(module) signature ([#1707](https://www.github.com/yargs/yargs/issues/1707)) ([0f81024](https://www.github.com/yargs/yargs/commit/0f810245494ccf13a35b7786d021b30fc95ecad5)), closes [#1704](https://www.github.com/yargs/yargs/issues/1704) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-speech). * chore: release 4.1.3 (#647) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * samples: updated comments on recognize.js to reflect time limitations… (#650) * docs: modernize patterns in subset of samples (#660) * chore: release 4.1.4 (#670) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: added a sample that shows the use of the profanity filter (#678) * chore: release 4.1.5 (#675) :robot: I have created a release \*beep\* \*boop\* --- ### [4.1.5](https://www.github.com/googleapis/nodejs-speech/compare/v4.1.4...v4.1.5) (2020-12-02) ### Bug Fixes * **browser:** check for fetch on window ([6378dc1](https://www.github.com/googleapis/nodejs-speech/commit/6378dc193da2f792645ed0ec221c9a3495264486)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). * feat: adds a multi region sample (#685) * refactor: uses gcs remote (#683) * samples: updated comments on recognize.js to reflect time limitations on local file * samples: updated comments on recognize.js to reflect time limitations on local file * chore: added a sample that showcases the use the of the profanity filter * chore: updated copyright to 2020 * fix: fixed lint * docs: variables to uncomment * docs: variables to uncomment * docs: variables to uncomment * refactor: quickstart now uses gcs * refactor: quickstart now uses gcs * refactor: quickstart now uses gcs Co-authored-by: Benjamin E. Coe <bencoe@google.com> * chore: release 4.2.0 (#687) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: Added missing config field (#701) * chore: added a sample that showcases the use the of the profanity filter * docs: variables to uncomment * docs: variables to uncomment * docs: variables to uncomment * refactor: quickstart now uses gcs * refactor: quickstart now uses gcs * refactor: quickstart now uses gcs * feat: adds a new sample * chore: applied suggested changes * chore: added missing required config field for auto punctuation sample * chore: change audio file for sample rate * chore: fixed * chore: comment * chore: changed: added comment instead * chore: release 4.3.0 (#705) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 4.4.0 (#709) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * docs(samples): adds model adaptation sample (#712) * test: address class ID error (#736) build: migrate to OwlBot * chore: release 4.5.0 (#738) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * docs: add additional context to samples (#672) * test: cleanUp should be awaited (#752) * chore: changed assert output to check constant values (#749) Fixes #744 🦕 * chore: release 4.5.1 (#741) :robot: I have created a release \*beep\* \*boop\* --- ### [4.5.1](https://www.github.com/googleapis/nodejs-speech/compare/v4.5.0...v4.5.1) (2021-05-20) ### Bug Fixes * **deps:** require google-gax v2.12.0 ([#740](https://www.github.com/googleapis/nodejs-speech/issues/740)) ([0c9c68f](https://www.github.com/googleapis/nodejs-speech/commit/0c9c68f79eee3a9132f0cf18c44a45928da2e809)) * use require() to load JSON protos ([#746](https://www.github.com/googleapis/nodejs-speech/issues/746)) ([689af48](https://www.github.com/googleapis/nodejs-speech/commit/689af48120572779143f16f7d1b0652bdddd931e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 4.5.2 (#756) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * samples: adds export to GCS sample (#757) * samples: adds export to GCS sample * 🦉 Updates from OwlBot * fix: lint * fix: removed .vscode from repo * fix: adds new sample to linkinator exceptions Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore: solves resource id issues (#743) * chore: release 4.5.3 (#769) :robot: I have created a release \*beep\* \*boop\* --- ### [4.5.3](https://www.github.com/googleapis/nodejs-speech/compare/v4.5.2...v4.5.3) (2021-06-29) ### Bug Fixes * **deps:** google-gax v2.17.0 with mTLS ([#772](https://www.github.com/googleapis/nodejs-speech/issues/772)) ([582e5b7](https://www.github.com/googleapis/nodejs-speech/commit/582e5b71c68be635f7ce775f06d5e7b02180fbef)) * make request optional in all cases ([#768](https://www.github.com/googleapis/nodejs-speech/issues/768)) ([83e1b7b](https://www.github.com/googleapis/nodejs-speech/commit/83e1b7bd4cc2d6ffd95769a4a6f519ab23b9bc71)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 4.5.4 (#775) :robot: I have created a release \*beep\* \*boop\* --- ### [4.5.4](https://www.github.com/googleapis/nodejs-speech/compare/v4.5.3...v4.5.4) (2021-07-12) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#774](https://www.github.com/googleapis/nodejs-speech/issues/774)) ([a30fb11](https://www.github.com/googleapis/nodejs-speech/commit/a30fb114f5c0cec095b1b1bd1f1678e2e3dba6fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 4.5.5 (#778) :robot: I have created a release \*beep\* \*boop\* --- ### [4.5.5](https://www.github.com/googleapis/nodejs-speech/compare/v4.5.4...v4.5.5) (2021-07-21) ### Bug Fixes * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#777](https://www.github.com/googleapis/nodejs-speech/issues/777)) ([8911be0](https://www.github.com/googleapis/nodejs-speech/commit/8911be0cc600b4d16af5a809800118be07f8483b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 4.5.6 (#785) :robot: I have created a release \*beep\* \*boop\* --- ### [4.5.6](https://www.github.com/googleapis/nodejs-speech/compare/v4.5.5...v4.5.6) (2021-08-02) ### Bug Fixes * failing tests for LRO check methods ([#784](https://www.github.com/googleapis/nodejs-speech/issues/784)) ([08e4276](https://www.github.com/googleapis/nodejs-speech/commit/08e4276a39a74a45300041278dc3c63602971c10)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 4.6.0 (#788) :robot: I have created a release \*beep\* \*boop\* --- ## [4.6.0](https://www.github.com/googleapis/nodejs-speech/compare/v4.5.6...v4.6.0) (2021-08-10) ### Features * add total_billed_time response field ([#787](https://www.github.com/googleapis/nodejs-speech/issues/787)) ([171cba0](https://www.github.com/googleapis/nodejs-speech/commit/171cba0bb8f7bd12ab96f296824e0acf7a0698d7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 4.6.1 (#791) :robot: I have created a release \*beep\* \*boop\* --- ### [4.6.1](https://www.github.com/googleapis/nodejs-speech/compare/v4.6.0...v4.6.1) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#790](https://www.github.com/googleapis/nodejs-speech/issues/790)) ([bd8ab29](https://www.github.com/googleapis/nodejs-speech/commit/bd8ab29d3b6480d854a8a3a23e520d09d6bdb298)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 4.7.0 (#793) :robot: I have created a release \*beep\* \*boop\* --- ## [4.7.0](https://www.github.com/googleapis/nodejs-speech/compare/v4.6.1...v4.7.0) (2021-08-19) ### Features * Add transcript normalization ([#792](https://www.github.com/googleapis/nodejs-speech/issues/792)) ([08ed5b5](https://www.github.com/googleapis/nodejs-speech/commit/08ed5b51bda6f158d6c5709a6ca3393aa0c61c3d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 4.8.0 (#795) :robot: I have created a release \*beep\* \*boop\* --- ## [4.8.0](https://www.github.com/googleapis/nodejs-speech/compare/v4.7.0...v4.8.0) (2021-08-23) ### Features * turns on self-signed JWT feature flag ([#794](https://www.github.com/googleapis/nodejs-speech/issues/794)) ([8e655cd](https://www.github.com/googleapis/nodejs-speech/commit/8e655cd9efc3515bd452e3ab6349adeb9ddfd104)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 4.8.1 (#798) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 4.9.0 (#802) :robot: I have created a release \*beep\* \*boop\* --- ## [4.9.0](https://www.github.com/googleapis/nodejs-speech/compare/v4.8.1...v4.9.0) (2021-09-20) ### Features * add output_config request field ([#801](https://www.github.com/googleapis/nodejs-speech/issues/801)) ([b4f8cbf](https://www.github.com/googleapis/nodejs-speech/commit/b4f8cbff71e3cbdce4d7fb7cbe67f7065f4c6a2b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * docs(samples): refactors the export to gcs sample (#821) * docs(samples): updated SpeakerDiarizationConfig to use min and max count (#827) * fix(deps): update dependency chalk to v5 (#823) * chore(main): release 4.10.1 (#870) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Summer Ji <summerji@google.com> * chore(main): release 4.10.2 (#883) :robot: I have created a release *beep* *boop* --- ### [4.10.2](https://github.com/googleapis/nodejs-speech/compare/v4.10.1...v4.10.2) (2022-05-02) ### Bug Fixes * flaky system test ([#882](https://github.com/googleapis/nodejs-speech/issues/882)) ([e837b64](https://github.com/googleapis/nodejs-speech/commit/e837b642990c67080963623aa35febbd86c3ae08)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * build!: update library to use Node 12 (#891) * feat!: Update library to use Node 12 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(main): release 5.0.0 (#906) :robot: I have created a release *beep* *boop* --- ## [5.0.0](https://github.com/googleapis/nodejs-speech/compare/v4.10.2...v5.0.0) (2022-06-24) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#891) ### Build System * update library to use Node 12 ([#891](https://github.com/googleapis/nodejs-speech/issues/891)) ([73a2f72](https://github.com/googleapis/nodejs-speech/commit/73a2f7223274d75be929ed074083970425bd3997)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * fix(deps): update dependency @google-cloud/storage to v6 (#893) * fix(deps): do not depend on protobufjs; bump dep in samples (#911) * fix(deps): update dependency protobufjs to v7 * fix(deps): do not depend on protobufjs directly Co-authored-by: Alexander Fenster <fenster@google.com> * fix(deps): update dependency google-proto-files to v3 (#900) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-proto-files](https://togithub.com/googleapis/nodejs-proto-files) | [`^2.5.0` -> `^3.0.0`](https://renovatebot.com/diffs/npm/google-proto-files/2.5.2/3.0.1) | [![age](https://badges.renovateapi.com/packages/npm/google-proto-files/3.0.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/google-proto-files/3.0.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/google-proto-files/3.0.1/compatibility-slim/2.5.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/google-proto-files/3.0.1/confidence-slim/2.5.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/nodejs-proto-files</summary> ### [`v3.0.1`](https://togithub.com/googleapis/nodejs-proto-files/blob/HEAD/CHANGELOG.md#301-httpsgithubcomgoogleapisnodejs-proto-filescomparev300v301-2022-07-21) [Compare Source](https://togithub.com/googleapis/nodejs-proto-files/compare/v3.0.0...v3.0.1) ##### Bug Fixes - **deps:** update dependency protobufjs to v7 ([#439](https://togithub.com/googleapis/nodejs-proto-files/issues/439)) ([41b973f](https://togithub.com/googleapis/nodejs-proto-files/commit/41b973f71e0a84b64d5bafa4a0d878224223d91a)) ### [`v3.0.0`](https://togithub.com/googleapis/nodejs-proto-files/blob/HEAD/CHANGELOG.md#300-httpsgithubcomgoogleapisnodejs-proto-filescomparev252v300-2022-05-20) [Compare Source](https://togithub.com/googleapis/nodejs-proto-files/compare/v2.5.2...v3.0.0) ##### ⚠ BREAKING CHANGES - update library to use Node 12 ([#434](https://togithub.com/googleapis/nodejs-proto-files/issues/434)) ##### Build System - update library to use Node 12 ([#434](https://togithub.com/googleapis/nodejs-proto-files/issues/434)) ([2d8996e](https://togithub.com/googleapis/nodejs-proto-files/commit/2d8996e1e37384b904a583808f14c2d28a4a961e)) ##### [2.5.2](https://togithub.com/googleapis/nodejs-proto-files/compare/v2.5.1...v2.5.2) (2022-05-03) ##### Bug Fixes - protobuf moved to main branch ([#426](https://togithub.com/googleapis/nodejs-proto-files/issues/426)) ([a8b9121](https://togithub.com/googleapis/nodejs-proto-files/commit/a8b9121151d2216d4eafab2808d42ce60d37a6a1)) ##### [2.5.1](https://www.github.com/googleapis/nodejs-proto-files/compare/v2.5.0...v2.5.1) (2021-12-21) ##### Bug Fixes - **proto:** speech has additional common proto ([#382](https://www.togithub.com/googleapis/nodejs-proto-files/issues/382)) ([6423650](https://www.github.com/googleapis/nodejs-proto-files/commit/64236509b38a8b3e864e4c679fa3c7392db39587)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-speech).  * fix(deps): update dependency proto3-json-serializer to v1 (#890) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [proto3-json-serializer](https://togithub.com/googleapis/proto3-json-serializer-nodejs) | [`^0.1.6` -> `^1.0.0`](https://renovatebot.com/diffs/npm/proto3-json-serializer/0.1.9/1.0.3) | [![age](https://badges.renovateapi.com/packages/npm/proto3-json-serializer/1.0.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/proto3-json-serializer/1.0.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/proto3-json-serializer/1.0.3/compatibility-slim/0.1.9)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/proto3-json-serializer/1.0.3/confidence-slim/0.1.9)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/proto3-json-serializer-nodejs</summary> ### [`v1.0.3`](https://togithub.com/googleapis/proto3-json-serializer-nodejs/blob/HEAD/CHANGELOG.md#103-httpsgithubcomgoogleapisproto3-json-serializer-nodejscomparev102v103-2022-07-10) [Compare Source](https://togithub.com/googleapis/proto3-json-serializer-nodejs/compare/v1.0.2...v1.0.3) ##### Bug Fixes - **deps:** update dependency protobufjs to v7 ([#56](https://togithub.com/googleapis/proto3-json-serializer-nodejs/issues/56)) ([038fea5](https://togithub.com/googleapis/proto3-json-serializer-nodejs/commit/038fea537c8809dc272c2352b832b5301c7b79d2)) ### [`v1.0.2`](https://togithub.com/googleapis/proto3-json-serializer-nodejs/blob/HEAD/CHANGELOG.md#102-httpsgithubcomgoogleapisproto3-json-serializer-nodejscomparev101v102-2022-06-15) [Compare Source](https://togithub.com/googleapis/proto3-json-serializer-nodejs/compare/v1.0.1...v1.0.2) ##### Bug Fixes - **deps:** update dependency google-proto-files to v3 ([#53](https://togithub.com/googleapis/proto3-json-serializer-nodejs/issues/53)) ([40fd527](https://togithub.com/googleapis/proto3-json-serializer-nodejs/commit/40fd527109838a21887f7a5058406244acabe938)) ### [`v1.0.1`](https://togithub.com/googleapis/proto3-json-serializer-nodejs/blob/HEAD/CHANGELOG.md#101-httpsgithubcomgoogleapisproto3-json-serializer-nodejscomparev100v101-2022-06-03) [Compare Source](https://togithub.com/googleapis/proto3-json-serializer-nodejs/compare/v1.0.0...v1.0.1) ##### Bug Fixes - **deps:** bump protobuf.js to ^6.11.3 ([#46](https://togithub.com/googleapis/proto3-json-serializer-nodejs/issues/46)) ([af8a14a](https://togithub.com/googleapis/proto3-json-serializer-nodejs/commit/af8a14a35c04cbef49bff806b7d906287d1d2c0d)) ### [`v1.0.0`](https://togithub.com/googleapis/proto3-json-serializer-nodejs/blob/HEAD/CHANGELOG.md#100-httpsgithubcomgoogleapisproto3-json-serializer-nodejscomparev019v100-2022-05-12) [Compare Source](https://togithub.com/googleapis/proto3-json-serializer-nodejs/compare/v0.1.9...v1.0.0) ##### ⚠ BREAKING CHANGES - make Node 12 minimum language version ([#38](https://togithub.com/googleapis/proto3-json-serializer-nodejs/issues/38)) ##### Features - make Node 12 minimum language version ([#38](https://togithub.com/googleapis/proto3-json-serializer-nodejs/issues/38)) ([658d29e](https://togithub.com/googleapis/proto3-json-serializer-nodejs/commit/658d29e531c2d04d4007e5843aa62d9d8ee0dae8)) ##### [0.1.9](https://togithub.com/googleapis/proto3-json-serializer-nodejs/compare/v0.1.8...v0.1.9) (2022-05-11) ##### Bug Fixes - do not use Node.js assert ([#37](https://togithub.com/googleapis/proto3-json-serializer-nodejs/issues/37)) ([dccfeca](https://togithub.com/googleapis/proto3-json-serializer-nodejs/commit/dccfeca6f3bbeec29d88319f375a734ec48aadf7)) ##### [0.1.8](https://togithub.com/googleapis/proto3-json-serializer-nodejs/compare/v0.1.7...v0.1.8) (2022-01-21) ##### Bug Fixes - timestamp without millisecond ([#30](https://togithub.com/googleapis/proto3-json-serializer-nodejs/issues/30)) ([a55d0b6](https://togithub.com/googleapis/proto3-json-serializer-nodejs/commit/a55d0b6f98f6d1c8b7d971d0a583bbd82ea66983)) ##### [0.1.7](https://togithub.com/googleapis/proto3-json-serializer-nodejs/compare/v0.1.6...v0.1.7) (2022-01-14) ##### Bug Fixes - keep nano second precision when maps between JSON and proto3 ([#28](https://togithub.com/googleapis/proto3-json-serializer-nodejs/issues/28)) ([eaa01ce](https://togithub.com/googleapis/proto3-json-serializer-nodejs/commit/eaa01ce92c4eefa816d1d6f8ef6ed11bd2a6364b)) ##### [0.1.6](https://www.github.com/googleapis/proto3-json-serializer-nodejs/compare/v0.1.5...v0.1.6) (2021-11-15) ##### Bug Fixes - **deps:** protobufjs is a dependency for the types ([#23](https://www.togithub.com/googleapis/proto3-json-serializer-nodejs/issues/23)) ([06470c1](https://www.github.com/googleapis/proto3-json-serializer-nodejs/commit/06470c1df501439ec3f8bc546cd23d798604f3bd)) ##### [0.1.5](https://www.github.com/googleapis/proto3-json-serializer-nodejs/compare/v0.1.4...v0.1.5) (2021-10-26) ##### Bug Fixes - JSON accept special string for NaN, Infinity ([#19](https://www.togithub.com/googleapis/proto3-json-serializer-nodejs/issues/19)) ([01a345b](https://www.github.com/googleapis/proto3-json-serializer-nodejs/commit/01a345b7b1d62ee65a8673737975980d274fa22a)) ##### [0.1.4](https://www.github.com/googleapis/proto3-json-serializer-nodejs/compare/v0.1.3...v0.1.4) (2021-09-20) ##### Bug Fixes - do not emit empty lists to JSON ([#15](https://www.togithub.com/googleapis/proto3-json-serializer-nodejs/issues/15)) ([af9dfd6](https://www.github.com/googleapis/proto3-json-serializer-nodejs/commit/af9dfd65efb84cfb31af0faca805f53b0ffa9874)) ##### [0.1.3](https://www.github.com/googleapis/proto3-json-serializer-nodejs/compare/v0.1.2...v0.1.3) (2021-08-18) ##### Bug Fixes - do not fail for unknown enum values ([#11](https://www.togithub.com/googleapis/proto3-json-serializer-nodejs/issues/11)) ([ff9f0f1](https://www.github.com/googleapis/proto3-json-serializer-nodejs/commit/ff9f0f1881b1aafacd693b4e24eaee9e56aff79c)) ##### [0.1.2](https://www.github.com/googleapis/proto3-json-serializer-nodejs/compare/v0.1.1...v0.1.2) (2021-08-17) ##### Bug Fixes - use imported protobufjs in toproto3json.ts ([#9](https://www.togithub.com/googleapis/proto3-json-serializer-nodejs/issues/9)) ([f6c86c7](https://www.github.com/googleapis/proto3-json-serializer-nodejs/commit/f6c86c777d567d8430b09dea3282e52af24d890f)) ##### [0.1.1](https://www.github.com/googleapis/proto3-json-serializer-nodejs/compare/v0.1.0...v0.1.1) (2021-08-04) ##### Bug Fixes - accept and return strings for int64 and uint64 ([#7](https://www.togithub.com/googleapis/proto3-json-serializer-nodejs/issues/7)) ([35689ec](https://www.github.com/googleapis/proto3-json-serializer-nodejs/commit/35689ecee55dbe6e4cf3327c535514d7fcb8332d)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-speech).  * chore(main): release 5.0.1 (#909) * chore(main): release 5.0.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(main): release 5.0.2 (#925) * chore(main): release 5.0.2 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(deps): update dependency uuid to v9 (#926) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [uuid](https://togithub.com/uuidjs/uuid) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/uuid/8.3.2/9.0.0) | [![age](https://badges.renovateapi.com/packages/npm/uuid/9.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/uuid/9.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/uuid/9.0.0/compatibility-slim/8.3.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/uuid/9.0.0/confidence-slim/8.3.2)](https://docs.renovatebot.com/merge-confidence/) | | [uuid](https://togithub.com/uuidjs/uuid) | [`^8.3.2` -> `^9.0.0`](https://renovatebot.com/diffs/npm/uuid/8.3.2/9.0.0) | [![age](https://badges.renovateapi.com/packages/npm/uuid/9.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/uuid/9.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/uuid/9.0.0/compatibility-slim/8.3.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/uuid/9.0.0/confidence-slim/8.3.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>uuidjs/uuid</summary> ### [`v9.0.0`](https://togithub.com/uuidjs/uuid/blob/HEAD/CHANGELOG.md#900-httpsgithubcomuuidjsuuidcomparev832v900-2022-09-05) [Compare Source](https://togithub.com/uuidjs/uuid/compare/v8.3.2...v9.0.0) ##### ⚠ BREAKING CHANGES - Drop Node.js 10.x support. This library always aims at supporting one EOLed LTS release which by this time now is 12.x which has reached EOL 30 Apr 2022. - Remove the minified UMD build from the package. Minified code is hard to audit and since this is a widely used library it seems more appropriate nowadays to optimize for auditability than to ship a legacy module format that, at best, serves educational purposes nowadays. For production browser use cases, users should be using a bundler. For educational purposes, today's online sandboxes like replit.com offer convenient ways to load npm modules, so the use case for UMD through repos like UNPKG or jsDelivr has largely vanished. - Drop IE 11 and Safari 10 support. Drop support for browsers that don't correctly implement const/let and default arguments, and no longer transpile the browser build to ES2015. This also removes the fallback on msCrypto instead of the crypto API. Browser tests are run in the first supported version of each supported browser and in the latest (as of this commit) version available on Browserstack. ##### Features - optimize uuid.v1 by 1.3x uuid.v4 by 4.3x (430%) ([#597](https://togithub.com/uuidjs/uuid/issues/597)) ([3a033f6](https://togithub.com/uuidjs/uuid/commit/3a033f6bab6bb3780ece6d645b902548043280bc)) - remove UMD build ([#645](https://togithub.com/uuidjs/uuid/issues/645)) ([e948a0f](https://togithub.com/uuidjs/uuid/commit/e948a0f22bf22f4619b27bd913885e478e20fe6f)), closes [#620](https://togithub.com/uuidjs/uuid/issues/620) - use native crypto.randomUUID when available ([#600](https://togithub.com/uuidjs/uuid/issues/600)) ([c9e076c](https://togithub.com/uuidjs/uuid/commit/c9e076c852edad7e9a06baaa1d148cf4eda6c6c4)) ##### Bug Fixes - add Jest/jsdom compatibility ([#642]…

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2020

rhodgkins force-pushed the fix-#1133 branch from 2449961 to 2ba1063 Compare March 28, 2020 12:31

rhodgkins changed the title ~~Fix #1133~~ fix: #1133 Mar 28, 2020

rhodgkins changed the title ~~fix: #1133~~ fix(bucket): Only disable resumable uploads for bucket.upload (fixes #1133) Mar 28, 2020

jkwlui requested a review from stephenplusplus March 30, 2020 23:58

stephenplusplus suggested changes Mar 31, 2020

View reviewed changes

src/bucket.ts Show resolved Hide resolved

jkwlui added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 22, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 22, 2020

stephenplusplus approved these changes Apr 23, 2020

View reviewed changes

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Apr 23, 2020

rhodgkins force-pushed the fix-#1133 branch from 9480a29 to 2ba1063 Compare April 23, 2020 19:06

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 23, 2020

rhodgkins force-pushed the fix-#1133 branch from 2ba1063 to 3948e91 Compare April 23, 2020 19:06

rhodgkins added a commit to bookcreator/nodejs-storage that referenced this pull request Apr 29, 2020

Applied patch from @stephenplusplus - see googleapis#1135 (comment)

b43c754

rhodgkins added a commit to bookcreator/nodejs-storage that referenced this pull request Apr 29, 2020

Applied patch from @stephenplusplus - see googleapis#1135 (comment)

90a4faa

rhodgkins force-pushed the fix-#1133 branch from b43c754 to 90a4faa Compare April 29, 2020 09:24

stephenplusplus reviewed Apr 29, 2020

View reviewed changes

test/testdata/dummylargetestfile.txt Outdated Show resolved Hide resolved

rhodgkins added a commit to bookcreator/nodejs-storage that referenced this pull request Apr 30, 2020

text(bucket): Applied patch from @stephenplusplus - see googleapis#11…

472c6b9

…35 (comment)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(bucket): Only disable resumable uploads for bucket.upload (fixes #1133) #1135

fix(bucket): Only disable resumable uploads for bucket.upload (fixes #1133) #1135

rhodgkins commented Mar 28, 2020

JustinBeckwith commented Apr 13, 2020

jkwlui commented Apr 22, 2020

stephenplusplus commented Apr 23, 2020

stephenplusplus commented Apr 23, 2020

googlebot commented Apr 23, 2020

googlebot commented Apr 23, 2020

codecov bot commented Apr 23, 2020 •

edited

rhodgkins commented Apr 23, 2020 •

edited

stephenplusplus commented Apr 27, 2020

rhodgkins commented Apr 29, 2020

fix(bucket): Only disable resumable uploads for bucket.upload (fixes #1133) #1135

fix(bucket): Only disable resumable uploads for bucket.upload (fixes #1133) #1135

Conversation

rhodgkins commented Mar 28, 2020

JustinBeckwith commented Apr 13, 2020

jkwlui commented Apr 22, 2020

stephenplusplus commented Apr 23, 2020

stephenplusplus commented Apr 23, 2020

googlebot commented Apr 23, 2020

googlebot commented Apr 23, 2020

codecov bot commented Apr 23, 2020 • edited

Codecov Report

rhodgkins commented Apr 23, 2020 • edited

stephenplusplus commented Apr 27, 2020

rhodgkins commented Apr 29, 2020

codecov bot commented Apr 23, 2020 •

edited

rhodgkins commented Apr 23, 2020 •

edited