Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: drop keepAcl parameter in file copy #1166

Merged
merged 3 commits into from May 13, 2020
Merged

chore!: drop keepAcl parameter in file copy #1166

merged 3 commits into from May 13, 2020

Conversation

AVaksman
Copy link
Contributor

@AVaksman AVaksman commented Apr 27, 2020 •
edited

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2020
@codecov
Copy link

codecov bot commented Apr 27, 2020 •
edited

Codecov Report

Merging #1166 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1166      +/-   ##
==========================================
- Coverage   99.18%   99.17%   -0.01%     
==========================================
  Files          12       12              
  Lines       11474    11454      -20     
  Branches      597      527      -70     
==========================================
- Hits        11380    11360      -20     
  Misses         94       94
Impacted Files Coverage Δ
src/file.ts 99.94% <ø> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0776a04...dd75d84. Read the comment docs.

@AVaksman AVaksman requested a review from a team as a code owner May 7, 2020 15:53
@stephenplusplus stephenplusplus mentioned this pull request May 13, 2020
Merged
@jkwlui jkwlui merged commit 5a4044a into googleapis:master May 13, 2020
BYK added a commit to getsentry/sentry-javascript that referenced this pull request Jan 4, 2021
@BYK
upgrade(@google-cloud/storage): ^5.7.0
9f01ea5 
This is to upgrade the vulnerable `date-and-time` dependency. The latest version has the following breaking changes which are all okay:

- automatically detect contentType if not provided (googleapis/nodejs-storage#1190)
- drop keepAcl parameter in file copy (googleapis/nodejs-storage#1166)
- drop support for node.js 8.x
- allow leading slashes in file name (googleapis/nodejs-storage#820)
- upgrade engines field to >=8.10.0 (googleapis/nodejs-storage#688)
@BYK BYK mentioned this pull request Jan 4, 2021
Merged
BYK added a commit to getsentry/craft that referenced this pull request Jan 5, 2021
@BYK
upgrade(@google-cloud/storage): ^5.7.0
a0b042f 
This is to upgrade the vulnerable `axios` dependency. The latest version has the following breaking changes which are all okay:

- automatically detect contentType if not provided (googleapis/nodejs-storage#1190)
- drop keepAcl parameter in file copy (googleapis/nodejs-storage#1166)
- drop support for node.js 8.x
- allow leading slashes in file name (googleapis/nodejs-storage#820)
- upgrade engines field to >=8.10.0 (googleapis/nodejs-storage#688)
@BYK BYK mentioned this pull request Jan 5, 2021
Merged
BYK added a commit to getsentry/craft that referenced this pull request Jan 5, 2021
@BYK
upgrade(@google-cloud/storage): ^5.7.0 (#157)
0751ea1 
This is to upgrade the vulnerable `axios` dependency. The latest version has the following breaking changes which are all okay:

- automatically detect contentType if not provided (googleapis/nodejs-storage#1190)
- drop keepAcl parameter in file copy (googleapis/nodejs-storage#1166)
- drop support for node.js 8.x
- allow leading slashes in file name (googleapis/nodejs-storage#820)
- upgrade engines field to >=8.10.0 (googleapis/nodejs-storage#688)
BYK added a commit to getsentry/sentry-javascript that referenced this pull request Jan 11, 2021
@BYK
upgrade(@google-cloud/storage): ^5.7.0 (#3146)
78db3d7 
This is to upgrade the vulnerable `date-and-time` dependency. The latest version has the following breaking changes which are all okay:

- automatically detect contentType if not provided (googleapis/nodejs-storage#1190)
- drop keepAcl parameter in file copy (googleapis/nodejs-storage#1166)
- drop support for node.js 8.x
- allow leading slashes in file name (googleapis/nodejs-storage#820)
- upgrade engines field to >=8.10.0 (googleapis/nodejs-storage#688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenplusplus stephenplusplus stephenplusplus approved these changes

@laljikanjareeya laljikanjareeya laljikanjareeya approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AVaksman @stephenplusplus @laljikanjareeya @jkwlui @googlebot @frankyn