Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v4-policy): encode special characters #1169

Merged
merged 6 commits into from May 1, 2020
Merged

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Apr 28, 2020

JSON.stringify doesn't encode special character to its unicode representation é => \u00e9 as is expected by signed policy.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 28, 2020
@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #1169 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1169   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files          12       12           
  Lines       11440    11453   +13     
  Branches      589      590    +1     
=======================================
+ Hits        11348    11361   +13     
  Misses         92       92           
Impacted Files Coverage Δ
src/file.ts 99.94% <100.00%> (ø)
src/util.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15ba795...8957861. Read the comment docs.

@jkwlui jkwlui merged commit 6e48539 into master May 1, 2020
@jkwlui jkwlui deleted the fix-encode-special-chars branch May 1, 2020 20:19
gcf-owl-bot bot added a commit that referenced this pull request Jul 30, 2021
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Source-Link: googleapis/synthtool@df7fc1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:6245a5be4c0406d9b2f04f380d8b88ffe4655df3cdbb57626f8913e8d620f4dd
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 30, 2021
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Source-Link: googleapis/synthtool@df7fc1e
Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:6245a5be4c0406d9b2f04f380d8b88ffe4655df3cdbb57626f8913e8d620f4dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants