build!: drop support for node.js 8.x

conformance-test/v4SignedUrl.ts

@@ -92,7 +92,7 @@ const testFile = fs.readFileSync(
   'utf-8'
 );
 
-// tslint:disable-next-line no-any
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 const testCases = JSON.parse(testFile);
 const v4SignedUrlCases: V4SignedURLTestCase[] = testCases.signingV4Tests;
 const v4SignedPolicyCases: V4SignedPolicyTestCase[] =

package.json

@@ -5,17 +5,14 @@
   "license": "Apache-2.0",
   "author": "Google Inc.",
   "engines": {
-    "node": ">=8.10.0"
+    "node": ">=10"
   },
   "repository": "googleapis/nodejs-storage",
   "main": "./build/src/index.js",
   "types": "./build/src/index.d.ts",
   "files": [
     "build/src",
-    "!build/src/**/*.map",
-    "AUTHORS",
-    "CONTRIBUTORS",
-    "COPYING"
+    "!build/src/**/*.map"
   ],
   "keywords": [
     "google apis client",
@@ -38,13 +35,13 @@
     "presystem-test": "npm run compile",
     "test": "c8 mocha build/test",
     "pretest": "npm run compile",
-    "lint": "eslint samples/ && gts check",
+    "lint": "gts check",
     "samples-test": "npm link && cd samples/ && npm link ../ && npm test && cd ../",
     "all-test": "npm test && npm run system-test && npm run samples-test",
     "check": "gts check",
     "clean": "gts clean",
     "compile": "tsc -p .",
-    "fix": "gts fix && eslint --fix '**/*.js'",
+    "fix": "gts fix",
     "prepare": "npm run compile",
     "docs-test": "linkinator docs",
     "predocs-test": "npm run docs",
@@ -98,13 +95,9 @@
     "@types/xdg-basedir": "^2.0.0",
     "c8": "^7.0.0",
     "codecov": "^3.0.0",
-    "eslint": "^6.0.0",
-    "eslint-config-prettier": "^6.0.0",
-    "eslint-plugin-node": "^11.0.0",
-    "eslint-plugin-prettier": "^3.0.0",
     "form-data": "^3.0.0",
     "grpc": "^1.22.2",
-    "gts": "^1.0.0",
+    "gts": "^2.0.0",
     "jsdoc": "^3.6.2",
     "jsdoc-fresh": "^1.0.1",
     "jsdoc-region-tag": "^1.0.2",
@@ -113,11 +106,10 @@
     "nock": "~12.0.0",
     "node-fetch": "^2.2.0",
     "normalize-newline": "^3.0.0",
-    "prettier": "^1.7.0",
     "proxyquire": "^2.1.3",
     "sinon": "^9.0.0",
     "tmp": "^0.1.0",
-    "typescript": "3.6.4",
+    "typescript": "^3.8.3",
     "uuid": "^7.0.0",
     "yargs": "^15.0.0"
   }

samples/deleteFile.js

@@ -36,10 +36,7 @@ function main(bucketName = 'my-bucket', filename = 'test.txt') {
 
   async function deleteFile() {
     // Deletes the file from the bucket
-    await storage
-      .bucket(bucketName)
-      .file(filename)
-      .delete();
+    await storage.bucket(bucketName).file(filename).delete();
 
     console.log(`gs://${bucketName}/${filename} deleted.`);
   }

samples/deleteNotification.js

@@ -36,10 +36,7 @@ function main(bucketName = 'my-bucket', notificationId = '1') {
 
   async function deleteNotification() {
     // Deletes the notification from the bucket
-    await storage
-      .bucket(bucketName)
-      .notification(notificationId)
-      .delete();
+    await storage.bucket(bucketName).notification(notificationId).delete();
 
     console.log(`Notification ${notificationId} deleted.`);
   }

samples/disableRequesterPays.js

@@ -29,7 +29,7 @@ function main(bucketName = 'my-bucket') {
   // const bucketName = 'Name of a bucket, e.g. my-bucket';
 
   // Imports the Google Cloud client library
-  const {Storage} = require(`@google-cloud/storage`);
+  const {Storage} = require('@google-cloud/storage');
 
   // Creates a client
   const storage = new Storage();

samples/downloadEncryptedFile.js

@@ -24,8 +24,8 @@ const path = require('path');
 
 function main(
   bucketName = 'my-bucket',
-  srcFilename = path.join(__dirname, `../resources`, 'test.txt'),
-  destFilename = `test.txt`,
+  srcFilename = path.join(__dirname, '../resources', 'test.txt'),
+  destFilename = 'test.txt',
   key = process.env.GOOGLE_CLOUD_KMS_KEY_US
 ) {
   // [START storage_download_encrypted_file]

samples/downloadFile.js

@@ -48,10 +48,7 @@ function main(
     };
 
     // Downloads the file
-    await storage
-      .bucket(bucketName)
-      .file(srcFilename)
-      .download(options);
+    await storage.bucket(bucketName).file(srcFilename).download(options);
 
     console.log(
       `gs://${bucketName}/${srcFilename} downloaded to ${destFilename}.`

samples/downloadFileUsingRequesterPays.js

@@ -40,7 +40,7 @@ function main(
   // const destFilename = 'Local destination of file, e.g. ./local/path/to/file.txt';
 
   // Imports the Google Cloud client library
-  const {Storage} = require(`@google-cloud/storage`);
+  const {Storage} = require('@google-cloud/storage');
 
   // Creates a client
   const storage = new Storage();
@@ -55,10 +55,7 @@ function main(
     };
 
     // Downloads the file
-    await storage
-      .bucket(bucketName)
-      .file(srcFilename)
-      .download(options);
+    await storage.bucket(bucketName).file(srcFilename).download(options);
 
     console.log(
       `gs://${bucketName}/${srcFilename} downloaded to ${destFilename} using requester-pays requests.`

samples/enableRequesterPays.js

@@ -28,7 +28,7 @@ function main(bucketName = 'my-bucket') {
   // const bucketName = 'Name of a bucket, e.g. my-bucket';
 
   // Imports the Google Cloud client library
-  const {Storage} = require(`@google-cloud/storage`);
+  const {Storage} = require('@google-cloud/storage');
 
   // Creates a client
   const storage = new Storage();

samples/getRequesterPaysStatus.js

@@ -28,7 +28,7 @@ function main(bucketName = 'my-bucket') {
   // const bucketName = 'Name of a bucket, e.g. my-bucket';
 
   // Imports the Google Cloud client library
-  const {Storage} = require(`@google-cloud/storage`);
+  const {Storage} = require('@google-cloud/storage');
 
   // Creates a client
   const storage = new Storage();
@@ -39,9 +39,9 @@ function main(bucketName = 'my-bucket') {
 
     let status;
     if (metadata && metadata.billing && metadata.billing.requesterPays) {
-      status = `enabled`;
+      status = 'enabled';
     } else {
-      status = `disabled`;
+      status = 'disabled';
     }
     console.log(
       `Requester-pays requests are ${status} for bucket ${bucketName}.`

samples/hmacKeyActivate.js

@@ -41,8 +41,8 @@ function main(
     const hmacKey = storage.hmacKey(hmacKeyAccessId, {projectId});
     const [hmacKeyMetadata] = await hmacKey.setMetadata({state: 'ACTIVE'});
 
-    console.log(`The HMAC key is now active.`);
-    console.log(`The HMAC key metadata is:`);
+    console.log('The HMAC key is now active.');
+    console.log('The HMAC key metadata is:');
     for (const [key, value] of Object.entries(hmacKeyMetadata)) {
       console.log(`${key}: ${value}`);
     }

samples/hmacKeyCreate.js

@@ -43,8 +43,8 @@ function main(
     });
 
     console.log(`The base64 encoded secret is: ${secret}`);
-    console.log(`Do not miss that secret, there is no API to recover it.`);
-    console.log(`The HMAC key metadata is:`);
+    console.log('Do not miss that secret, there is no API to recover it.');
+    console.log('The HMAC key metadata is:');
     for (const [key, value] of Object.entries(hmacKey.metadata)) {
       console.log(`${key}: ${value}`);
     }

samples/hmacKeyDeactivate.js

@@ -41,8 +41,8 @@ function main(
     const hmacKey = storage.hmacKey(hmacKeyAccessId, {projectId});
     const [hmacKeyMetadata] = await hmacKey.setMetadata({state: 'INACTIVE'});
 
-    console.log(`The HMAC key is now inactive.`);
-    console.log(`The HMAC key metadata is:`);
+    console.log('The HMAC key is now inactive.');
+    console.log('The HMAC key metadata is:');
     for (const [key, value] of Object.entries(hmacKeyMetadata)) {
       console.log(`${key}: ${value}`);
     }

samples/hmacKeyDelete.js

@@ -42,7 +42,7 @@ function main(
     await hmacKey.delete();
 
     console.log(
-      `The key is deleted, though it may still appear in getHmacKeys() results.`
+      'The key is deleted, though it may still appear in getHmacKeys() results.'
     );
   }
   // [END storage_delete_hmac_key]

samples/hmacKeyGet.js

@@ -42,7 +42,7 @@ function main(
     // Populate the hmacKey object with metadata from server.
     await hmacKey.getMetadata();
 
-    console.log(`The HMAC key metadata is:`);
+    console.log('The HMAC key metadata is:');
     for (const [key, value] of Object.entries(hmacKey.metadata)) {
       console.log(`${key}: ${value}`);
     }

samples/makePublic.js

@@ -36,10 +36,7 @@ function main(bucketName = 'my-bucket', filename = 'test.txt') {
 
   async function makePublic() {
     // Makes the file public
-    await storage
-      .bucket(bucketName)
-      .file(filename)
-      .makePublic();
+    await storage.bucket(bucketName).file(filename).makePublic();
 
     console.log(`gs://${bucketName}/${filename} is now public.`);
   }

samples/moveFile.js

@@ -41,10 +41,7 @@ function main(
 
   async function moveFile() {
     // Moves the file within the bucket
-    await storage
-      .bucket(bucketName)
-      .file(srcFilename)
-      .move(destFilename);
+    await storage.bucket(bucketName).file(srcFilename).move(destFilename);
 
     console.log(
       `gs://${bucketName}/${srcFilename} moved to gs://${bucketName}/${destFilename}.`

samples/notifications.js

@@ -113,59 +113,56 @@ async function deleteNotification(bucketName, notificationId) {
   // const notificationId = 'ID of notification to delete, e.g. 1';
 
   // Deletes the notification from the bucket
-  await storage
-    .bucket(bucketName)
-    .notification(notificationId)
-    .delete();
+  await storage.bucket(bucketName).notification(notificationId).delete();
 
   console.log(`Notification ${notificationId} deleted.`);
   // [END storage_delete_notification]
 }
 
-require(`yargs`)
+require('yargs')
   .demand(1)
   .command(
-    `create <bucketName> <topic>`,
-    `Creates a new notification`,
+    'create <bucketName> <topic>',
+    'Creates a new notification',
     {},
     opts => createNotification(opts.bucketName, opts.topic)
   )
   .command(
-    `list <bucketName>`,
-    `Lists notifications for a given bucket.`,
+    'list <bucketName>',
+    'Lists notifications for a given bucket.',
     {},
     opts => listNotifications(opts.bucketName)
   )
   .command(
-    `get-metadata <bucketName> <notificationId>`,
-    `Gets metadata for a notification.`,
+    'get-metadata <bucketName> <notificationId>',
+    'Gets metadata for a notification.',
     {},
     opts => getMetadata(opts.bucketName, opts.notificationId)
   )
   .command(
-    `delete <bucketName> <notificationId>`,
-    `Deletes a notification from a bucket.`,
+    'delete <bucketName> <notificationId>',
+    'Deletes a notification from a bucket.',
     {},
     opts => deleteNotification(opts.bucketName, opts.notificationId)
   )
   .example(
-    `node $0 create my-bucket my-topic`,
-    `Creates a notification subscription.`
+    'node $0 create my-bucket my-topic',
+    'Creates a notification subscription.'
   )
   .example(
-    `node $0 list my-bucket`,
-    `Lists notifications associated with "my-bucket".`
+    'node $0 list my-bucket',
+    'Lists notifications associated with "my-bucket".'
   )
   .example(
-    `node $0 get-metadata my-bucket 1`,
-    `Gets the metadata for notification "1" attached to "my-bucket".`
+    'node $0 get-metadata my-bucket 1',
+    'Gets the metadata for notification "1" attached to "my-bucket".'
   )
   .example(
-    `node $0 delete my-bucket 1`,
-    `Deletes the notification "1" from "my-bucket".`
+    'node $0 delete my-bucket 1',
+    'Deletes the notification "1" from "my-bucket".'
   )
   .wrap(120)
   .recommendCommands()
-  .epilogue(`For more information, see https://cloud.google.com/storage/docs`)
+  .epilogue('For more information, see https://cloud.google.com/storage/docs')
   .strict()
   .help().argv;

samples/printFileAcl.js

@@ -36,10 +36,7 @@ function main(bucketName = 'my-bucket', filename = 'test.txt') {
 
   async function printFileAcl() {
     // Gets the ACL for the file
-    const [acls] = await storage
-      .bucket(bucketName)
-      .file(filename)
-      .acl.get();
+    const [acls] = await storage.bucket(bucketName).file(filename).acl.get();
 
     acls.forEach(acl => {
       console.log(`${acl.role}: ${acl.entity}`);

samples/releaseEventBasedHold.js

@@ -35,12 +35,9 @@ function main(bucketName = 'my-bucket', fileName = 'test.txt') {
   const storage = new Storage();
 
   async function releaseEventBasedHold() {
-    await storage
-      .bucket(bucketName)
-      .file(fileName)
-      .setMetadata({
-        eventBasedHold: false,
-      });
+    await storage.bucket(bucketName).file(fileName).setMetadata({
+      eventBasedHold: false,
+    });
     console.log(`Event-based hold was released for ${fileName}.`);
   }