Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add whitespace to generateV4SignedPolicy #1136

Merged
merged 3 commits into from Mar 30, 2020
Merged

Conversation

frankyn
Copy link
Member

@frankyn frankyn commented Mar 30, 2020

Based on changes requested to -> GoogleCloudPlatform/php-docs-samples#1049

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2020
@frankyn frankyn requested a review from jkwlui March 30, 2020 20:17
@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #1136 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
- Coverage   99.23%   99.10%   -0.14%     
==========================================
  Files          12       12              
  Lines       11428    11428              
  Branches      525      581      +56     
==========================================
- Hits        11341    11326      -15     
- Misses         87      102      +15     
Impacted Files Coverage Δ
src/signer.ts 99.28% <0.00%> (-0.48%) ⬇️
src/bucket.ts 99.38% <0.00%> (-0.20%) ⬇️
src/file.ts 99.78% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d119ace...043b8ec. Read the comment docs.

@jkwlui jkwlui merged commit dcee78b into master Mar 30, 2020
@frankyn frankyn deleted the add-sample-whitespace branch March 30, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants