Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release pubsublite 1.0.0 #3605

Closed
wants to merge 1 commit into from
Closed

chore: release pubsublite 1.0.0 #3605

wants to merge 1 commit into from

Conversation

yoshi-code-bot
Copy link
Contributor

@yoshi-code-bot yoshi-code-bot commented Jan 25, 2021 •
edited

🤖 I have created a release *beep* *boop*

1.0.0 (2021-01-28)

⚠ BREAKING CHANGES

Bug Fixes

  • pubsublite: add separate publisher and subscriber client constructors with settings (api review) (#3528) (98637e0)
  • pubsublite: close clients after publisher and subscriber have terminated (#3512) (72d2aff)
  • pubsublite: rename package ps to pscompat (api review) (#3569) (9d8fd2b)
  • pubsublite: rename TopicPartitions to TopicPartitionCount (#3565) (86a4de7)
  • pubsublite: use strings for resource paths (api review) (#3559) (c18ed25)

This PR was generated with Release Please. See documentation.

@yoshi-code-bot yoshi-code-bot requested a review from a team as a code owner January 25, 2021 15:53
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 25, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 25, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 25, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2021
@codyoss codyoss added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 27, 2021
@codyoss
Copy link
Member

codyoss commented Jan 27, 2021 •
edited

I believe because there where "breaking changes" release-please thinks this should be bumped a major, in this case 1.0.0. I don't think we actually want to do a 1.0.0 yet. cc @tmdiep

@tmdiep
Copy link
Contributor

tmdiep commented Jan 27, 2021

Thanks Cody. We definitely don't want to release 1.0 yet.

I'll copy the release notes over to #3578 (release 0.5.1).

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2021
@codyoss
Copy link
Member

codyoss commented Jan 28, 2021

Updated release please to not bump major pre 1.0. Closing in favor of #3631.

@codyoss codyoss closed this Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
autorelease: closed cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yoshi-code-bot @codyoss @tmdiep @kokoro-team @yoshi-automation