Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsublite)!: rename TopicPartitions to TopicPartitionCount #3565

Merged
merged 3 commits into from Jan 15, 2021
Merged

fix(pubsublite)!: rename TopicPartitions to TopicPartitionCount #3565

merged 3 commits into from Jan 15, 2021

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Jan 14, 2021

For consistency with the Java and Python libraries.

@tmdiep
fix(pubsublite)!: rename TopicPartitions to TopicPartitionCount
982bcc3 
For consistency with the Java and Python libraries.
@tmdiep tmdiep requested a review from a team as a code owner January 14, 2021 23:18
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 14, 2021
@tmdiep
Copy link
Contributor Author

tmdiep commented Jan 15, 2021

Thanks Tyler!

@tmdiep tmdiep merged commit 86a4de7 into googleapis:master Jan 15, 2021
@tmdiep tmdiep deleted the topic_partition_count branch January 15, 2021 00:18
@tmdiep tmdiep added the api: pubsublite Issues related to the Pub/Sub Lite API. label Jan 15, 2021
This was referenced Jan 25, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbpg tbpg tbpg approved these changes

@manuelmenzella-google manuelmenzella-google Awaiting requested review from manuelmenzella-google

Assignees
No one assigned
Labels
api: pubsublite Issues related to the Pub/Sub Lite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmdiep @tbpg