fix(pubsublite): close clients after publisher and subscriber have terminated #3512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gapic clients aren't closed once the
PublisherClient
andSubscriberClient
have terminated. This leaves client connections open. We could add an explicit Close() (like theAdminClient
) and require users to call it, but we know when the publisher and subscriber have permanently terminated (i.e. whenPublisherClient.Stop
is called, and whenSubscriberClient.Receive
returns), so we'll can just close all the gapic clients internally.This caused all unit tests to fail because a single connection to the mock lite server was being reused. The first test would close it, causing all subsequent tests to fail. So the unit test clients were refactored to create new connections for every test.