New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pubsublite)!: add separate publisher and subscriber client constructors with settings (api review) #3528
Conversation
Equivalent to default settings. Updated samples.
Converted this PR to draft as I'm considering adding NewPublisherClient() and NewPublisherClientWithSettings() for consistency with bigtable and spanner. Pending objections via email. |
WANT_LGTM=all After seeing NewClientWithConfig in the spanner and bigtable libraries, I thought it would be better to be consistent. And possibly less confusing without the nil arg. I considered renaming *Settings to *Config, but these are meant to mirror pubsub.PublishSettings and pubsub.ReceiveSettings. |
abaeb0c
to
f460cb8
Compare
We expect most users to just use default publish/receive settings. The NewPublisherClient and NewSubscriberClient constructors will omit the settings arg (using default settings). The additional *WithSettings constructors will allow users to specify settings. This is consistent with NewClient/NewClientWithConfig in the bigtable and spanner libraries.
AI from API review.