Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsublite)!: rename package ps to pscompat (api review) #3569

Merged
merged 2 commits into from Jan 19, 2021
Merged

fix(pubsublite)!: rename package ps to pscompat (api review) #3569

merged 2 commits into from Jan 19, 2021

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Jan 15, 2021

pscompat is more descriptive and indicates that this package is a compatibility API, designed to emulate the Cloud Pub/Sub API.

AI from API review.

@tmdiep tmdiep requested a review from a team as a code owner January 15, 2021 05:23
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2021
@tmdiep tmdiep added the api: pubsublite Issues related to the Pub/Sub Lite API. label Jan 15, 2021
hongalex
hongalex approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@hongalex hongalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending other approvals from API review attendees

codyoss
codyoss approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmdiep tmdiep merged commit 9d8fd2b into googleapis:master Jan 19, 2021
@tmdiep tmdiep deleted the pscompat branch January 19, 2021 21:25
This was referenced Jan 25, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

@hongalex hongalex hongalex approved these changes

@tbpg tbpg tbpg approved these changes

@manuelmenzella-google manuelmenzella-google manuelmenzella-google approved these changes

@dpcollins-google dpcollins-google Awaiting requested review from dpcollins-google

Assignees
No one assigned
Labels
api: pubsublite Issues related to the Pub/Sub Lite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tmdiep @codyoss @hongalex @tbpg @manuelmenzella-google