Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tibanna #1501

Closed
wants to merge 1 commit into from
Closed

Tibanna #1501

wants to merge 1 commit into from

Conversation

SooLee
Copy link
Contributor

@SooLee SooLee commented Mar 19, 2022

Description

This one fixes tibanna disk_mb error.

QC

  • [v ] The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • [v ] The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@github-actions
Copy link
Contributor

Please format your code with black: black snakemake tests/*.py.

@sonarcloud
Copy link

sonarcloud bot commented Mar 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SooLee
Copy link
Contributor Author

SooLee commented Mar 19, 2022

job.resources no longer has default disk_mb.

Base automatically changed from fix/issue860 to main March 21, 2022 14:44
@johanneskoester
Copy link
Contributor

Thanks! This is fixed slightly differently in PR #1491. Btw. in that PR I noticed that the tibanna test case actually never executed remotely (because the tibanna arg was missing). That is fixed as well now, so that I hope to see less breakages in the future.

@SooLee
Copy link
Contributor Author

SooLee commented Mar 21, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants