Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix threads and new IO options in Bowtie2 #1324

Merged
merged 45 commits into from May 3, 2023

Conversation

tdayris
Copy link
Contributor

@tdayris tdayris commented May 2, 2023

Description

Fixes the following issues in the Bowtie2 wrapper:

  • For x threads reserved in the snakemake rule, 2x threads were used. (Once in Bowtie2, once again in the Samtools pipe). This is now fixed. For x threads reserved in the snakemake rule, x-1 is used in Bowtie2, and 1 in through the Samtools pipe.
  • Optional metrics and alignment are now available through output interface.
  • Samtools compressed BAM/CRAM file does now explicitly keep header.
  • Samtool indexing and compression is now documented in meta.yaml and tested.
  • Input file format is now automatically inferred when it is possible.

Open questions:

  • snakemake-wrappers-utils.samtools.get_samtools_opts() tests params.extra parameters. How do I let it test params.extra_samtools ? Then, we could let user set-up extra parameters for samtools view.
  • Bowtie2 can concatenate multiple input files, as long as they are separated by commas. This could be implemented in the wrapper. However, when user inputs exactly two files in input.sample, then I can't find how to guess if they need to be concatenated through -U option, or considered as paired reads through -1 and -2. My solutions always include breaking retro-compatibility.

Both open questions can be ignored and the wrapper would still follow its current behaviour. They are not breaking/blocking.

QC

  • I confirm that:

For all wrappers added by this PR,

  • there is a test case which covers any introduced changes,
  • input: and output: file paths in the resulting rule can be changed arbitrarily,
  • either the wrapper can only use a single core, or the example rule contains a threads: x statement with x being a reasonable default,
  • rule names in the test case are in snake_case and somehow tell what the rule is about or match the tools purpose or name (e.g., map_reads for a step that maps reads),
  • all environment.yaml specifications follow the respective best practices,
  • wherever possible, command line arguments are inferred and set automatically (e.g. based on file extensions in input: or output:),
  • all fields of the example rules in the Snakefiles and their entries are explained via comments (input:/output:/params: etc.),
  • stderr and/or stdout are logged correctly (log:), depending on the wrapped tool,
  • temporary files are either written to a unique hidden folder in the working directory, or (better) stored where the Python function tempfile.gettempdir() points to (see here; this also means that using any Python tempfile default behavior works),
  • the meta.yaml contains a link to the documentation of the respective tool or command,
  • Snakefiles pass the linting (snakemake --lint),
  • Snakefiles are formatted with snakefmt,
  • Python wrapper scripts are formatted with black.
  • Conda environments use a minimal amount of channels, in recommended ordering. E.g. for bioconda, use (conda-forge, bioconda, nodefaults, as conda-forge should have highest priority and defaults channels are usually not needed because most packages are in conda-forge nowadays).

tdayris and others added 30 commits September 21, 2020 09:16
* perf: update bio/bcftools/index/environment.yaml.

* perf: update bio/bcftools/index/environment.yaml.

* perf: update bio/bcftools/index/environment.yaml.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
* Add autobump action

* fix paths

* dbg

* dbg branch

* add checkout

* dbg

* trigger rerun

* entity regex and add label

* dbg

* Update autobump.yml

* Update autobump.yml
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
github-actions bot and others added 15 commits October 13, 2022 14:25
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Automatic update of bio/deepvariant.

Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: Johannes Köster <johannes.koester@uni-due.de>
<!-- Ensure that the PR title follows conventional commit style (<type>:
<description>)-->
<!-- Possible types are here:
https://github.com/commitizen/conventional-commit-types/blob/master/index.json
-->

### Description

<!-- Add a description of your PR here-->

### QC
<!-- Make sure that you can tick the boxes below. -->

* [x] I confirm that:

For all wrappers added by this PR, 

* there is a test case which covers any introduced changes,
* `input:` and `output:` file paths in the resulting rule can be changed
arbitrarily,
* either the wrapper can only use a single core, or the example rule
contains a `threads: x` statement with `x` being a reasonable default,
* rule names in the test case are in
[snake_case](https://en.wikipedia.org/wiki/Snake_case) and somehow tell
what the rule is about or match the tools purpose or name (e.g.,
`map_reads` for a step that maps reads),
* all `environment.yaml` specifications follow [the respective best
practices](https://stackoverflow.com/a/64594513/2352071),
* wherever possible, command line arguments are inferred and set
automatically (e.g. based on file extensions in `input:` or `output:`),
* all fields of the example rules in the `Snakefile`s and their entries
are explained via comments (`input:`/`output:`/`params:` etc.),
* `stderr` and/or `stdout` are logged correctly (`log:`), depending on
the wrapped tool,
* temporary files are either written to a unique hidden folder in the
working directory, or (better) stored where the Python function
`tempfile.gettempdir()` points to (see
[here](https://docs.python.org/3/library/tempfile.html#tempfile.gettempdir);
this also means that using any Python `tempfile` default behavior
works),
* the `meta.yaml` contains a link to the documentation of the respective
tool or command,
* `Snakefile`s pass the linting (`snakemake --lint`),
* `Snakefile`s are formatted with
[snakefmt](https://github.com/snakemake/snakefmt),
* Python wrapper scripts are formatted with
[black](https://black.readthedocs.io).
* Conda environments use a minimal amount of channels, in recommended
ordering. E.g. for bioconda, use (conda-forge, bioconda, nodefaults, as
conda-forge should have highest priority and defaults channels are
usually not needed because most packages are in conda-forge nowadays).
@fgvieira
Copy link
Collaborator

fgvieira commented May 3, 2023

Great work!

As for the open questions, the first I am one not sure, but for the second one we could do something similar to the STAR wrapper (two lists of input files).

I think it can be merged as is, but not sure if you want to wait for more feedback.

@tdayris
Copy link
Contributor Author

tdayris commented May 3, 2023

Thank you for your review. I think it's fair for a merge now. Introducing a second list would break retro-compatibility.

I just noticed that indexing/cram-ing without sorting does not make really sense...

@fgvieira fgvieira merged commit a9c7117 into snakemake:master May 3, 2023
6 checks passed
tgroth97 pushed a commit to tgroth97/snakemake-wrappers that referenced this pull request May 3, 2023
<!-- Ensure that the PR title follows conventional commit style (<type>:
<description>)-->
<!-- Possible types are here:
https://github.com/commitizen/conventional-commit-types/blob/master/index.json
-->

### Description

Fixes the following issues in the Bowtie2 wrapper:

* For `x` threads reserved in the snakemake rule, `2x` threads were
used. (Once in Bowtie2, once again in the Samtools pipe). This is now
fixed. For `x` threads reserved in the snakemake rule, `x-1` is used in
Bowtie2, and 1 in through the Samtools pipe.
* Optional metrics and alignment are now available through `output`
interface.
* Samtools compressed BAM/CRAM file does now explicitly keep header.
* Samtool indexing and compression is now documented in `meta.yaml` and
tested.
* Input file format is now automatically inferred when it is possible.

Open questions:

* `snakemake-wrappers-utils.samtools.get_samtools_opts()` tests
`params.extra` parameters. How do I let it test `params.extra_samtools`
? Then, we could let user set-up extra parameters for samtools view.
* Bowtie2 can concatenate multiple input files, as long as they are
separated by commas. This could be implemented in the wrapper. However,
when user inputs exactly two files in `input.sample`, then I can't find
how to guess if they need to be concatenated through `-U` option, or
considered as paired reads through `-1` and `-2`. My solutions always
include breaking retro-compatibility.

Both open questions can be ignored and the wrapper would still follow
its current behaviour. They are not breaking/blocking.

### QC
<!-- Make sure that you can tick the boxes below. -->

* [X] I confirm that:

For all wrappers added by this PR, 

* there is a test case which covers any introduced changes,
* `input:` and `output:` file paths in the resulting rule can be changed
arbitrarily,
* either the wrapper can only use a single core, or the example rule
contains a `threads: x` statement with `x` being a reasonable default,
* rule names in the test case are in
[snake_case](https://en.wikipedia.org/wiki/Snake_case) and somehow tell
what the rule is about or match the tools purpose or name (e.g.,
`map_reads` for a step that maps reads),
* all `environment.yaml` specifications follow [the respective best
practices](https://stackoverflow.com/a/64594513/2352071),
* wherever possible, command line arguments are inferred and set
automatically (e.g. based on file extensions in `input:` or `output:`),
* all fields of the example rules in the `Snakefile`s and their entries
are explained via comments (`input:`/`output:`/`params:` etc.),
* `stderr` and/or `stdout` are logged correctly (`log:`), depending on
the wrapped tool,
* temporary files are either written to a unique hidden folder in the
working directory, or (better) stored where the Python function
`tempfile.gettempdir()` points to (see
[here](https://docs.python.org/3/library/tempfile.html#tempfile.gettempdir);
this also means that using any Python `tempfile` default behavior
works),
* the `meta.yaml` contains a link to the documentation of the respective
tool or command,
* `Snakefile`s pass the linting (`snakemake --lint`),
* `Snakefile`s are formatted with
[snakefmt](https://github.com/snakemake/snakefmt),
* Python wrapper scripts are formatted with
[black](https://black.readthedocs.io).
* Conda environments use a minimal amount of channels, in recommended
ordering. E.g. for bioconda, use (conda-forge, bioconda, nodefaults, as
conda-forge should have highest priority and defaults channels are
usually not needed because most packages are in conda-forge nowadays).

---------

Co-authored-by: tdayris <tdayris@gustaveroussy.fr>
Co-authored-by: tdayris <thibault.dayris@gustaveroussy.fr>
Co-authored-by: Johannes Köster <johannes.koester@uni-due.de>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: Felix Mölder <felix.moelder@uni-due.de>
Co-authored-by: Christopher Schröder <christopher.schroeder@tu-dortmund.de>
johanneskoester pushed a commit that referenced this pull request May 4, 2023
🤖 I have created a release \*beep\* \*boop\*
---
##
[1.29.0](https://www.github.com/snakemake/snakemake-wrappers/compare/v1.28.0...v1.29.0)
(2023-05-04)


### Features

* Add seqkit subseq
([#1318](https://www.github.com/snakemake/snakemake-wrappers/issues/1318))
([262d9bb](https://www.github.com/snakemake/snakemake-wrappers/commit/262d9bb50cf8d03edca00916bc29fe5f1009209a))
* Deeptools Alignement seive
([#1320](https://www.github.com/snakemake/snakemake-wrappers/issues/1320))
([b7cb7ab](https://www.github.com/snakemake/snakemake-wrappers/commit/b7cb7ab5b70c1eec3b89d02f0bc94a2294e6a9aa))
* fix threads and new IO options in Bowtie2
([#1324](https://www.github.com/snakemake/snakemake-wrappers/issues/1324))
([a9c7117](https://www.github.com/snakemake/snakemake-wrappers/commit/a9c711718533f18429db50fb052549c49aa6fcf7))
* gatk CallCopyRatioSegments
([#1323](https://www.github.com/snakemake/snakemake-wrappers/issues/1323))
([528c91a](https://www.github.com/snakemake/snakemake-wrappers/commit/528c91a5b87ffe0d34964b01478a9b5d520ed80f))
* gatk collectalleliccount wrapper
([#1316](https://www.github.com/snakemake/snakemake-wrappers/issues/1316))
([158c328](https://www.github.com/snakemake/snakemake-wrappers/commit/158c328d1b846fb45c90c946edbcf2a7a0da15de))
* gatk collectreadcount wrapper
([#1315](https://www.github.com/snakemake/snakemake-wrappers/issues/1315))
([ee55de4](https://www.github.com/snakemake/snakemake-wrappers/commit/ee55de4cc2a850775ef94d5394f9a220844d8a7b))
* gatk DenoisedReadCounts wrapper
([#1319](https://www.github.com/snakemake/snakemake-wrappers/issues/1319))
([0288ace](https://www.github.com/snakemake/snakemake-wrappers/commit/0288ace7e61fbf2adf79514eefa2ff8f3566041e))
* gatk modelsegments wrapper
([#1321](https://www.github.com/snakemake/snakemake-wrappers/issues/1321))
([dfecc26](https://www.github.com/snakemake/snakemake-wrappers/commit/dfecc26de3c649c4661ac26203d846a54f7dd0b0))
* Pyroe make-spliced+unspliced
([#1290](https://www.github.com/snakemake/snakemake-wrappers/issues/1290))
([96a2cbb](https://www.github.com/snakemake/snakemake-wrappers/commit/96a2cbbf667fb45676087c2002fa875a76982e6b))


### Bug Fixes

* Lofreq indelqual
([#1325](https://www.github.com/snakemake/snakemake-wrappers/issues/1325))
([dabecf0](https://www.github.com/snakemake/snakemake-wrappers/commit/dabecf065975b7e53102221a63ec11b2c812cdee))


### Performance Improvements

* Updated version of datavzrd to 2.19.1
([#1328](https://www.github.com/snakemake/snakemake-wrappers/issues/1328))
([fd89645](https://www.github.com/snakemake/snakemake-wrappers/commit/fd89645aa28773f872a3b2f54192d66129852d83))
---


This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
tdayris added a commit to tdayris/snakemake-wrappers that referenced this pull request May 11, 2023
<!-- Ensure that the PR title follows conventional commit style (<type>:
<description>)-->
<!-- Possible types are here:
https://github.com/commitizen/conventional-commit-types/blob/master/index.json
-->

### Description

Fixes the following issues in the Bowtie2 wrapper:

* For `x` threads reserved in the snakemake rule, `2x` threads were
used. (Once in Bowtie2, once again in the Samtools pipe). This is now
fixed. For `x` threads reserved in the snakemake rule, `x-1` is used in
Bowtie2, and 1 in through the Samtools pipe.
* Optional metrics and alignment are now available through `output`
interface.
* Samtools compressed BAM/CRAM file does now explicitly keep header.
* Samtool indexing and compression is now documented in `meta.yaml` and
tested.
* Input file format is now automatically inferred when it is possible.

Open questions:

* `snakemake-wrappers-utils.samtools.get_samtools_opts()` tests
`params.extra` parameters. How do I let it test `params.extra_samtools`
? Then, we could let user set-up extra parameters for samtools view.
* Bowtie2 can concatenate multiple input files, as long as they are
separated by commas. This could be implemented in the wrapper. However,
when user inputs exactly two files in `input.sample`, then I can't find
how to guess if they need to be concatenated through `-U` option, or
considered as paired reads through `-1` and `-2`. My solutions always
include breaking retro-compatibility.

Both open questions can be ignored and the wrapper would still follow
its current behaviour. They are not breaking/blocking.

### QC
<!-- Make sure that you can tick the boxes below. -->

* [X] I confirm that:

For all wrappers added by this PR, 

* there is a test case which covers any introduced changes,
* `input:` and `output:` file paths in the resulting rule can be changed
arbitrarily,
* either the wrapper can only use a single core, or the example rule
contains a `threads: x` statement with `x` being a reasonable default,
* rule names in the test case are in
[snake_case](https://en.wikipedia.org/wiki/Snake_case) and somehow tell
what the rule is about or match the tools purpose or name (e.g.,
`map_reads` for a step that maps reads),
* all `environment.yaml` specifications follow [the respective best
practices](https://stackoverflow.com/a/64594513/2352071),
* wherever possible, command line arguments are inferred and set
automatically (e.g. based on file extensions in `input:` or `output:`),
* all fields of the example rules in the `Snakefile`s and their entries
are explained via comments (`input:`/`output:`/`params:` etc.),
* `stderr` and/or `stdout` are logged correctly (`log:`), depending on
the wrapped tool,
* temporary files are either written to a unique hidden folder in the
working directory, or (better) stored where the Python function
`tempfile.gettempdir()` points to (see
[here](https://docs.python.org/3/library/tempfile.html#tempfile.gettempdir);
this also means that using any Python `tempfile` default behavior
works),
* the `meta.yaml` contains a link to the documentation of the respective
tool or command,
* `Snakefile`s pass the linting (`snakemake --lint`),
* `Snakefile`s are formatted with
[snakefmt](https://github.com/snakemake/snakefmt),
* Python wrapper scripts are formatted with
[black](https://black.readthedocs.io).
* Conda environments use a minimal amount of channels, in recommended
ordering. E.g. for bioconda, use (conda-forge, bioconda, nodefaults, as
conda-forge should have highest priority and defaults channels are
usually not needed because most packages are in conda-forge nowadays).

---------

Co-authored-by: tdayris <tdayris@gustaveroussy.fr>
Co-authored-by: tdayris <thibault.dayris@gustaveroussy.fr>
Co-authored-by: Johannes Köster <johannes.koester@uni-due.de>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: Felix Mölder <felix.moelder@uni-due.de>
Co-authored-by: Christopher Schröder <christopher.schroeder@tu-dortmund.de>
tdayris pushed a commit to tdayris/snakemake-wrappers that referenced this pull request May 11, 2023
🤖 I have created a release \*beep\* \*boop\*
---
##
[1.29.0](https://www.github.com/snakemake/snakemake-wrappers/compare/v1.28.0...v1.29.0)
(2023-05-04)


### Features

* Add seqkit subseq
([snakemake#1318](https://www.github.com/snakemake/snakemake-wrappers/issues/1318))
([262d9bb](https://www.github.com/snakemake/snakemake-wrappers/commit/262d9bb50cf8d03edca00916bc29fe5f1009209a))
* Deeptools Alignement seive
([snakemake#1320](https://www.github.com/snakemake/snakemake-wrappers/issues/1320))
([b7cb7ab](https://www.github.com/snakemake/snakemake-wrappers/commit/b7cb7ab5b70c1eec3b89d02f0bc94a2294e6a9aa))
* fix threads and new IO options in Bowtie2
([snakemake#1324](https://www.github.com/snakemake/snakemake-wrappers/issues/1324))
([a9c7117](https://www.github.com/snakemake/snakemake-wrappers/commit/a9c711718533f18429db50fb052549c49aa6fcf7))
* gatk CallCopyRatioSegments
([snakemake#1323](https://www.github.com/snakemake/snakemake-wrappers/issues/1323))
([528c91a](https://www.github.com/snakemake/snakemake-wrappers/commit/528c91a5b87ffe0d34964b01478a9b5d520ed80f))
* gatk collectalleliccount wrapper
([snakemake#1316](https://www.github.com/snakemake/snakemake-wrappers/issues/1316))
([158c328](https://www.github.com/snakemake/snakemake-wrappers/commit/158c328d1b846fb45c90c946edbcf2a7a0da15de))
* gatk collectreadcount wrapper
([snakemake#1315](https://www.github.com/snakemake/snakemake-wrappers/issues/1315))
([ee55de4](https://www.github.com/snakemake/snakemake-wrappers/commit/ee55de4cc2a850775ef94d5394f9a220844d8a7b))
* gatk DenoisedReadCounts wrapper
([snakemake#1319](https://www.github.com/snakemake/snakemake-wrappers/issues/1319))
([0288ace](https://www.github.com/snakemake/snakemake-wrappers/commit/0288ace7e61fbf2adf79514eefa2ff8f3566041e))
* gatk modelsegments wrapper
([snakemake#1321](https://www.github.com/snakemake/snakemake-wrappers/issues/1321))
([dfecc26](https://www.github.com/snakemake/snakemake-wrappers/commit/dfecc26de3c649c4661ac26203d846a54f7dd0b0))
* Pyroe make-spliced+unspliced
([snakemake#1290](https://www.github.com/snakemake/snakemake-wrappers/issues/1290))
([96a2cbb](https://www.github.com/snakemake/snakemake-wrappers/commit/96a2cbbf667fb45676087c2002fa875a76982e6b))


### Bug Fixes

* Lofreq indelqual
([snakemake#1325](https://www.github.com/snakemake/snakemake-wrappers/issues/1325))
([dabecf0](https://www.github.com/snakemake/snakemake-wrappers/commit/dabecf065975b7e53102221a63ec11b2c812cdee))


### Performance Improvements

* Updated version of datavzrd to 2.19.1
([snakemake#1328](https://www.github.com/snakemake/snakemake-wrappers/issues/1328))
([fd89645](https://www.github.com/snakemake/snakemake-wrappers/commit/fd89645aa28773f872a3b2f54192d66129852d83))
---


This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
tdayris added a commit to tdayris/snakemake-wrappers that referenced this pull request Jul 5, 2023
<!-- Ensure that the PR title follows conventional commit style (<type>:
<description>)-->
<!-- Possible types are here:
https://github.com/commitizen/conventional-commit-types/blob/master/index.json
-->

### Description

Fixes the following issues in the Bowtie2 wrapper:

* For `x` threads reserved in the snakemake rule, `2x` threads were
used. (Once in Bowtie2, once again in the Samtools pipe). This is now
fixed. For `x` threads reserved in the snakemake rule, `x-1` is used in
Bowtie2, and 1 in through the Samtools pipe.
* Optional metrics and alignment are now available through `output`
interface.
* Samtools compressed BAM/CRAM file does now explicitly keep header.
* Samtool indexing and compression is now documented in `meta.yaml` and
tested.
* Input file format is now automatically inferred when it is possible.

Open questions:

* `snakemake-wrappers-utils.samtools.get_samtools_opts()` tests
`params.extra` parameters. How do I let it test `params.extra_samtools`
? Then, we could let user set-up extra parameters for samtools view.
* Bowtie2 can concatenate multiple input files, as long as they are
separated by commas. This could be implemented in the wrapper. However,
when user inputs exactly two files in `input.sample`, then I can't find
how to guess if they need to be concatenated through `-U` option, or
considered as paired reads through `-1` and `-2`. My solutions always
include breaking retro-compatibility.

Both open questions can be ignored and the wrapper would still follow
its current behaviour. They are not breaking/blocking.

### QC
<!-- Make sure that you can tick the boxes below. -->

* [X] I confirm that:

For all wrappers added by this PR, 

* there is a test case which covers any introduced changes,
* `input:` and `output:` file paths in the resulting rule can be changed
arbitrarily,
* either the wrapper can only use a single core, or the example rule
contains a `threads: x` statement with `x` being a reasonable default,
* rule names in the test case are in
[snake_case](https://en.wikipedia.org/wiki/Snake_case) and somehow tell
what the rule is about or match the tools purpose or name (e.g.,
`map_reads` for a step that maps reads),
* all `environment.yaml` specifications follow [the respective best
practices](https://stackoverflow.com/a/64594513/2352071),
* wherever possible, command line arguments are inferred and set
automatically (e.g. based on file extensions in `input:` or `output:`),
* all fields of the example rules in the `Snakefile`s and their entries
are explained via comments (`input:`/`output:`/`params:` etc.),
* `stderr` and/or `stdout` are logged correctly (`log:`), depending on
the wrapped tool,
* temporary files are either written to a unique hidden folder in the
working directory, or (better) stored where the Python function
`tempfile.gettempdir()` points to (see
[here](https://docs.python.org/3/library/tempfile.html#tempfile.gettempdir);
this also means that using any Python `tempfile` default behavior
works),
* the `meta.yaml` contains a link to the documentation of the respective
tool or command,
* `Snakefile`s pass the linting (`snakemake --lint`),
* `Snakefile`s are formatted with
[snakefmt](https://github.com/snakemake/snakefmt),
* Python wrapper scripts are formatted with
[black](https://black.readthedocs.io).
* Conda environments use a minimal amount of channels, in recommended
ordering. E.g. for bioconda, use (conda-forge, bioconda, nodefaults, as
conda-forge should have highest priority and defaults channels are
usually not needed because most packages are in conda-forge nowadays).

---------

Co-authored-by: tdayris <tdayris@gustaveroussy.fr>
Co-authored-by: tdayris <thibault.dayris@gustaveroussy.fr>
Co-authored-by: Johannes Köster <johannes.koester@uni-due.de>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: Felix Mölder <felix.moelder@uni-due.de>
Co-authored-by: Christopher Schröder <christopher.schroeder@tu-dortmund.de>
tdayris pushed a commit to tdayris/snakemake-wrappers that referenced this pull request Jul 5, 2023
🤖 I have created a release \*beep\* \*boop\*
---
##
[1.29.0](https://www.github.com/snakemake/snakemake-wrappers/compare/v1.28.0...v1.29.0)
(2023-05-04)


### Features

* Add seqkit subseq
([snakemake#1318](https://www.github.com/snakemake/snakemake-wrappers/issues/1318))
([262d9bb](https://www.github.com/snakemake/snakemake-wrappers/commit/262d9bb50cf8d03edca00916bc29fe5f1009209a))
* Deeptools Alignement seive
([snakemake#1320](https://www.github.com/snakemake/snakemake-wrappers/issues/1320))
([b7cb7ab](https://www.github.com/snakemake/snakemake-wrappers/commit/b7cb7ab5b70c1eec3b89d02f0bc94a2294e6a9aa))
* fix threads and new IO options in Bowtie2
([snakemake#1324](https://www.github.com/snakemake/snakemake-wrappers/issues/1324))
([a9c7117](https://www.github.com/snakemake/snakemake-wrappers/commit/a9c711718533f18429db50fb052549c49aa6fcf7))
* gatk CallCopyRatioSegments
([snakemake#1323](https://www.github.com/snakemake/snakemake-wrappers/issues/1323))
([528c91a](https://www.github.com/snakemake/snakemake-wrappers/commit/528c91a5b87ffe0d34964b01478a9b5d520ed80f))
* gatk collectalleliccount wrapper
([snakemake#1316](https://www.github.com/snakemake/snakemake-wrappers/issues/1316))
([158c328](https://www.github.com/snakemake/snakemake-wrappers/commit/158c328d1b846fb45c90c946edbcf2a7a0da15de))
* gatk collectreadcount wrapper
([snakemake#1315](https://www.github.com/snakemake/snakemake-wrappers/issues/1315))
([ee55de4](https://www.github.com/snakemake/snakemake-wrappers/commit/ee55de4cc2a850775ef94d5394f9a220844d8a7b))
* gatk DenoisedReadCounts wrapper
([snakemake#1319](https://www.github.com/snakemake/snakemake-wrappers/issues/1319))
([0288ace](https://www.github.com/snakemake/snakemake-wrappers/commit/0288ace7e61fbf2adf79514eefa2ff8f3566041e))
* gatk modelsegments wrapper
([snakemake#1321](https://www.github.com/snakemake/snakemake-wrappers/issues/1321))
([dfecc26](https://www.github.com/snakemake/snakemake-wrappers/commit/dfecc26de3c649c4661ac26203d846a54f7dd0b0))
* Pyroe make-spliced+unspliced
([snakemake#1290](https://www.github.com/snakemake/snakemake-wrappers/issues/1290))
([96a2cbb](https://www.github.com/snakemake/snakemake-wrappers/commit/96a2cbbf667fb45676087c2002fa875a76982e6b))


### Bug Fixes

* Lofreq indelqual
([snakemake#1325](https://www.github.com/snakemake/snakemake-wrappers/issues/1325))
([dabecf0](https://www.github.com/snakemake/snakemake-wrappers/commit/dabecf065975b7e53102221a63ec11b2c812cdee))


### Performance Improvements

* Updated version of datavzrd to 2.19.1
([snakemake#1328](https://www.github.com/snakemake/snakemake-wrappers/issues/1328))
([fd89645](https://www.github.com/snakemake/snakemake-wrappers/commit/fd89645aa28773f872a3b2f54192d66129852d83))
---


This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants