New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use new java memory overhead utils #1150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….2` with java memory overhead functionality: snakemake/snakemake-wrapper-utils#24
…including some extra overhead
… is more cluster-friendly)
…cluster-friendly specification
When merged, this finally closes snakemake/snakemake-wrapper-utils#9. |
…ted minimum of 471859200 plus 20% overhead
This will close snakemake/snakemake-wrapper-utils#9, which I kept open for tracking. |
johanneskoester
approved these changes
Mar 23, 2023
Awesome work! |
johanneskoester
pushed a commit
that referenced
this pull request
Mar 23, 2023
🤖 I have created a release \*beep\* \*boop\* --- ## [1.25.0](https://www.github.com/snakemake/snakemake-wrappers/compare/v1.24.0...v1.25.0) (2023-03-23) ### Features * added several Seqkit wrappers ([#1128](https://www.github.com/snakemake/snakemake-wrappers/issues/1128)) ([9c4e667](https://www.github.com/snakemake/snakemake-wrappers/commit/9c4e66705de7f0db6c4cedae8b06359bacc9169a)) * added wrapper for loglog ([#1154](https://www.github.com/snakemake/snakemake-wrappers/issues/1154)) ([08917f9](https://www.github.com/snakemake/snakemake-wrappers/commit/08917f991e60b19cac03b9b9cec82fdaf10891b9)) * added wrapper for tadpole ([#1152](https://www.github.com/snakemake/snakemake-wrappers/issues/1152)) ([cb1372b](https://www.github.com/snakemake/snakemake-wrappers/commit/cb1372ba61ea3f92050b974e0dfa61e42b496806)) * Merqury ([#540](https://www.github.com/snakemake/snakemake-wrappers/issues/540)) ([f7914c4](https://www.github.com/snakemake/snakemake-wrappers/commit/f7914c4025fcbcea124765732b4241cfe233f379)) * Mutect2 additional parameters ([#516](https://www.github.com/snakemake/snakemake-wrappers/issues/516)) ([f2b70ca](https://www.github.com/snakemake/snakemake-wrappers/commit/f2b70ca7371d2bb7c031930d047d1e18f9f0610f)) ### Bug Fixes * use new java memory overhead utils ([#1150](https://www.github.com/snakemake/snakemake-wrappers/issues/1150)) ([d15d5f5](https://www.github.com/snakemake/snakemake-wrappers/commit/d15d5f5dda23a60aa6c570c9b5da4d5a855cadf5)) ### Performance Improvements * autobump bio/bcftools/filter ([#646](https://www.github.com/snakemake/snakemake-wrappers/issues/646)) ([b7b98fd](https://www.github.com/snakemake/snakemake-wrappers/commit/b7b98fd9cd9ae819e116aa81c6d082585a77b41d)) * autobump bio/bismark/deduplicate_bismark ([#1141](https://www.github.com/snakemake/snakemake-wrappers/issues/1141)) ([45cd1a6](https://www.github.com/snakemake/snakemake-wrappers/commit/45cd1a635a00d48dbbfbf591059364e0d6d09864)) * autobump bio/cooltools/dots ([#702](https://www.github.com/snakemake/snakemake-wrappers/issues/702)) ([7ac6569](https://www.github.com/snakemake/snakemake-wrappers/commit/7ac656961dff08341e3d448932dda37c19f7d65d)) * autobump bio/fgbio/collectduplexseqmetrics ([#1100](https://www.github.com/snakemake/snakemake-wrappers/issues/1100)) ([ae2a295](https://www.github.com/snakemake/snakemake-wrappers/commit/ae2a295303b987e9e1fb303a689bec6d0cbb4aa1)) * autobump bio/gatk/markduplicatesspark ([#1142](https://www.github.com/snakemake/snakemake-wrappers/issues/1142)) ([190dd18](https://www.github.com/snakemake/snakemake-wrappers/commit/190dd18d6a29cdb1fefdfe98f7d25a5d9c4d00d1)) * autobump bio/gridss/preprocess ([#800](https://www.github.com/snakemake/snakemake-wrappers/issues/800)) ([71463ad](https://www.github.com/snakemake/snakemake-wrappers/commit/71463adf79b2a12f3360e1f80f8452f3803c9315)) * autobump bio/gridss/setupreference ([#848](https://www.github.com/snakemake/snakemake-wrappers/issues/848)) ([c2f9766](https://www.github.com/snakemake/snakemake-wrappers/commit/c2f976626319fde811e4a4043f9307f7fb7e6758)) * autobump bio/hisat2/align ([#1079](https://www.github.com/snakemake/snakemake-wrappers/issues/1079)) ([dea181a](https://www.github.com/snakemake/snakemake-wrappers/commit/dea181a03196c4a6f8612651478ee07bbee16467)) * autobump bio/liftoff ([#953](https://www.github.com/snakemake/snakemake-wrappers/issues/953)) ([0928808](https://www.github.com/snakemake/snakemake-wrappers/commit/0928808b812b2f4c24c3b747e4eee42cab534453)) * autobump bio/lofreq/call ([#1120](https://www.github.com/snakemake/snakemake-wrappers/issues/1120)) ([a327d86](https://www.github.com/snakemake/snakemake-wrappers/commit/a327d860f3db5154007e3c527b584c5eadc9050f)) * autobump bio/muscle ([#612](https://www.github.com/snakemake/snakemake-wrappers/issues/612)) ([659d106](https://www.github.com/snakemake/snakemake-wrappers/commit/659d10646b41c01b009a55b1f15503a7965bce6a)) * autobump bio/snpeff/annotate ([#1038](https://www.github.com/snakemake/snakemake-wrappers/issues/1038)) ([5628ccd](https://www.github.com/snakemake/snakemake-wrappers/commit/5628ccdc4156f17ffa1b2a84bb255e81036b86ea)) * autobump bio/subread/featurecounts ([#1044](https://www.github.com/snakemake/snakemake-wrappers/issues/1044)) ([b7d7ed4](https://www.github.com/snakemake/snakemake-wrappers/commit/b7d7ed4d6b7c58a774a8dd9c04d8a5880d3fc991)) * autobump bio/trinity ([#634](https://www.github.com/snakemake/snakemake-wrappers/issues/634)) ([d084304](https://www.github.com/snakemake/snakemake-wrappers/commit/d084304a9afff1c460465d4db6bfa4898fa26e8e)) * autobump bio/vep/cache ([#1132](https://www.github.com/snakemake/snakemake-wrappers/issues/1132)) ([d8c3faa](https://www.github.com/snakemake/snakemake-wrappers/commit/d8c3faac3f30b001534d104bf26f916c04787d71)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates all uses of
snakemake-wrapper-utils
to the latest version0.5.2
. Mostly, to automatically have all the wrappers that use theget_java_opts()
function reserve 20% of the reserved memory for overhead of the JVM. In some cases, I have increased that default, where the documentation indicated that the overhead is usually larger. And in some cases, I switched the specification in the example Snakefile frommem_gb
to the canonicalmem_mb
, which is sure to be interpreted correctly for job submissions on cluster systems.QC
For all wrappers added by this PR,
input:
andoutput:
file paths in the resulting rule can be changed arbitrarily,threads: x
statement withx
being a reasonable default,map_reads
for a step that maps reads),environment.yaml
specifications follow the respective best practices,input:
oroutput:
),Snakefile
s and their entries are explained via comments (input:
/output:
/params:
etc.),stderr
and/orstdout
are logged correctly (log:
), depending on the wrapped tool,tempfile.gettempdir()
points to (see here; this also means that using any Pythontempfile
default behavior works),meta.yaml
contains a link to the documentation of the respective tool or command,Snakefile
s pass the linting (snakemake --lint
),Snakefile
s are formatted with snakefmt,