Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting fail on nfcore_external_java_deps if nf_schema is used #2976

Merged
merged 6 commits into from May 13, 2024

Conversation

itrujnara
Copy link

Fixed a bug where linting failed in pipelines using nf_schema instead of nf_validation.
Conditional file linting now accepts a list of parameters instead of a single one. The parameters are or-gated, i.e. a single one is sufficient to mark the parameter as present (and thus expect the file to not exist).
Please verify test coverage, as I am not familiar with the coding practices in tools.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.19%. Comparing base (1ae28bc) to head (c3e2844).

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thanks!

@mashehu
Copy link
Contributor

mashehu commented May 10, 2024

@nf-core-bot changelog

@itrujnara itrujnara merged commit a157cb1 into nf-core:dev May 13, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants