New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: introduce abstractions at the workspace level #3836
Draft
jamesgeorge007
wants to merge
29
commits into
release/2024.3.0
Choose a base branch
from
refactor/workspaces
base: release/2024.3.0
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Bastin <andrewbastin.k@gmail.com>
Introduce a handle for requests.
…rom personal provider definition
Bump vue version.
…the new implementation
… the request level straightaway
jamesgeorge007
force-pushed
the
refactor/workspaces
branch
from
February 16, 2024 07:39
175b73d
to
43ce9d2
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces abstractions at the workspace level and ports the existing implementation to the new architecture. This will be done in phases, and the changes will be merged into the head branch. On a high level, business logic specific to each workspace is being moved from component sources to the respective provider definitions. The newly revamped workspace service acts as an interface for other parts of the codebase to access methods implemented by the various workspace providers. There is a given set of API methods that each provider (
personal
,teams
,file-based
) will implement, starting withpersonal
initially.Handles - Reference to an entity, say workspace, collection, requests, etc. It also holds the necessary information about the resource being pointed to. It can be invalidated at any point. Hence, it's a
ref
to a resource that, in turn, can hold reactive data (A handle itself can be invalidated and needs to be aware of changes happening to the inner members).Views - Compiles information about the underlying representation used to render the UI.
Todos
New
prefixes from the newly added components once replacing all instances with newly added components and removing the old ones.emitWithFullCollection
prop from theCollectionsProperties
component after porting all usages.workspace-user-collection
withuser-collection
for the typeHoppRESTSaveContext
underhoppscotch-common/src/helpers/rest/document
.requestHandle
under the tabsaveContext
and remove the IDs (requestID
,workspaceID
, etc) at runtime.collectionID
fromrequestHandle
since it can be obtained fromrequestID
.Checks