Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql): Environments #3723

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Timeraa
Copy link
Contributor

@Timeraa Timeraa commented Jan 6, 2024

Closes #2172

Description

This PR adds the environments that are present in the REST tab to the GraphQL tab.

  • Add necessary UI elements
  • Parse Header variables
  • Parse Graphql variables
  • Parse Authorization variables
  • Parse Endpoint variables
  • Add tests to check if functionality works (Are there tests for UI?)

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

image
image
image

@Timeraa Timeraa marked this pull request as ready for review January 6, 2024 03:01
@human37
Copy link

human37 commented Apr 3, 2024

@AndrewBastin @amk-dev @anwarulislam bump for this PR, this is the only thing stopping me from using this full time 🙏

@Timeraa
Copy link
Contributor Author

Timeraa commented Apr 3, 2024

@AndrewBastin @amk-dev @anwarulislam bump for this PR, this is the only thing stopping me from using this full time 🙏

I feel like they kinda gave up on merging this... it's a shame all tools are turning into garbage with GraphQL support, insomnia was great and now it's such a buggy mess and hopscotch shows potential but lacks such a crucial feature imo

@sawa-ko
Copy link
Contributor

sawa-ko commented Apr 4, 2024

Please merge this. 🙏

@AndrewBastin
Copy link
Member

@Timeraa @sawa-ko @human37

Hi there!

We do want to merge this PR in, but we have a bit of tech debt in terms of how workspaces work in Hoppscotch and the code hasn't evolved with how the app has evolved over time (most of the collections logic even predates GraphQL and teams and hasn't had major changes since 2021!) and we have been constantly firefighting weird bugs around this (the 2023.12 release had 6 point releases just to squash certain bugs around this). Hence, we are reworking internally how workspaces work.

You can track the progress of the reworking effort here: #3836
Since this change is a bit of a major change that will rework how Collections, Environments, Workspaces and how their interactions work, we are holding off on any merges into this system unless there is a huge demand for this feature. We are hoping to get this PR done by the end of the month, after which we should be able to smoothly bring in support for GraphQL environments and much more.

Really sorry about the delay on our end and the silence around this PR for a while (we are working on resolving this), we are working on making these faster and the refactors are the only way to ensure we will be able to provide a relatively bug free and stable Hoppscotch experience for all. 🙇

@JoelJacobStephen JoelJacobStephen added the future Scheduled to near future label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future Scheduled to near future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: GraphQL environment variables support and should be shared with REST
5 participants