Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduce abstractions at the workspace level #3836

Draft
wants to merge 87 commits into
base: next
Choose a base branch
from

Commits on May 22, 2024

  1. refactor: initial iterations

    Co-authored-by: Andrew Bastin <andrewbastin.k@gmail.com>
    jamesgeorge007 and AndrewBastin committed May 22, 2024
    Configuration menu
    Copy the full SHA
    29e25b0 View commit details
    Browse the repository at this point in the history
  2. refactor: iterations

    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ab7df21 View commit details
    Browse the repository at this point in the history
  3. refactor: compile data in handles

    Introduce a handle for requests.
    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    89bcc58 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d6a8e60 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f0dab55 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f0f504d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1abbdb0 View commit details
    Browse the repository at this point in the history
  8. refactor: save request handle in tabs and remove tabs related logic f…

    …rom personal provider definition
    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    c1a8a87 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    392b2fc View commit details
    Browse the repository at this point in the history
  10. refactor: persist request handle under tab saveContext

    Bump vue version.
    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    a0e373a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2c47a63 View commit details
    Browse the repository at this point in the history
  12. chore: cleanup

    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    97899ec View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    30b6a67 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    63eca80 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    b0c72fd View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    68795a5 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    7549e45 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    3a176f6 View commit details
    Browse the repository at this point in the history
  19. fix: updates to collection level authorization and headers reflect at…

    … the request level straightaway
    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    faa0bf7 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    b821f45 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    00285df View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    0d00826 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    89f7c2c View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    316dc8f View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    c43e4fc View commit details
    Browse the repository at this point in the history
  26. refactor: remove unnecessary imports and local state variable

    James George authored and jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f4ea999 View commit details
    Browse the repository at this point in the history
  27. refactor: remove fields associated with pagination

    Fix lint errors
    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    cd23bb6 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    8483339 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    6ed9c09 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    076006c View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    d0c7c4a View commit details
    Browse the repository at this point in the history
  32. refactor: unify markup

    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    0a0f441 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    fe01322 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    7c52c6b View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    af7e6b7 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    4665485 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    89f2479 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    5a64cdb View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    c30ee5b View commit details
    Browse the repository at this point in the history
  40. refactor: eliminate collectionID from tab saveContext

    Collection ID can be inferred from request ID by removing last index from the path.
    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    d70d5bd View commit details
    Browse the repository at this point in the history
  41. refactor: eliminate parentCollectionID field from `RESTCollectionVi…

    …ewRequest` type
    
    Collection ID serves the purpose.
    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    c0978c3 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    84fc31e View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    5b3986a View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    240b131 View commit details
    Browse the repository at this point in the history
  45. fix: duplicate collection in search results

    Ensure the entire collection tree is rendered if the search query matches a collection name.
    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    7e2deaa View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    116f2fd View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    f87a4c8 View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    62612e6 View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    a729dfc View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    b19486e View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    01573cc View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    3fd85df View commit details
    Browse the repository at this point in the history
  53. Configuration menu
    Copy the full SHA
    f6067f1 View commit details
    Browse the repository at this point in the history
  54. refactor: persist request handles under tab saveContext

    Only the IDs (workspace, provider & request IDs) to restore the handle are stored under `localStorage` and the handle is restored back at runtime.
    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8467417 View commit details
    Browse the repository at this point in the history
  55. refactor: introduce writable handles to signify updates to handle ref…

    …erences
    
    A special list of writable handles is compiled in a list while issuing handles (request/collection creation, etc). Instead of manually computing the tab and toggling the dirty state, the writable handle is updated (changing the type to invalid on request deletion) and the tab with the request open can infer it via the update reflected in the request handle under the tab save context (reactive update trigger).
    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    cd92dfe View commit details
    Browse the repository at this point in the history
  56. Configuration menu
    Copy the full SHA
    197d253 View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    db9ba17 View commit details
    Browse the repository at this point in the history
  58. fix: make writable handle operate on refs within the `createRESTReque…

    …st` method
    
    Wrap the request handle data in a `ref` and make the writable handle operate over it ensuring reactive updates are received.
    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    90c9f2a View commit details
    Browse the repository at this point in the history
  59. Configuration menu
    Copy the full SHA
    e5e1260 View commit details
    Browse the repository at this point in the history
  60. Configuration menu
    Copy the full SHA
    6cde620 View commit details
    Browse the repository at this point in the history
  61. Configuration menu
    Copy the full SHA
    3a19571 View commit details
    Browse the repository at this point in the history
  62. refactor: consider request handles with tab saveContext resolution fo…

    …r collection move/reorder actions
    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    fe3adee View commit details
    Browse the repository at this point in the history
  63. refactor: move tab saveContext resolution associated with actions on …

    …collections to be based on request handles
    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    7ca94a9 View commit details
    Browse the repository at this point in the history
  64. refactor: persist only request handles under tab saveContext at run…

    …time
    
    Remove provider, workspace and request IDs.
    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8b65090 View commit details
    Browse the repository at this point in the history
  65. Configuration menu
    Copy the full SHA
    5aa57fc View commit details
    Browse the repository at this point in the history
  66. Configuration menu
    Copy the full SHA
    9e8112a View commit details
    Browse the repository at this point in the history
  67. refactor: better tab dirty check

    Mark the tab (saved request under a collection) as not dirty if the request contents are reset to the value since previous save.
    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    0abdc63 View commit details
    Browse the repository at this point in the history
  68. Configuration menu
    Copy the full SHA
    412daa4 View commit details
    Browse the repository at this point in the history
  69. Configuration menu
    Copy the full SHA
    bbac317 View commit details
    Browse the repository at this point in the history
  70. refactor: handle updates post move request action

    - Filter out duplicate issued handle entries.
    - Move from `getAffectedIndexes` helper function to a custom implementation for updating affected request indices.
    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    b239b6b View commit details
    Browse the repository at this point in the history
  71. Configuration menu
    Copy the full SHA
    2f2273e View commit details
    Browse the repository at this point in the history
  72. Configuration menu
    Copy the full SHA
    c8f0142 View commit details
    Browse the repository at this point in the history
  73. Configuration menu
    Copy the full SHA
    5d8da5f View commit details
    Browse the repository at this point in the history
  74. Configuration menu
    Copy the full SHA
    bb57b22 View commit details
    Browse the repository at this point in the history
  75. Configuration menu
    Copy the full SHA
    141652f View commit details
    Browse the repository at this point in the history
  76. Configuration menu
    Copy the full SHA
    e342e53 View commit details
    Browse the repository at this point in the history
  77. Configuration menu
    Copy the full SHA
    52bff8e View commit details
    Browse the repository at this point in the history
  78. Configuration menu
    Copy the full SHA
    6032cbb View commit details
    Browse the repository at this point in the history
  79. Configuration menu
    Copy the full SHA
    648cc8f View commit details
    Browse the repository at this point in the history
  80. Configuration menu
    Copy the full SHA
    25b0818 View commit details
    Browse the repository at this point in the history
  81. Configuration menu
    Copy the full SHA
    e0083aa View commit details
    Browse the repository at this point in the history
  82. Configuration menu
    Copy the full SHA
    86b17e2 View commit details
    Browse the repository at this point in the history
  83. fix: empty state primary action for root collections

    Ensure child collections are created instead of the action resulting in new root collections.
    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f4a37f1 View commit details
    Browse the repository at this point in the history
  84. fix: resolve edge cases about moving collections under its sibling

    - Increase test coverage.
    - Move store mock data under `__tests__/__mocks__`.
    - Rephrase test descriptions.
    jamesgeorge007 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8b930a6 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. chore: cleanup

    jamesgeorge007 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    4c74d0f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    17169e1 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. refactor: update exportRESTCollections method signature

    - Drop the `collections` parameter since the it is already available in the `PersonalWorkspaceProviderService` context.
    - Make the above method return a left error of `NO_COLLECTIONS_TO_EXPORT` when the collections list is empty.
    - Error handling updates.
    jamesgeorge007 committed May 27, 2024
    Configuration menu
    Copy the full SHA
    2374ceb View commit details
    Browse the repository at this point in the history