Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduce abstractions at the workspace level #3836

Draft
wants to merge 87 commits into
base: next
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
29e25b0
refactor: initial iterations
jamesgeorge007 Jan 31, 2024
ab7df21
refactor: iterations
jamesgeorge007 Feb 4, 2024
89bcc58
refactor: compile data in handles
jamesgeorge007 Feb 7, 2024
d6a8e60
refactor: finalize API methods
jamesgeorge007 Feb 8, 2024
f0dab55
refactor: prevent storing entire collection data in the respective ha…
jamesgeorge007 Feb 8, 2024
f0f504d
refactor: unify edit collection API methods and ensure consistent nam…
jamesgeorge007 Feb 9, 2024
1abbdb0
refactor: consistent return formats
jamesgeorge007 Feb 9, 2024
c1a8a87
refactor: save request handle in tabs and remove tabs related logic f…
jamesgeorge007 Feb 9, 2024
392b2fc
refactor: updates based on the provider methods signature changes
jamesgeorge007 Feb 9, 2024
a0e373a
refactor: persist request handle under tab saveContext
jamesgeorge007 Feb 10, 2024
2c47a63
refactor: update provider method signature
jamesgeorge007 Feb 10, 2024
97899ec
chore: cleanup
jamesgeorge007 Feb 12, 2024
30b6a67
fix: prevent duplicate request creation and invalidate tabs with requ…
jamesgeorge007 Feb 12, 2024
63eca80
fix: prevent the need for an explicit save while editing request name
jamesgeorge007 Feb 13, 2024
b0c72fd
feat: indicate request opened in the tab from the collection tree
jamesgeorge007 Feb 13, 2024
68795a5
refactor: port collection tree rendered in the save request modal to …
jamesgeorge007 Feb 13, 2024
7549e45
fix: specify correct request index with update action
jamesgeorge007 Feb 14, 2024
3a176f6
fix: invalidate requests opened under tabs on deleting parent collection
jamesgeorge007 Feb 14, 2024
faa0bf7
fix: updates to collection level authorization and headers reflect at…
jamesgeorge007 Feb 15, 2024
b821f45
fix: ensure the reference is not kept while overwriting requests
jamesgeorge007 Feb 15, 2024
00285df
refactor: remove side effects from computed properties
jamesgeorge007 Feb 15, 2024
0d00826
fix: ensure removing collection level headers persists
jamesgeorge007 Feb 16, 2024
89f7c2c
refactor: port share requests
jamesgeorge007 Feb 16, 2024
316dc8f
refactor: persist IDs under tab save context
jamesgeorge007 Feb 16, 2024
c43e4fc
fix: open request straightaway after creating via save-as
jamesgeorge007 Feb 16, 2024
f4ea999
refactor: remove unnecessary imports and local state variable
Feb 18, 2024
cd23bb6
refactor: remove fields associated with pagination
jamesgeorge007 Feb 19, 2024
8483339
feat: add keypress actions
jamesgeorge007 Feb 19, 2024
6ed9c09
refactor: port import/export functionality
jamesgeorge007 Feb 19, 2024
076006c
refactor: port collection move/reorder
jamesgeorge007 Feb 20, 2024
d0c7c4a
refactor: provider method definitions for collection reorder/move
jamesgeorge007 Feb 20, 2024
0a0f441
refactor: unify markup
jamesgeorge007 Feb 20, 2024
fe01322
refactor: integrate provider API methods for collection move/reorder
jamesgeorge007 Feb 20, 2024
7c52c6b
fix: associate requests under tabs while reordering collections
jamesgeorge007 Feb 22, 2024
af7e6b7
refactor: view based implementation for search in personal workspace
jamesgeorge007 Feb 22, 2024
4665485
refactor: add new tree adapter corresponding to search
jamesgeorge007 Feb 22, 2024
89f2479
refactor: integrate REST search collection adapter
jamesgeorge007 Feb 22, 2024
5a64cdb
fix: update save context for affected requests with collection move/r…
jamesgeorge007 Feb 23, 2024
c30ee5b
refactor: session based search results view implementation
jamesgeorge007 Feb 24, 2024
d70d5bd
refactor: eliminate `collectionID` from tab `saveContext`
jamesgeorge007 Feb 24, 2024
c0978c3
refactor: eliminate `parentCollectionID` field from `RESTCollectionVi…
jamesgeorge007 Feb 24, 2024
84fc31e
refactor: port collection tree empty states
jamesgeorge007 Feb 26, 2024
5b3986a
fix: ensure the collection tree for search immediately reflects actio…
jamesgeorge007 Feb 26, 2024
240b131
feat: support search at n level depth
jamesgeorge007 Feb 26, 2024
7e2deaa
fix: duplicate collection in search results
jamesgeorge007 Feb 27, 2024
116f2fd
refactor: update provider method signatures
jamesgeorge007 Feb 27, 2024
f87a4c8
refactor: leverage helpers
jamesgeorge007 Feb 27, 2024
62612e6
refactor: remove unnecessary safeguards + cleanup
jamesgeorge007 Feb 27, 2024
a729dfc
fix: ensure tree nodes are not computed for requests
jamesgeorge007 Feb 27, 2024
b19486e
refactor: update provider method signatures + cleanup
jamesgeorge007 Feb 29, 2024
01573cc
chore: keep existing implementation for save context resolution
jamesgeorge007 Feb 29, 2024
3fd85df
refactor: view implementation to retrieve collections for exporting
jamesgeorge007 Feb 29, 2024
f6067f1
fix: prevent infinite spinner state while expanding tree nodes
jamesgeorge007 Feb 29, 2024
8467417
refactor: persist request handles under tab `saveContext`
jamesgeorge007 Apr 22, 2024
cd92dfe
refactor: introduce writable handles to signify updates to handle ref…
jamesgeorge007 Apr 23, 2024
197d253
refactor: keep tab dirty status logic at the page level
jamesgeorge007 Apr 25, 2024
db9ba17
refactor: convey updates via handle mutation for update request action
jamesgeorge007 Apr 27, 2024
90c9f2a
fix: make writable handle operate on refs within the `createRESTReque…
jamesgeorge007 Apr 28, 2024
e5e1260
fix: ensure request name updates reflect immediately on the tabs
jamesgeorge007 Apr 28, 2024
6cde620
refactor: signify updates via handle reference mutation post request …
jamesgeorge007 Apr 29, 2024
3a19571
refactor: update data under request handles during tab save context r…
jamesgeorge007 Apr 30, 2024
fe3adee
refactor: consider request handles with tab saveContext resolution fo…
jamesgeorge007 Apr 30, 2024
7ca94a9
refactor: move tab saveContext resolution associated with actions on …
jamesgeorge007 Apr 30, 2024
8b65090
refactor: persist only request handles under tab `saveContext` at run…
jamesgeorge007 May 1, 2024
5aa57fc
refactor: add save context resolution logic post request deletion
jamesgeorge007 May 1, 2024
9e8112a
fix: make close all tabs action account for tabs with invalid request…
jamesgeorge007 May 1, 2024
0abdc63
refactor: better tab dirty check
jamesgeorge007 May 1, 2024
412daa4
refactor: tab saveContext resolution post collection remove action
jamesgeorge007 May 1, 2024
bbac317
refactor: move to handle based updates with request move action
jamesgeorge007 May 2, 2024
b239b6b
refactor: handle updates post move request action
jamesgeorge007 May 3, 2024
2f2273e
refactor: move to inert handles
jamesgeorge007 May 6, 2024
c8f0142
refactor: move more things to handles instead of handleref
AndrewBastin May 8, 2024
5d8da5f
chore: resolve type errors
jamesgeorge007 May 9, 2024
bb57b22
fix: affected request indices computation post request move
jamesgeorge007 May 9, 2024
141652f
fix: affected request indices computation post request reorder
jamesgeorge007 May 9, 2024
e342e53
refactor: handle based updates post collection move
jamesgeorge007 May 9, 2024
52bff8e
refactor: handle based updates post collection reorder
jamesgeorge007 May 14, 2024
6032cbb
refactor: handle based updates for affected requests post request del…
jamesgeorge007 May 14, 2024
648cc8f
refactor: handle based updates for affected requests post collection …
jamesgeorge007 May 14, 2024
25b0818
refactor: update inherited properties for affected requests flow updates
jamesgeorge007 May 15, 2024
e0083aa
fix: handle based updates post collection move to a sibling level col…
jamesgeorge007 May 16, 2024
86b17e2
test: add test suite for personal workspace provider service
jamesgeorge007 May 16, 2024
f4a37f1
fix: empty state primary action for root collections
jamesgeorge007 May 20, 2024
8b930a6
fix: resolve edge cases about moving collections under its sibling
jamesgeorge007 May 21, 2024
4c74d0f
chore: cleanup
jamesgeorge007 May 23, 2024
17169e1
chore: bump `@hoppscotch/ui`
jamesgeorge007 May 23, 2024
2374ceb
refactor: update `exportRESTCollections` method signature
jamesgeorge007 May 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -34,7 +34,7 @@
},
"pnpm": {
"overrides": {
"vue": "3.3.9"
"vue": "3.4.27"
},
"packageExtensions": {
"httpsnippet@3.0.1": {
Expand Down
3 changes: 2 additions & 1 deletion packages/hoppscotch-common/locales/en.json
Expand Up @@ -1027,7 +1027,8 @@
"personal": "Personal Workspace",
"other_workspaces": "My Workspaces",
"team": "Workspace",
"title": "Workspaces"
"title": "Workspaces",
"no_workspace": "No Workspace"
},
"site_protection": {
"login_to_continue": "Login to continue",
Expand Down
4 changes: 2 additions & 2 deletions packages/hoppscotch-common/package.json
Expand Up @@ -36,7 +36,7 @@
"@hoppscotch/codemirror-lang-graphql": "workspace:^",
"@hoppscotch/data": "workspace:^",
"@hoppscotch/js-sandbox": "workspace:^",
"@hoppscotch/ui": "0.1.0",
"@hoppscotch/ui": "0.1.4",
"@hoppscotch/vue-toasted": "0.1.0",
"@lezer/highlight": "1.2.0",
"@unhead/vue": "1.8.8",
Expand Down Expand Up @@ -90,7 +90,7 @@
"util": "0.12.5",
"uuid": "9.0.1",
"verzod": "0.2.2",
"vue": "3.3.9",
"vue": "3.4.27",
"vue-i18n": "9.8.0",
"vue-pdf-embed": "1.2.1",
"vue-router": "4.2.5",
Expand Down
6 changes: 6 additions & 0 deletions packages/hoppscotch-common/src/components.d.ts
Expand Up @@ -181,6 +181,10 @@ declare module 'vue' {
LensesRenderersVideoLensRenderer: typeof import('./components/lenses/renderers/VideoLensRenderer.vue')['default']
LensesRenderersXMLLensRenderer: typeof import('./components/lenses/renderers/XMLLensRenderer.vue')['default']
LensesResponseBodyRenderer: typeof import('./components/lenses/ResponseBodyRenderer.vue')['default']
NewCollections: typeof import('./components/new-collections/index.vue')['default']
NewCollectionsRest: typeof import('./components/new-collections/rest/index.vue')['default']
NewCollectionsRestCollection: typeof import('./components/new-collections/rest/Collection.vue')['default']
NewCollectionsRestRequest: typeof import('./components/new-collections/rest/Request.vue')['default']
ProfileUserDelete: typeof import('./components/profile/UserDelete.vue')['default']
RealtimeCommunication: typeof import('./components/realtime/Communication.vue')['default']
RealtimeConnectionConfig: typeof import('./components/realtime/ConnectionConfig.vue')['default']
Expand Down Expand Up @@ -212,6 +216,8 @@ declare module 'vue' {
TeamsTeam: typeof import('./components/teams/Team.vue')['default']
Tippy: typeof import('vue-tippy')['Tippy']
WorkspaceCurrent: typeof import('./components/workspace/Current.vue')['default']
WorkspacePersonalWorkspaceSelector: typeof import('./components/workspace/PersonalWorkspaceSelector.vue')['default']
WorkspaceSelector: typeof import('./components/workspace/Selector.vue')['default']
WorkspaceTestWorkspaceSelector: typeof import('./components/workspace/TestWorkspaceSelector.vue')['default']
}
}