Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the review comment should go on the old file lines #140

Merged
merged 2 commits into from Oct 9, 2020
Merged

fix: the review comment should go on the old file lines #140

merged 2 commits into from Oct 9, 2020

Conversation

chingor13
Copy link
Contributor

Fixes #139

@chingor13 chingor13 requested review from bcoe and a team October 8, 2020 18:23
@chingor13 chingor13 requested a review from a team as a code owner October 8, 2020 18:23
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2020
@codecov
Copy link

codecov bot commented Oct 8, 2020 •
edited

Codecov Report

Merging #140 into master will decrease coverage by 5.18%.
The diff coverage is 75.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   91.41%   86.22%   -5.19%     
==========================================
  Files          25       41      +16     
  Lines        2248     3986    +1738     
  Branches      180      302     +122     
==========================================
+ Hits         2055     3437    +1382     
- Misses        192      541     +349     
- Partials        1        8       +7
Impacted Files Coverage Δ
src/bin/code-suggester.ts 0.00% <0.00%> (ø)
src/bin/handle-git-dir-change.ts 79.28% <36.66%> (-6.24%) ⬇️
src/bin/workflow.ts 80.00% <69.38%> (-16.23%) ⬇️
...-hunk-scope-handler/remote-patch-ranges-handler.ts 89.91% <72.97%> (-7.21%) ⬇️
src/github-handler/diff-utils.ts 96.87% <94.11%> (-3.13%) ⬇️
...nt-handler/get-hunk-scope-handler/scope-handler.ts 96.66% <96.66%> (ø)
src/github-handler/comment-handler/index.ts 100.00% <100.00%> (ø)
...ler/make-review-handler/upload-comments-handler.ts 98.62% <100.00%> (-0.69%) ⬇️
src/index.ts 99.54% <100.00%> (ø)
src/types/index.ts 98.24% <100.00%> (-0.14%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 841526d...c3bae4d. Read the comment docs.

@bcoe bcoe merged commit 662391f into googleapis:master Oct 9, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 9, 2020
@release-please
chore: release 1.8.0 (#143)
061baef 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.8.0](https://www.github.com/googleapis/code-suggester/compare/v1.7.0...v1.8.0) (2020-10-09)


### Features

* **review:** allow raw diff for reviewPullRequest ([#137](https://www.github.com/googleapis/code-suggester/issues/137)) ([841526d](https://www.github.com/googleapis/code-suggester/commit/841526d720b6af4a21cf3ab08e5749a812fb5c30))


### Bug Fixes

* handle addition-only and deletion-only changes ([#144](https://www.github.com/googleapis/code-suggester/issues/144)) ([ab936a2](https://www.github.com/googleapis/code-suggester/commit/ab936a251171ca5aafc160f3506db54a7cb31e8a)), closes [#126](https://www.github.com/googleapis/code-suggester/issues/126) [#127](https://www.github.com/googleapis/code-suggester/issues/127)
* the review comment should go on the old file lines, not the new file lines ([#140](https://www.github.com/googleapis/code-suggester/issues/140)) ([662391f](https://www.github.com/googleapis/code-suggester/commit/662391f2ae18e8ec997e0961430ce3ccc6f11cee))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

review: commenting on new file lines instead of old file lines
2 participants
@chingor13 @bcoe