Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: cannot handle deletion only suggestions #127

Closed
chingor13 opened this issue Oct 5, 2020 · 0 comments · Fixed by #144
Closed

review: cannot handle deletion only suggestions #127

chingor13 opened this issue Oct 5, 2020 · 0 comments · Fixed by #144
Assignees
@yoshi-automation
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chingor13
Copy link
Contributor

You cannot suggest an empty line, so we will have to group the suggestion as a 2 line change with either the previous line or next line.
@chingor13 chingor13 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 5, 2020
@chingor13 chingor13 changed the title review: cannot handle single line deletion review: cannot handle deletion only suggestions Oct 6, 2020
@chingor13 chingor13 mentioned this issue Oct 8, 2020
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 9, 2020
@chingor13
fix: handle addition-only and deletion-only changes (#144)
ab936a2 
When partitioning valid hunks from invalid hunks, if we detect addition-only or deletion-only changes, modify the hunk to include the previous or next line after the change (assuming it still fits in the valid commentable lines).

Fixes #126 
Fixes #127
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 9, 2020
@release-please
chore: release 1.8.0 (#143)
061baef 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.8.0](https://www.github.com/googleapis/code-suggester/compare/v1.7.0...v1.8.0) (2020-10-09)


### Features

* **review:** allow raw diff for reviewPullRequest ([#137](https://www.github.com/googleapis/code-suggester/issues/137)) ([841526d](https://www.github.com/googleapis/code-suggester/commit/841526d720b6af4a21cf3ab08e5749a812fb5c30))


### Bug Fixes

* handle addition-only and deletion-only changes ([#144](https://www.github.com/googleapis/code-suggester/issues/144)) ([ab936a2](https://www.github.com/googleapis/code-suggester/commit/ab936a251171ca5aafc160f3506db54a7cb31e8a)), closes [#126](https://www.github.com/googleapis/code-suggester/issues/126) [#127](https://www.github.com/googleapis/code-suggester/issues/127)
* the review comment should go on the old file lines, not the new file lines ([#140](https://www.github.com/googleapis/code-suggester/issues/140)) ([662391f](https://www.github.com/googleapis/code-suggester/commit/662391f2ae18e8ec997e0961430ce3ccc6f11cee))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle addition-only and deletion-only changes chingor13/code-suggester
2 participants
@chingor13 @yoshi-automation