feat(review): allow raw diff for reviewPullRequest #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
chingor13
changed the title
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
- Coverage 86.34% 86.30% -0.04%
==========================================
Files 22 41 +19
Lines 2145 3986 +1841
Branches 150 296 +146
==========================================
+ Hits 1852 3440 +1588
- Misses 292 538 +246
- Partials 1 8 +7
Continue to review full report at Codecov.
|
bcoe
reviewed
Oct 7, 2020
| }, | ||
| ]); | ||
|
|
||
| const stubMakePr = proxyquire.noCallThru()( |
There was a problem hiding this comment.
I feel like we probably should be able to use sinon, rather than proxyquire here? It feels a bit weird to me to have both approaches to mocking. I've been landing on a pattern where, if I'm tempted to use proxyquire, I'll instead encapsulate behavior inside a helper method and mock that with sinon.
bcoe
approved these changes
Oct 8, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 9, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.8.0](https://www.github.com/googleapis/code-suggester/compare/v1.7.0...v1.8.0) (2020-10-09) ### Features * **review:** allow raw diff for reviewPullRequest ([#137](https://www.github.com/googleapis/code-suggester/issues/137)) ([841526d](https://www.github.com/googleapis/code-suggester/commit/841526d720b6af4a21cf3ab08e5749a812fb5c30)) ### Bug Fixes * handle addition-only and deletion-only changes ([#144](https://www.github.com/googleapis/code-suggester/issues/144)) ([ab936a2](https://www.github.com/googleapis/code-suggester/commit/ab936a251171ca5aafc160f3506db54a7cb31e8a)), closes [#126](https://www.github.com/googleapis/code-suggester/issues/126) [#127](https://www.github.com/googleapis/code-suggester/issues/127) * the review comment should go on the old file lines, not the new file lines ([#140](https://www.github.com/googleapis/code-suggester/issues/140)) ([662391f](https://www.github.com/googleapis/code-suggester/commit/662391f2ae18e8ec997e0961430ce3ccc6f11cee)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.