fix: the review comment should go on the old file lines, not the new …

…file lines (#140)
googleapis · Oct 9, 2020 · 662391f · 662391f
1 parent 841526d
commit 662391f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/github-handler/comment-handler/make-review-handler/upload-comments-handler.ts b/src/github-handler/comment-handler/make-review-handler/upload-comments-handler.ts
@@ -67,20 +67,20 @@ export function buildReviewComments(
   suggestions.forEach((hunks: Hunk[], fileName: string) => {
     hunks.forEach(hunk => {
       const newContent = hunk.newContent.join('\n');
-      if (hunk.newStart === hunk.newEnd) {
+      if (hunk.oldStart === hunk.oldEnd) {
         const singleComment: SingleLineComment = {
           path: fileName,
           body: `\`\`\`suggestion\n${newContent}\n\`\`\``,
-          line: hunk.newEnd,
+          line: hunk.oldEnd,
           side: 'RIGHT',
         };
         fileComments.push(singleComment);
       } else {
         const comment: MultilineComment = {
           path: fileName,
           body: `\`\`\`suggestion\n${newContent}\n\`\`\``,
-          start_line: hunk.newStart,
-          line: hunk.newEnd,
+          start_line: hunk.oldStart,
+          line: hunk.oldEnd,
           side: 'RIGHT',
           start_side: 'RIGHT',
         };

diff --git a/test/inline-suggest.ts b/test/inline-suggest.ts
@@ -35,7 +35,7 @@ describe('buildFileComments', () => {
       oldStart: 1,
       oldEnd: 2,
       newStart: 1,
-      newEnd: 2,
+      newEnd: 1,
       newContent: ['Foo'],
     };
     suggestions.set(fileName1, [hunk1]);