ref: Move more code to the new way of defining kafka topics and overrides #66283

lynnagara · 2024-03-05T01:19:14Z

This moves the dlq_topic consumer definitions and anything that uses the get_topic_definition helper function over to the new style kafka topic config.

…ides This moves the `dlq_topic` consumer definitions and anything that uses the `get_topic_definition` helper function over to the new style kafka topic config.

codecov · 2024-03-05T02:51:06Z

Codecov Report

Attention: Patch coverage is 76.08696% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 84.29%. Comparing base (508a769) to head (c9d7b05).
Report is 31 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #66283   +/-   ##
=======================================
  Coverage   84.29%   84.29%           
=======================================
  Files        5304     5304           
  Lines      237070   237080   +10     
  Branches    41030    41029    -1     
=======================================
+ Hits       199831   199843   +12     
+ Misses      37020    37018    -2     
  Partials      219      219

Files	Coverage Δ
src/sentry/conf/server.py	`90.09% <100.00%> (+0.03%)`	⬆️
src/sentry/conf/types/kafka_definition.py	`100.00% <100.00%> (ø)`
src/sentry/conf/types/topic_definition.py	`100.00% <100.00%> (ø)`
src/sentry/eventstream/kafka/backend.py	`77.50% <100.00%> (+0.28%)`	⬆️
src/sentry/replays/lib/kafka.py	`100.00% <100.00%> (ø)`
src/sentry/sentry_metrics/configuration.py	`100.00% <100.00%> (ø)`
...y/sentry_metrics/consumers/indexer/multiprocess.py	`84.61% <100.00%> (+0.24%)`	⬆️
src/sentry/usage_accountant/accountant.py	`100.00% <100.00%> (ø)`
src/sentry/utils/kafka_config.py	`100.00% <100.00%> (+2.08%)`	⬆️
src/sentry/utils/outcomes.py	`92.30% <100.00%> (-7.70%)`	⬇️
... and 5 more

... and 7 files with indirect coverage changes

cmanallen

Approving replays changes.

Depends on #66283

getsentry-bot · 2024-03-05T21:49:14Z

PR reverted: 622827e

…nd overrides (#66283)" This reverts commit f7ffe5a. Co-authored-by: ayirr7 <47572810+ayirr7@users.noreply.github.com>

…topics and overrides (#66283)"" This reverts commit 622827e.

Brings back #66283 with fixes to the indexer strategy. It crashed on the prior deploy as we were not producing to the correctly resolved topic.

…ides (#66283) This moves the `dlq_topic` consumer definitions and anything that uses the `get_topic_definition` helper function over to the new style kafka topic config.

Depends on #66283

…nd overrides (#66283)" This reverts commit f7ffe5a. Co-authored-by: ayirr7 <47572810+ayirr7@users.noreply.github.com>

Brings back #66283 with fixes to the indexer strategy. It crashed on the prior deploy as we were not producing to the correctly resolved topic.

…ved (#66288) Depends on #66283 and #66343 --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

ref: Move more code to the new way of defining kafka topics and overr…

1221c85

…ides This moves the `dlq_topic` consumer definitions and anything that uses the `get_topic_definition` helper function over to the new style kafka topic config.

lynnagara requested review from a team as code owners March 5, 2024 01:19

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 5, 2024

vercel bot deployed to Preview March 5, 2024 01:20 View deployment

This was referenced Mar 5, 2024

ref: Move query subscriptions over to new-style kafka config #66287

Merged

ref: Remove all references to settings.KAFKA_TOPICS so it can be removed #66288

Merged

fix test

3d56b37

vercel bot deployed to Preview March 5, 2024 02:20 View deployment

lynnagara added 2 commits March 4, 2024 18:21

produe to real topic

05df7ee

Merge branch 'master' into new-style-kafka-defn

5b188e8

vercel bot deployed to Preview March 5, 2024 02:25 View deployment

anonrig requested a review from a team March 5, 2024 12:30

cmanallen approved these changes Mar 5, 2024

View reviewed changes

Swatinem approved these changes Mar 5, 2024

View reviewed changes

untitaker approved these changes Mar 5, 2024

View reviewed changes

update test

c9d7b05

vercel bot deployed to Preview March 5, 2024 17:56 View deployment

lynnagara merged commit f7ffe5a into master Mar 5, 2024
50 of 51 checks passed

lynnagara deleted the new-style-kafka-defn branch March 5, 2024 18:21

lynnagara added a commit that referenced this pull request Mar 5, 2024

ref: Move query subscriptions over to new-style kafka config (#66287)

f9c2ffd

Depends on #66283

ayirr7 added the Trigger: Revert add to a merged PR to revert it (skips CI) label Mar 5, 2024

getsentry-bot added a commit that referenced this pull request Mar 5, 2024

Revert "ref: Move more code to the new way of defining kafka topics a…

622827e

…nd overrides (#66283)" This reverts commit f7ffe5a. Co-authored-by: ayirr7 <47572810+ayirr7@users.noreply.github.com>

lynnagara mentioned this pull request Mar 5, 2024

ref: Move code to new-style kafka topics - take 2 #66381

Merged

lynnagara added a commit that referenced this pull request Mar 5, 2024

Revert "Revert "ref: Move more code to the new way of defining kafka …

2143a59

…topics and overrides (#66283)"" This reverts commit 622827e.

lynnagara added a commit that referenced this pull request Mar 6, 2024

ref: Move code to new-style kafka topics - take 2 (#66381)

6fa756e

Brings back #66283 with fixes to the indexer strategy. It crashed on the prior deploy as we were not producing to the correctly resolved topic.

aliu3ntry pushed a commit that referenced this pull request Mar 6, 2024

ref: Move query subscriptions over to new-style kafka config (#66287)

1794c57

Depends on #66283

aliu3ntry pushed a commit that referenced this pull request Mar 6, 2024

Revert "ref: Move more code to the new way of defining kafka topics a…

db28b55

…nd overrides (#66283)" This reverts commit f7ffe5a. Co-authored-by: ayirr7 <47572810+ayirr7@users.noreply.github.com>

aliu3ntry pushed a commit that referenced this pull request Mar 6, 2024

ref: Move code to new-style kafka topics - take 2 (#66381)

75f021c

Brings back #66283 with fixes to the indexer strategy. It crashed on the prior deploy as we were not producing to the correctly resolved topic.

lynnagara added a commit that referenced this pull request Mar 6, 2024

ref: Remove all references to settings.KAFKA_TOPICS so it can be remo…

7e29cd4

…ved (#66288) Depends on #66283 and #66343 --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

github-actions bot locked and limited conversation to collaborators Mar 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ref: Move more code to the new way of defining kafka topics and overrides #66283

ref: Move more code to the new way of defining kafka topics and overrides #66283

lynnagara commented Mar 5, 2024

codecov bot commented Mar 5, 2024 •

edited

cmanallen left a comment

getsentry-bot commented Mar 5, 2024

ref: Move more code to the new way of defining kafka topics and overrides #66283

ref: Move more code to the new way of defining kafka topics and overrides #66283

Conversation

lynnagara commented Mar 5, 2024

codecov bot commented Mar 5, 2024 • edited

Codecov Report

cmanallen left a comment

Choose a reason for hiding this comment

getsentry-bot commented Mar 5, 2024

codecov bot commented Mar 5, 2024 •

edited