ref: Remove all references to settings.KAFKA_TOPICS so it can be removed #66288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ides This moves the `dlq_topic` consumer definitions and anything that uses the `get_topic_definition` helper function over to the new style kafka topic config.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66288 +/- ##
=======================================
Coverage 84.30% 84.30%
=======================================
Files 5311 5311
Lines 237263 237258 -5
Branches 41036 41035 -1
=======================================
- Hits 200016 200015 -1
+ Misses 37028 37024 -4
Partials 219 219
|
Swatinem
approved these changes
Mar 5, 2024
untitaker
reviewed
Mar 5, 2024
| kafka_topic_dict = settings.KAFKA_TOPICS[kafka_topic_name] | ||
| assert kafka_topic_dict is not None | ||
| cluster_name = kafka_topic_dict["cluster"] | ||
| logical_topic = Topic.INGEST_PERFORMANCE_METRICS |
There was a problem hiding this comment.
can we make this Topic enum a basic class with strings? some of the tests fail now because an enum variant is not an actual string
There was a problem hiding this comment.
Damn, the failures are a real bug. Looks like there are more pre-requisites before I can merge this (specifically, all the consumer definitions need to use the new way)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #66283 and #66343