Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Move code to new-style kafka topics - take 2 #66381

Merged
merged 2 commits into from Mar 6, 2024
Merged

Conversation

lynnagara
Copy link
Member

Brings back #66283 with fixes to the indexer strategy. It crashed on the prior deploy as we were not producing to the correctly resolved topic.

@lynnagara lynnagara requested a review from a team as a code owner March 5, 2024 23:47
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 76.59574% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 84.29%. Comparing base (de0d46e) to head (43d7276).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #66381      +/-   ##
==========================================
- Coverage   84.30%   84.29%   -0.01%     
==========================================
  Files        5309     5309              
  Lines      237205   237215      +10     
  Branches    41039    41038       -1     
==========================================
+ Hits       199966   199970       +4     
- Misses      37020    37026       +6     
  Partials      219      219              
Files Coverage Δ
src/sentry/conf/server.py 90.12% <100.00%> (+0.03%) ⬆️
src/sentry/conf/types/kafka_definition.py 100.00% <100.00%> (ø)
src/sentry/conf/types/topic_definition.py 100.00% <100.00%> (ø)
src/sentry/eventstream/kafka/backend.py 77.50% <100.00%> (+0.28%) ⬆️
src/sentry/replays/lib/kafka.py 100.00% <100.00%> (ø)
src/sentry/sentry_metrics/configuration.py 100.00% <100.00%> (ø)
...y/sentry_metrics/consumers/indexer/multiprocess.py 84.61% <100.00%> (+0.24%) ⬆️
src/sentry/usage_accountant/accountant.py 100.00% <100.00%> (ø)
src/sentry/utils/kafka_config.py 100.00% <100.00%> (+2.08%) ⬆️
src/sentry/utils/outcomes.py 100.00% <100.00%> (ø)
... and 5 more

... and 10 files with indirect coverage changes

@lynnagara lynnagara merged commit 6fa756e into master Mar 6, 2024
50 of 51 checks passed
@lynnagara lynnagara deleted the unrevert-66283 branch March 6, 2024 00:34
Copy link

sentry-io bot commented Mar 6, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ KafkaException: KafkaError{code=MSG_SIZE_TOO_LARGE,val=10,str="Unable to produce message: Broker: Message size to... sentry.tasks.store.save_event_transaction View Issue

Did you find this useful? React with a 👍 or 👎

aliu3ntry pushed a commit that referenced this pull request Mar 6, 2024
Brings back #66283 with fixes to
the indexer strategy. It crashed on the prior deploy as we were not
producing to the correctly resolved topic.
lynnagara added a commit that referenced this pull request Mar 7, 2024
This brings back #66287. It was
reverted before as it depended on an earlier commit which was also
reverted. Nothing has changed though.

Depends on #66381
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants