Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Move query subscriptions over to new-style kafka config #66287

Merged
merged 8 commits into from Mar 5, 2024
Merged

ref: Move query subscriptions over to new-style kafka config #66287

merged 8 commits into from Mar 5, 2024

Conversation

lynnagara
Copy link
Member

Depends on #66283

@lynnagara
ref: Move more code to the new way of defining kafka topics and overr…
1221c85 
…ides

This moves the `dlq_topic` consumer definitions and anything that uses
the `get_topic_definition` helper function over to the new style kafka
topic config.
@lynnagara
ref: Move query subscriptions over to new-style kafka config
795c058
@lynnagara lynnagara requested review from a team as code owners March 5, 2024 01:59
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 5, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 5, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.30%. Comparing base (f7ffe5a) to head (ac9c009).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #66287   +/-   ##
=======================================
  Coverage   84.29%   84.30%           
=======================================
  Files        5309     5309           
  Lines      237197   237200    +3     
  Branches    41034    41035    +1     
=======================================
+ Hits       199952   199961    +9     
+ Misses      37026    37020    -6     
  Partials      219      219
Files Coverage Δ
src/sentry/consumers/__init__.py 71.22% <ø> (ø)
src/sentry/snuba/query_subscriptions/constants.py 100.00% <100.00%> (ø)
src/sentry/snuba/query_subscriptions/run.py 95.65% <100.00%> (+0.19%) ⬆️

... and 7 files with indirect coverage changes

Base automatically changed from new-style-kafka-defn to master March 5, 2024 18:21
@lynnagara lynnagara requested review from a team as code owners March 5, 2024 18:21
@lynnagara lynnagara merged commit f9c2ffd into master Mar 5, 2024
48 checks passed
@lynnagara lynnagara deleted the query-subscriptions-new-kafka-config branch March 5, 2024 19:07
@IanWoodard IanWoodard added the Trigger: Revert add to a merged PR to revert it (skips CI) label Mar 5, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: c94ad9e

getsentry-bot added a commit that referenced this pull request Mar 5, 2024
@getsentry-bot @IanWoodard
Revert "ref: Move query subscriptions over to new-style kafka config (#…
c94ad9e 
…66287)"

This reverts commit f9c2ffd.

Co-authored-by: IanWoodard <17186604+IanWoodard@users.noreply.github.com>
lynnagara added a commit that referenced this pull request Mar 5, 2024
@lynnagara
Revert "Revert "ref: Move query subscriptions over to new-style kafka…
27740f0 
… config (#66287)""

This reverts commit c94ad9e.
@lynnagara lynnagara mentioned this pull request Mar 6, 2024
Merged
aliu3ntry pushed a commit that referenced this pull request Mar 6, 2024
@lynnagara @aliu3ntry
ref: Move query subscriptions over to new-style kafka config (#66287)
1794c57 
Depends on #66283
aliu3ntry pushed a commit that referenced this pull request Mar 6, 2024
@getsentry-bot @IanWoodard @aliu3ntry
Revert "ref: Move query subscriptions over to new-style kafka config (#…
5a5b331 
…66287)"

This reverts commit f9c2ffd.

Co-authored-by: IanWoodard <17186604+IanWoodard@users.noreply.github.com>
lynnagara added a commit that referenced this pull request Mar 7, 2024
@lynnagara
ref: Unrevert #66287 (#66383)
86291d0 
This brings back #66287. It was
reverted before as it depended on an earlier commit which was also
reverted. Nothing has changed though.

Depends on #66381
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@untitaker untitaker untitaker approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lynnagara @getsentry-bot @untitaker @IanWoodard