feat(feedback): add feedback-events DLQ #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshFerge
reviewed
Mar 15, 2024
| pipeline: user-feedback | ||
| description: DLQ for ingest-feedback-events | ||
| services: | ||
| producers: |
There was a problem hiding this comment.
Just which services (i.e. sentry) are producing to this topic. Likely will be used soon to make these topics automatically available to sentry code via configuration.
lynnagara
reviewed
Mar 15, 2024
CODEOWNERS
Outdated
| @@ -9,6 +9,7 @@ | |||
| /topics/ingest-events-dlq.yaml @getsentry/owners-snuba | |||
| /topics/ingest-metrics-dlq.yaml @getsentry/owners-snuba | |||
| /topics/ingest-generic-metrics-dlq.yaml @getsentry/owners-snuba | |||
| /topics/ingest-feedback-events-dlq.yaml @getsentry/owners-snuba | |||
There was a problem hiding this comment.
Oh I did this because of the pattern that all other dlq's are owners-snuba only. Would you recommend I change it to snuba+replay, or just replay?
There was a problem hiding this comment.
Hmm, probably just replay is fine if you guys own it. Or whatever matches the main ingest-feedback-events topic I guess.
lynnagara
approved these changes
Mar 15, 2024
aliu3ntry
added a commit
to getsentry/sentry
that referenced
this pull request
Mar 15, 2024
Need to verify the values of `dlq_` fields in consumers/__init__. These are used to create a DlqPolicy (line 509, same file) requires getsentry/sentry-kafka-schemas#238
JonasBa
pushed a commit
to getsentry/sentry
that referenced
this pull request
Mar 17, 2024
Need to verify the values of `dlq_` fields in consumers/__init__. These are used to create a DlqPolicy (line 509, same file) requires getsentry/sentry-kafka-schemas#238
saponifi3d
pushed a commit
to getsentry/sentry
that referenced
this pull request
Mar 18, 2024
Need to verify the values of `dlq_` fields in consumers/__init__. These are used to create a DlqPolicy (line 509, same file) requires getsentry/sentry-kafka-schemas#238
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.