feat(feedback): add config for feedback DLQ (#67068)

Need to verify the values of `dlq_` fields in consumers/__init__. These are used to create a DlqPolicy (line 509, same file) requires getsentry/sentry-kafka-schemas#238
getsentry · Mar 18, 2024 · a507cc9 · a507cc9
1 parent a28e322
commit a507cc9
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 2 deletions.
diff --git a/src/sentry/conf/server.py b/src/sentry/conf/server.py
@@ -3473,6 +3473,7 @@ def build_cdc_postgres_init_db_volume(settings: Any) -> dict[str, dict[str, str]
     "metrics-subscription-results": "default",
     "ingest-events": "default",
     "ingest-feedback-events": "default",
+    "ingest-feedback-events-dlq": "default",
     "ingest-attachments": "default",
     "ingest-transactions": "default",
     "ingest-metrics": "default",

diff --git a/src/sentry/conf/types/kafka_definition.py b/src/sentry/conf/types/kafka_definition.py
@@ -27,6 +27,7 @@ class Topic(Enum):
     INGEST_EVENTS = "ingest-events"
     INGEST_EVENTS_DLQ = "ingest-events-dlq"
     INGEST_FEEDBACK_EVENTS = "ingest-feedback-events"
+    INGEST_FEEDBACK_EVENTS_DLQ = "ingest-feedback-events-dlq"
     INGEST_ATTACHMENTS = "ingest-attachments"
     INGEST_TRANSACTIONS = "ingest-transactions"
     INGEST_METRICS = "ingest-metrics"

diff --git a/src/sentry/consumers/__init__.py b/src/sentry/consumers/__init__.py
@@ -268,6 +268,7 @@ def ingest_events_options() -> list[click.Option]:
         "static_args": {
             "consumer_type": "feedback-events",
         },
+        "dlq_topic": Topic.INGEST_FEEDBACK_EVENTS_DLQ,
     },
     "ingest-attachments": {
         "topic": Topic.INGEST_ATTACHMENTS,

diff --git a/tests/sentry/conf/test_kafka_definition.py b/tests/sentry/conf/test_kafka_definition.py
@@ -16,8 +16,6 @@ def test_topic_definition() -> None:
     # TODO: Remove this once these topics are actually registered in sentry-kafka-schemas
     currently_unregistered_topics = [
         "outcomes-billing",
-        "ingest-events",
-        "ingest-events-dlq",
         "ingest-attachments",
         "ingest-transactions",
         "ingest-metrics-dlq",