feat(feedback): add feedback-events DLQ #238
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| topic: ingest-feedback-events-dlq | ||
| pipeline: user-feedback | ||
| description: DLQ for ingest-feedback-events | ||
| services: | ||
| producers: | ||
|
There was a problem hiding this comment. Just which services (i.e. sentry) are producing to this topic. Likely will be used soon to make these topics automatically available to sentry code via configuration. |
||
| - getsentry/sentry | ||
| consumers: [] | ||
| schemas: | ||
| - version: 1 | ||
| compatibility_mode: none | ||
| type: json | ||
| resource: any.json | ||
| examples: | ||
| - any/ | ||
| topic_creation_config: | ||
| compression.type: lz4 | ||
| log.retention.minutes: "10080" # 7 days | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this replays team now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I did this because of the pattern that all other dlq's are owners-snuba only. Would you recommend I change it to snuba+replay, or just replay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, probably just replay is fine if you guys own it. Or whatever matches the main
ingest-feedback-eventstopic I guess.