feat(feedback): add config for feedback DLQ #67068
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #67068 +/- ##
===========================================
+ Coverage 57.15% 84.27% +27.11%
===========================================
Files 5114 5307 +193
Lines 225767 237310 +11543
Branches 38996 41050 +2054
===========================================
+ Hits 129042 199993 +70951
+ Misses 96504 37099 -59405
+ Partials 221 218 -3
|
src/sentry/consumers/__init__.py
Outdated
| "dlq_max_invalid_ratio": 0.01, | ||
| "dlq_max_consecutive_count": 1000, |
There was a problem hiding this comment.
Mind removing these 2 lines? We experimented with various values but now I think we should just skip these (across the board not specific to your use case)
There was a problem hiding this comment.
Sure, should we remove from the other ones too?
There was a problem hiding this comment.
Yes we probably should. But I'll double check and do it as a follow up -- let's just focus on the ingest-feedback-events-dlq here.
There was a problem hiding this comment.
similarly, I noticed ingest-events consumer doesn't have a dlq_topic. Not something to worry about for this PR though
There was a problem hiding this comment.
I'm pretty sure it does have now. I just added it. You might need to rebase/merge master to see it.
| "ingest-events", | ||
| "ingest-events-dlq", |
Need to verify the values of `dlq_` fields in consumers/__init__. These are used to create a DlqPolicy (line 509, same file) requires getsentry/sentry-kafka-schemas#238
Need to verify the values of `dlq_` fields in consumers/__init__. These are used to create a DlqPolicy (line 509, same file) requires getsentry/sentry-kafka-schemas#238
Need to verify the values of
dlq_fields in consumers/init. These are used to create a DlqPolicy (line 509, same file)requires getsentry/sentry-kafka-schemas#238