Release 2.0

[dougwilson]

This is a tracking issue for release 2.0.

I am trying to give better visibility for upcoming changes and so am trying out making a PR for a release here, pulling from the official next release branch into master. This allows for the current pending changes to be easily visible.

Please keep feature requests in their own issues

I'm also leaving this PR unlocked so people can make comments/etc. and we'll see how it goes :) If you want to make a comment on a particular change, please make the comment in the "Files changed" tab so comments are not lost during a rebase.

List of changes for release:

• Add generic body parser
• Add limit: null as alias for limit: Infinity Add support for removing body parser limit #493
• Add multipart field body parser
• Drop support for Node.js 0.8
• Drop support for Node.js below 4
• req.body no longer always set to {}, which works better for non-object-like bodies like text
• on-finished used to detect if the request has been read; no longer need to set req._body to a truthy value
• urlencoded no longer defaults extended to true

List of deprecated things removed:

• Main bodyParser() function which did urlencoded + json

Testing this release

If you want to try out this release, you can install it with the following command:

$ npm cache clean
$ npm install expressjs/body-parser#2.x
$ npm cache clean

[Fishrock123]

@dougwilson isn't abstraction from parsers or whatever scheduled-ish for 2.0?

[dougwilson]

Yea, I haven't fully added everything to the checklist yet. I just wanted to make the PR so it starts to get eyes.

[LinusU]

@dougwilson Would love to use this, have you thought about publishing to npm as 2.0.0-beta1? Thanks 👍

[dougwilson]

Hey @LinusU ! I never published it because I didn't think there was anyone wanting to start, so without demand, I did not want to burden myself with maintaining two working release lines at once, if it wasn't necessary. I'll see about getting a alpha/beta out, though :) You can always add a branch/commit of a git repo as an npm dependency, though.

[LinusU]

Cool. I mainly wanted the first bullet which caused a bug for me when only using the raw middleware. But I just worked around it in code since I still want to get bugfixes. Would be cool to get 2.0 out for real thought. Whats missing? Is there anything I can help with?

[theganyo]

Hey @dougwilson! So I just found this because of the bugs I've been battling today related to #128, but I see the issue and this PR have been open for over a year despite being fixed. Since it doesn't look like this is going to happen (or is there still a chance?), is the only option to fork and release under a different name?

[dougwilson]

Hi @theganyo , you are certainly welcome to fork & release this under another module, as it is under the MIT license, but there are a few reasons why it has yet to be released:

1. I had a report that the changes in here can sometimes stall out a request. I have not been able to look, but if you would like to test it out on your systems (using the instructions provided in the original post), that would be much appreciated!
2. This was proposed over a year ago, but with Express 3.x still supported and relying on this module, it was not possible to release a breaking version without adding more work for myself, which is all done unpaid, and so I've been waiting for Express 3.x to go away first.

is the only option to fork and release under a different name?

You can always depend on the branch in GitHub in your package.json... https://docs.npmjs.com/files/package.json#git-urls-as-dependencies

[dougwilson]

And since Express 3.x is now "officially unsupported", I want to just make one last 1.x release here and then publish a 2.0.0 alpha for people to start testing on.

[theganyo]

Thanks, Doug. As you might have guessed, forking and releasing isn't at top of my list of alternatives. :) I just wanted to gauge whether this was really still potentially going to be supported. Since you're looking at a new release, I'll just hack around it for now and update later. Thanks for the quick reply!