Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raw() parser: if body is empty, req.body is set to empty object #187

Closed
Olivier-OH opened this issue Jul 26, 2016 · 1 comment
Closed

raw() parser: if body is empty, req.body is set to empty object #187

Olivier-OH opened this issue Jul 26, 2016 · 1 comment
Assignees
@dougwilson

Comments

@Olivier-OH
Copy link

I think the correct behaviour should be to have an empty string body.
@Olivier-OH Olivier-OH mentioned this issue Jul 26, 2016
Closed
@dougwilson
Copy link
Contributor

Hi @Olivier-OH, defaulting to a string in the raw parser does not make sense, since a successful raw parse results in a Buffer object, not a string. Besides, we actually went ahead and fixed these semantics in the 2.0 branch. Please go ahead and check out the proposed 2.0 release in #66 :)

@dougwilson dougwilson self-assigned this Jul 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dougwilson dougwilson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dougwilson @Olivier-OH