New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support "err instanceof http-errors" for all individual errors #22
Conversation
As mentioned in #21, builds fail for Node.js 0.6 and 0.8 because of dependencies, not due to the PR |
tests now pass for this pr, and rebased with the most current master branch |
Thanks a lot! I'm currently mulling over this right now. I am 100% for adding another object into the prototype such that they all inherit from it, i.e. Then, after that, I'm thinking, if the My current thoughts are leaning towards the following:
What are your thoughts? If this sounds good or any other thoughts, let me know. I can easily alter your own pull request to reflect this if you are not around to change it, or just don't fell like it because this sounds like a good enough change. |
My thought would be that the Please feel free to change it, and thanks! |
Nice! And, so here's something that may interest you: so, because this module is depending on too large of a version range of |
👍 awesome! I'd be happy to put some thought in and see if I can help out. where will you be listing your proposed changes? |
Feel free to make any issues/PRs you like :) When I get rolling, it'll be in a release PR, like what I've done with Express and other modules (example: expressjs/body-parser#66). This would track the merged things and provide an overview of the progress and goals at the top. |
Allows for a broader
instanceof
check. Rather than needing to check if an error is a specific status code type, one can check for a genericHttpError
as well.