Fix for raw() parser if body is empty #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raw() parser: if body is empty set it to empty string rather than empty dictionnary.
Update raw.js
|
Unit tests don't pass because somewhere an empty object is expected instead of an empty string. I don't know whether I should change the unit test code. Is this important that the body is an empty object instead of an empty string? |
raw() parser test fixed
|
I changed the unit test code. I'll let the repo owners decide whether this is correct. |
|
Hi @Olivier-OH, defaulting to a string in the raw parser does not make sense, since a successful raw parse results in a |
|
Great! Thanks for your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set it to empty string rather than an empty Object.
See issue #187