Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the uswds prop's default value to true for all compoents with a v… #1043

Closed
wants to merge 18 commits into from

Conversation

it-harrison
Copy link
Contributor

@it-harrison it-harrison commented Jan 30, 2024

…3 version

Chromatic

https://2405-usdws-default-true--60f9b557105290003b387cd5.chromatic.com


Configuring this pull request

Description

This PR sets the default value for the uswds prop to true for all components with a v3 variant. It also makes adjustments to components that used composition with other components so that the correct version is used. Finally, it updates stories and moves up v3 stories to the top of the sidebar in Storybook.

Closes 2405

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@it-harrison it-harrison added the major Major change in semantic versioning label Jan 30, 2024
Copy link
Contributor

@powellkerry powellkerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename the USWDS section in storybook to "Components" and change the section for the v1 components to something else?

Copy link
Contributor

@micahchiang micahchiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@it-harrison - Should this PR include a version bump to the web components package? Or, would you prefer to do that in a separate PR when we bump core for the release of this stuff?

@jamigibbs
Copy link
Contributor

In the Chromatic link, I think some USWDS components might have been missed to move them into the top "Components" section:

Screenshot 2024-02-20 at 8 51 31 AM

@it-harrison
Copy link
Contributor Author

In the Chromatic link, I think some USWDS components might have been missed to move them into the top "Components" section:

@jamigibbs thanks - fixed

@jamigibbs
Copy link
Contributor

jamigibbs commented Feb 23, 2024

ope! Just noticed a few stragglers. The v1 version of va-alert and va-textarea and va-text-input are hanging out next to the v3 versions. Should they be moved down to the V1 Components section too?

Screenshot 2024-02-23 at 4 33 31 PM
Screenshot 2024-02-23 at 4 35 30 PM
Screenshot 2024-02-23 at 4 38 10 PM

@@ -19,7 +19,7 @@ export class VaProcessList {
/**
* Whether or not the component will use USWDS v3 styling.
*/
@Prop() uswds?: boolean = false
@Prop() uswds?: boolean = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need an exception here. v3 va-process-list expects va-process-list-item as its children while v1 expects li. This will break v1s being auto-upgraded to v3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call out here @ataker. I think what we'll do is go with @jamigibbs's suggestion to set all of the necessary instances in vets-website to uswds=false. There aren't that many, and it unblocks our release plans for next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Major change in semantic versioning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formation Deprecation - set uswds prop to true on all components
6 participants