New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the uswds prop's default value to true for all compoents with a v… #1043
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename the USWDS section in storybook to "Components" and change the section for the v1 components to something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@it-harrison - Should this PR include a version bump to the web components package? Or, would you prefer to do that in a separate PR when we bump core for the release of this stuff?
@jamigibbs thanks - fixed |
@@ -19,7 +19,7 @@ export class VaProcessList { | |||
/** | |||
* Whether or not the component will use USWDS v3 styling. | |||
*/ | |||
@Prop() uswds?: boolean = false | |||
@Prop() uswds?: boolean = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need an exception here. v3 va-process-list
expects va-process-list-item
as its children while v1 expects li
. This will break v1s being auto-upgraded to v3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call out here @ataker. I think what we'll do is go with @jamigibbs's suggestion to set all of the necessary instances in vets-website to uswds=false
. There aren't that many, and it unblocks our release plans for next week.
…3 version
Chromatic
https://2405-usdws-default-true--60f9b557105290003b387cd5.chromatic.com
Configuring this pull request
Description
This PR sets the default value for the
uswds
prop to true for all components with a v3 variant. It also makes adjustments to components that used composition with other components so that the correct version is used. Finally, it updates stories and moves up v3 stories to the top of the sidebar in Storybook.Closes 2405
QA Checklist
Screenshots
Acceptance criteria
Definition of done