Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the uswds prop's default value to true for all compoents with a v… #1043

Closed
wants to merge 18 commits into from
Closed

Set the uswds prop's default value to true for all compoents with a v… #1043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
2ad4b53
Set the uswds prop's default value to true for all compoents with a v…
it-harrison Jan 30, 2024
368120c
update tests and components
it-harrison Jan 31, 2024
18ee703
update stories
it-harrison Jan 31, 2024
681f251
merge and update
it-harrison Feb 13, 2024
9542af5
merge with main
it-harrison Feb 16, 2024
0543e30
rename storybook section headings for components
it-harrison Feb 16, 2024
8685523
move missed uswds components to Components section
it-harrison Feb 20, 2024
273660f
move V1 stories to V1 section
it-harrison Feb 27, 2024
5a49ad8
sync with main
it-harrison Feb 27, 2024
c6bac70
update failing test
it-harrison Feb 27, 2024
f7317f2
update radio stories
it-harrison Feb 27, 2024
d47d942
tweak story categories
it-harrison Feb 27, 2024
23538c4
fix story
it-harrison Feb 27, 2024
a10f22d
resolve conflict
it-harrison Mar 1, 2024
dc41745
Merge branch 'main' into 2405-usdws-default-true
it-harrison Mar 6, 2024
568db31
update sass to account for uswds default
it-harrison Mar 7, 2024
45179db
update sass
it-harrison Mar 7, 2024
7bdcb12
update sass/css
it-harrison Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/storybook/.storybook/preview.js
View file
Open in desktop
Expand Up @@ -88,6 +88,7 @@ export const parameters = {
'About',
['Introduction'],
'Components',
'V1 Components',
'Under development',
'Deprecated',
],
Expand Down
73 changes: 36 additions & 37 deletions packages/storybook/stories/va-accordion-uswds.stories.jsx
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@ const accordionDocs = getWebComponentDocs('va-accordion');
const accordionItem = getWebComponentDocs('va-accordion-item');

export default {
title: 'USWDS/Accordion USWDS',
title: 'Components/Accordion USWDS',
id: 'uswds/va-accordion',
subcomponents: componentStructure(accordionItem),
parameters: {
Expand All @@ -23,21 +23,21 @@ export default {

const Template = args => (
<va-accordion {...args}>
<va-accordion-item uswds id="first" header="First Amendment">
<va-accordion-item id="first" header="First Amendment">
<p>
Congress shall make no law respecting an establishment of religion, or
prohibiting the free exercise thereof; or abridging the freedom of speech,
or of the press; or the right of the people peaceably to assemble, and to
petition the Government for a redress of grievances.
</p>
</va-accordion-item>
<va-accordion-item uswds id="second" header="Second Amendment">
<va-accordion-item id="second" header="Second Amendment">
<p>
A well regulated Militia, being necessary to the security of a free State,
the right of the people to keep and bear Arms, shall not be infringed.
</p>
</va-accordion-item>
<va-accordion-item uswds id="third" header="Third Amendment">
<va-accordion-item id="third" header="Third Amendment">
<p>
No Soldier shall, in time of peace be quartered in any house, without the
consent of the Owner, nor in time of war, but in a manner to be prescribed by law.
Expand All @@ -49,21 +49,21 @@ const Template = args => (
const BorderedTemplate = args => {
return (
<va-accordion {...args}>
<va-accordion-item uswds id="first" bordered="true" header="First Amendment">
<va-accordion-item id="first" bordered="true" header="First Amendment">
<p>
Congress shall make no law respecting an establishment of religion, or
prohibiting the free exercise thereof; or abridging the freedom of speech,
or of the press; or the right of the people peaceably to assemble, and to
petition the Government for a redress of grievances.
</p>
</va-accordion-item>
<va-accordion-item uswds id="second" bordered="true" header="Second Amendment">
<va-accordion-item id="second" bordered="true" header="Second Amendment">
<p>
A well regulated Militia, being necessary to the security of a free State,
the right of the people to keep and bear Arms, shall not be infringed.
</p>
</va-accordion-item>
<va-accordion-item uswds id="third" bordered="true" header="Third Amendment">
<va-accordion-item id="third" bordered="true" header="Third Amendment">
<p>
No Soldier shall, in time of peace be quartered in any house, without the
consent of the Owner, nor in time of war, but in a manner to be prescribed by law.
Expand All @@ -75,21 +75,21 @@ const BorderedTemplate = args => {

const TemplateSubheader = args => (
<va-accordion {...args}>
<va-accordion-item uswds id="first" header="First Amendment" subheader="Subheader">
<va-accordion-item id="first" header="First Amendment" subheader="Subheader">
<p>
Congress shall make no law respecting an establishment of religion, or
prohibiting the free exercise thereof; or abridging the freedom of speech,
or of the press; or the right of the people peaceably to assemble, and to
petition the Government for a redress of grievances.
</p>
</va-accordion-item>
<va-accordion-item uswds id="second" header="Second Amendment" subheader="Subheader">
<va-accordion-item id="second" header="Second Amendment" subheader="Subheader">
<p>
A well regulated Militia, being necessary to the security of a free State,
the right of the people to keep and bear Arms, shall not be infringed.
</p>
</va-accordion-item>
<va-accordion-item uswds id="third" header="Third Amendment" subheader="Subheader">
<va-accordion-item id="third" header="Third Amendment" subheader="Subheader">
<p>
No Soldier shall, in time of peace be quartered in any house, without the
consent of the Owner, nor in time of war, but in a manner to be prescribed by law.
Expand All @@ -100,7 +100,7 @@ const TemplateSubheader = args => (

const TemplateIconHeaders = args => (
<va-accordion {...args}>
<va-accordion-item uswds id="first" header="First Amendment" subheader="Subheader">
<va-accordion-item id="first" header="First Amendment" subheader="Subheader">
<i slot="icon" className="fas fa-info-circle vads-u-color--green"/>
<i aria-hidden="true" className="fas fa-envelope" slot="subheader-icon"/>
<p>
Expand All @@ -110,15 +110,15 @@ const TemplateIconHeaders = args => (
petition the Government for a redress of grievances.
</p>
</va-accordion-item>
<va-accordion-item uswds id="second" header="Second Amendment" subheader="Subheader">
<va-accordion-item id="second" header="Second Amendment" subheader="Subheader">
<i slot="icon" className="fas fa-info-circle vads-u-color--green"/>
<i aria-hidden="true" className="fas fa-envelope" slot="subheader-icon"/>
<p>
A well regulated Militia, being necessary to the security of a free State,
the right of the people to keep and bear Arms, shall not be infringed.
</p>
</va-accordion-item>
<va-accordion-item uswds id="third" header="Third Amendment" subheader="Subheader">
<va-accordion-item id="third" header="Third Amendment" subheader="Subheader">
<i slot="icon" className="fas fa-info-circle vads-u-color--green"/>
<i aria-hidden="true" className="fas fa-envelope" slot="subheader-icon"/>
<p>
Expand All @@ -131,7 +131,7 @@ const TemplateIconHeaders = args => (

const TemplateHeadlineSlot = args => (
<va-accordion {...args}>
<va-accordion-item uswds id="first">
<va-accordion-item id="first">
<h6 slot="headline">First Amendment</h6>
<p>
Congress shall make no law respecting an establishment of religion, or
Expand All @@ -140,14 +140,14 @@ const TemplateHeadlineSlot = args => (
petition the Government for a redress of grievances.
</p>
</va-accordion-item>
<va-accordion-item uswds id="second">
<va-accordion-item id="second">
<h6 slot="headline">Second Amendment</h6>
<p>
A well regulated Militia, being necessary to the security of a free State,
the right of the people to keep and bear Arms, shall not be infringed.
</p>
</va-accordion-item>
<va-accordion-item uswds id="third">
<va-accordion-item id="third">
<h6 slot="headline">Third Amendment</h6>
<p>
No Soldier shall, in time of peace be quartered in any house, without the
Expand All @@ -160,21 +160,21 @@ const TemplateHeadlineSlot = args => (

const TemplateLevel = args => (
<va-accordion {...args}>
<va-accordion-item uswds level="5" id="first" header="First Amendment">
<va-accordion-item level="5" id="first" header="First Amendment">
<p>
Congress shall make no law respecting an establishment of religion, or
prohibiting the free exercise thereof; or abridging the freedom of speech,
or of the press; or the right of the people peaceably to assemble, and to
petition the Government for a redress of grievances.
</p>
</va-accordion-item>
<va-accordion-item uswds level="5" id="second" header="Second Amendment">
<va-accordion-item level="5" id="second" header="Second Amendment">
<p>
A well regulated Militia, being necessary to the security of a free State,
the right of the people to keep and bear Arms, shall not be infringed.
</p>
</va-accordion-item>
<va-accordion-item uswds level="5" id="third" header="Third Amendment">
<va-accordion-item level="5" id="third" header="Third Amendment">
<p>
No Soldier shall, in time of peace be quartered in any house, without the
consent of the Owner, nor in time of war, but in a manner to be prescribed by law.
Expand All @@ -192,26 +192,26 @@ const I18nTemplate = args => {

return (
<div>
<va-button uswds onClick={e => setLang('es')} text="Español"/>
<va-button uswds onClick={e => setLang('en')} text="English"/>
<va-button uswds onClick={e => setLang('tl')} text="Tagalog"/>
<va-accordion uswds>
<va-accordion-item id="first" header="First Amendment" uswds>
<va-button onClick={e => setLang('es')} text="Español"/>
<va-button onClick={e => setLang('en')} text="English"/>
<va-button onClick={e => setLang('tl')} text="Tagalog"/>
<va-accordion>
<va-accordion-item id="first" header="First Amendment">
<p>
Congress shall make no law respecting an establishment of religion, or
prohibiting the free exercise thereof; or abridging the freedom of
speech, or of the press; or the right of the people peaceably to
assemble, and to petition the Government for a redress of grievances.
</p>
</va-accordion-item>
<va-accordion-item id="second" header="Second Amendment" uswds>
<va-accordion-item id="second" header="Second Amendment">
<p>
A well regulated Militia, being necessary to the security of a free
State, the right of the people to keep and bear Arms, shall not be
infringed.
</p>
</va-accordion-item>
<va-accordion-item id="third" header="Third Amendment" uswds>
<va-accordion-item id="third" header="Third Amendment">
<p>
No Soldier shall, in time of peace be quartered in any house, without
the consent of the Owner, nor in time of war, but in a manner to be
Expand All @@ -225,34 +225,34 @@ const I18nTemplate = args => {

const ManyItemsTemplate = args => (
<va-accordion {...args}>
<va-accordion-item uswds id="first" header="First Amendment">
<va-accordion-item id="first" header="First Amendment">
<p>
Congress shall make no law respecting an establishment of religion, or
prohibiting the free exercise thereof; or abridging the freedom of speech,
or of the press; or the right of the people peaceably to assemble, and to
petition the Government for a redress of grievances.
</p>
</va-accordion-item>
<va-accordion-item uswds id="second" header="Second Amendment">
<va-accordion-item id="second" header="Second Amendment">
<p>
A well regulated Militia, being necessary to the security of a free State,
the right of the people to keep and bear Arms, shall not be infringed.
</p>
</va-accordion-item>
<va-accordion-item uswds id="third" header="Third Amendment">
<va-accordion-item id="third" header="Third Amendment">
<p>
No Soldier shall, in time of peace be quartered in any house, without the
consent of the Owner, nor in time of war, but in a manner to be prescribed by law.
</p>
</va-accordion-item>
<va-accordion-item uswds id="fourth" header="Fourth Amendment">
<va-accordion-item id="fourth" header="Fourth Amendment">
<p>
The right of the people to be secure in their persons, houses, papers, and effects, against unreasonable searches and seizures,
shall not be violated, and no Warrants shall issue, but upon probable cause, supported by Oath or affirmation, and particularly
describing the place to be searched, and the persons or things to be seized.
</p>
</va-accordion-item>
<va-accordion-item uswds id="fifth" header="Fifth Amendment">
<va-accordion-item id="fifth" header="Fifth Amendment">
<p>
No person shall be held to answer for a capital, or otherwise infamous crime, unless on a presentment or indictment of a Grand Jury,
except in cases arising in the land or naval forces, or in the Militia, when in actual service in time of War or public danger;
Expand All @@ -261,31 +261,31 @@ const ManyItemsTemplate = args => (
shall private property be taken for public use, without just compensation.
</p>
</va-accordion-item>
<va-accordion-item uswds id="sixth" header="Sixth Amendment">
<va-accordion-item id="sixth" header="Sixth Amendment">
<p>
In all criminal prosecutions, the accused shall enjoy the right to a speedy and public trial, by an impartial jury of the State
and district wherein the crime shall have been committed, which district shall have been previously ascertained by law, and to
be informed of the nature and cause of the accusation; to be confronted with the witnesses against him; to have compulsory process
for obtaining witnesses in his favor, and to have the Assistance of Counsel for his defence.
</p>
</va-accordion-item>
<va-accordion-item uswds id="seventh" header="Seventh Amendment">
<va-accordion-item id="seventh" header="Seventh Amendment">
<p>
In Suits at common law, where the value in controversy shall exceed twenty dollars, the right of trial by jury shall be preserved,
and no fact tried by a jury, shall be otherwise re-examined in any Court of the United States, than according to the rules of the common law.
</p>
</va-accordion-item>
<va-accordion-item uswds id="eighth" header="Eighth Amendment">
<va-accordion-item id="eighth" header="Eighth Amendment">
<p>
Excessive bail shall not be required, nor excessive fines imposed, nor cruel and unusual punishments inflicted.
</p>
</va-accordion-item>
<va-accordion-item uswds id="ninth" header="Ninth Amendment">
<va-accordion-item id="ninth" header="Ninth Amendment">
<p>
The enumeration in the Constitution, of certain rights, shall not be construed to deny or disparage others retained by the people.
</p>
</va-accordion-item>
<va-accordion-item uswds id="tenth" header="Tenth Amendment">
<va-accordion-item id="tenth" header="Tenth Amendment">
<p>
The powers not delegated to the United States by the Constitution, nor prohibited by it to the States, are reserved to the States respectively, or to the people.
</p>
Expand All @@ -297,7 +297,6 @@ const ManyItemsTemplate = args => (
const defaultArgs = {
'bordered': false,
'open-single': undefined,
uswds: true
};

export const Default = Template.bind(null);
Expand Down