Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[View Payments] Upgrade web components to their V3 versions #28025

Merged
merged 2 commits into from Feb 20, 2024

Conversation

jerekshoe
Copy link
Contributor

@jerekshoe jerekshoe commented Feb 16, 2024

Summary

Upgrading all of the web components in the View Payments application to use their V3 versions. Also removing uswds="false" on web components that don't have a V3 version currently

Related issue(s)

Screenshots

va-alert

Before After
Desktop va-alert-before va-alert-after

va-table / va-pagination

Before After
Desktop va-table-before va-table-after

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@jerekshoe jerekshoe self-assigned this Feb 16, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/76127-view-payments-v3-migration/main February 16, 2024 17:47 Inactive
@jerekshoe jerekshoe marked this pull request as ready for review February 16, 2024 18:47
@jerekshoe jerekshoe requested review from a team as code owners February 16, 2024 18:47
<va-alert status={status} uswds>
{alertContent}
</va-alert>
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerekshoe Line 128 also has a va-alert so we should update that as well!

micahchiang
micahchiang previously approved these changes Feb 16, 2024
Copy link
Contributor

@pmclaren19 pmclaren19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! LGTM :)

Copy link
Contributor

@pmclaren19 pmclaren19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerekshoe I think we actually can remove this prop entirely? https://dsva.slack.com/archives/C055573C508/p1708110642607439 And by default it will be set to true.

@pmclaren19
Copy link
Contributor

@jerekshoe I think we actually can remove this prop entirely? https://dsva.slack.com/archives/C055573C508/p1708110642607439 And by default it will be set to true.

Talked with the Team this morning in stand up and this ticket is fine to merge, @jerekshoe will just want to create another ticket for the work to remove the uswds=true when this pr is merged.

@jerekshoe jerekshoe merged commit 4053001 into main Feb 20, 2024
139 of 140 checks passed
@jerekshoe jerekshoe deleted the 76127-view-payments-v3-migration branch February 20, 2024 18:09
pjhill pushed a commit that referenced this pull request Feb 21, 2024
* Upgrading web components to their V3 versions
pjhill pushed a commit that referenced this pull request Mar 14, 2024
* Upgrading web components to their V3 versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants