New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[View Payments] Upgrade web components to their V3 versions #28025
Conversation
<va-alert status={status} uswds> | ||
{alertContent} | ||
</va-alert> | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerekshoe Line 128 also has a va-alert so we should update that as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating! LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerekshoe I think we actually can remove this prop entirely? https://dsva.slack.com/archives/C055573C508/p1708110642607439 And by default it will be set to true.
Talked with the Team this morning in stand up and this ticket is fine to merge, @jerekshoe will just want to create another ticket for the work to remove the |
* Upgrading web components to their V3 versions
* Upgrading web components to their V3 versions
Summary
Upgrading all of the web components in the View Payments application to use their V3 versions. Also removing
uswds="false"
on web components that don't have a V3 version currentlyRelated issue(s)
[View Payments] v3 component migration va.gov-team#76127
Screenshots
va-alert
va-table
/va-pagination
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
#sitewide-public-websites
Slack channel for questionsRequested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?