Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Letters] migrate to v3 components #76123

Closed
5 tasks
jacobworrell opened this issue Feb 13, 2024 · 8 comments
Closed
5 tasks

[Letters] migrate to v3 components #76123

jacobworrell opened this issue Feb 13, 2024 · 8 comments
Assignees
Labels
benefits-management-tools aka. squad 1 (previously known as Claim Status Tools) benefits-team-1 Board filter label for Benefits Team #1

Comments

@jacobworrell
Copy link
Contributor

Background

We need to migrate v1 components to v3 components. There are nine components that need to be migrated to V3 in the Letters app. We need to remove the false prop for 6 components. We can beginning working this ticket after 2/16.

Here is a link to the audit doc.

Steps

  • Any components that were updated as USWDS false that are not V3 components should have that prop removed.
  • Design and engineering test locally to confirm design fidelity of the migration before changes are merged

Acceptance Criteria

  • All V1 components with a V3 version are migrated to that version of the component.
  • All V1 components that do not have a V3 version do not have a prop set to false
  • Post migration, the UI meets the BMT team's design and Ux standards.
@pmclaren19
Copy link
Contributor

Unable to link it but this ticket is blocked by department-of-veterans-affairs/component-library#1043. We did this pr to merge before we can remove the uswds prop since that pr work sets uswds to true by default.

@SilkeDannVA
Copy link

We can continue work on 3/4.

@HeatherWidmont
Copy link
Contributor

Peri hasn't seen any messages about a merge that was supposed to happen on 3/4. @pmclaren19 will check if there have been any announcements, but as of right now this is still blocked.

@pmclaren19
Copy link
Contributor

On March 4th Design team announced this would now happen on 4/11/24.

@pmclaren19
Copy link
Contributor

Was Blocked until department-of-veterans-affairs/vets-website#28486 was merged. they merged on 3/15.

@pmclaren19
Copy link
Contributor

@jacobworrell please validate when you can. Take a look at the pr that was merged for more details!

@HeatherWidmont
Copy link
Contributor

Jacob took a look & said this should probably be validated by Design instead. @uxgary will take a look

@uxgary
Copy link
Contributor

uxgary commented Mar 21, 2024

Verified with Peri. Moving to close

@uxgary uxgary closed this as completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benefits-management-tools aka. squad 1 (previously known as Claim Status Tools) benefits-team-1 Board filter label for Benefits Team #1
Projects
None yet
Development

No branches or pull requests

6 participants