Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc Bugfixes #735

Merged
merged 24 commits into from
Dec 10, 2023
Merged

Misc Bugfixes #735

merged 24 commits into from
Dec 10, 2023

Conversation

Ne-wt
Copy link
Contributor

@Ne-wt Ne-wt commented Dec 6, 2023

contains a series of bug fixes and some QoL changes

issues mentioned in commits

@itinerare itinerare self-requested a review December 6, 2023 01:19
@itinerare itinerare added bug Something isn't working enhancement New feature or request needs review Pull requests that are pending community review labels Dec 6, 2023
This was linked to issues Dec 6, 2023
Lack of sorting option in admin queues #96
Open
Request for more designated Rank powers (regarding news and sales) #113
Open
Sorting User Index by Alias (A-Z) or Alias (Z-A) does not function #225
Open
Sorting User Index (in admin section) by Alias (A-Z) or Alias (Z-A) functions incorrectly #226
Open
Gallery submission data not retained upon error #91
Open
Ne-wt and others added 3 commits December 6, 2023 01:42
@Ne-wt @github-actions
refactor: fix PHP styling
0c534b4
@Ne-wt
Merge branch 'develop' of https://github.com/corowne/lorekeeper into …
2d36b76 
…bugfixes

# Conflicts:
#	app/Services/SubmissionManager.php
#	resources/views/home/_submission_content.blade.php
#	resources/views/home/create_submission.blade.php
@Ne-wt
array_unique on slugs for gallery
5d5c622
This was linked to issues Dec 7, 2023
Search by subtype in Admin traits.. non-functional? #346
Open
500 error when character on sale is deleted #459
Open
500 error when character added to submission is deleted #460
Open
Notification on MYO Slot Profile edits return wrong url #558
Open
Duplicated code in speciesService leading to redeclaration error #728
Open
itinerare
itinerare requested changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@itinerare itinerare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are a few small tweaks need making, but broadly, looks good! Thanks again for taking the time to do this, too.

app/Models/Report/Report.php Outdated Show resolved Hide resolved
app/Models/User/User.php Outdated Show resolved Hide resolved
resources/views/auth/register.blade.php Show resolved Hide resolved
resources/views/sales/_sales.blade.php Outdated Show resolved Hide resolved
preimpression
preimpression approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@preimpression preimpression left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Commented on a couple little things that probably wouldn't do anything but make me happy lol

app/Services/UserService.php Outdated Show resolved Hide resolved
resources/views/admin/sales/create_edit_sales.blade.php Outdated Show resolved Hide resolved
resources/views/admin/submissions/submission.blade.php Outdated Show resolved Hide resolved
resources/views/home/_submission_content.blade.php Show resolved Hide resolved
@itinerare itinerare mentioned this pull request Dec 10, 2023
Merged
@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Dec 10, 2023
@itinerare itinerare merged commit 343035e into corowne:develop Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itinerare itinerare itinerare approved these changes

@preimpression preimpression preimpression approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Milestone
No milestone
3 participants
@Ne-wt @preimpression @itinerare