500 error when character on sale is deleted #459
Labels
bug
Something isn't working
Comments
This was referenced Dec 9, 2022
Merged
itinerare
pushed a commit
that referenced
this issue
Dec 10, 2023
* fix issue #728 * fix #96 * fix #113 * Update birthday selector on register * fix #225 * fix #226 * fix #346 * fix #558 * fix #460 * fix #459 * fix #91 * Apply fixes from #91 to prompt submissions * refactor: fix blade formatting * remove character item retention due to return input wackiness * refactor: fix PHP styling * array_unique on slugs for gallery * add missing set active on user sidebars * add comment history and bugfix for likes * refactor: fix blade formatting * tweak function docs and sales comments checks * refactor: fix blade formatting * Capitalise 'carbon' in UserService * refactor: fix PHP styling --------- Co-authored-by: Ne-wt <Ne-wt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug as reported:
(Main branch, last commit parent: da3ebb11)
URL of page:
<site>/sales,<site>/sales/<id>and<site>/admin/sales/edit/<id>(where is the id of the sale in question)Description of bug: When a character has been deleted entirely, and they were part of a sales post, the sale in question as well as the admin page on which it is editable, will give out a 500 error. (And of course any of the sales pages that sale is displayed on.)
How was the bug caused (exact steps to reproduce): Add a character to a sale. Delete the character. Go to the sale in either public area or the editing page of the admin section.
Further details
..Yeah, I guess this is a thing that happens. Should be a decently easy fix, just have a check if it exists and if not display something like 'Character Not Found' like with gallery images.
PR #462 should fix this, eventually.The text was updated successfully, but these errors were encountered: