Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for more designated Rank powers (regarding news and sales) #113

Open
SpeedyD opened this issue May 19, 2021 · 1 comment · Fixed by #735
Open

Request for more designated Rank powers (regarding news and sales) #113

SpeedyD opened this issue May 19, 2021 · 1 comment · Fixed by #735
Labels
enhancement New feature or request

Comments

@SpeedyD
Copy link
Contributor

SpeedyD commented May 19, 2021

Bug as reported:

(release/release-2.0.0 branch, last commit parent: 549e010 ))

URL of page: N/A
Description of bug: Only users with the 'edit_pages' (or Edit Text Pages) power can comment on sales posts that are still in the Preview period... and that's odd.
How was the bug caused (exact steps to reproduce): Make a sale. Delay comments. Find out that some of your staff can't comment on the sale.

Further details

Another non-bug bug report from me..

Long story short. I recently made a sales post on the LK site I'm involved in and delayed comments so that the staff could leave sales comments before users replied. One of the ranks we've set up is for Official Artists, who do art and make adopts, but have no task directly related to the site. They were completely unable to respond to the sales post while it was in Preview.

I later found out it requires the 'edit_pages' power.. Which.. is honestly confusing? Editing pages is not commenting on sales posts.. Heck, editing pages is not posting news or sales, but it's all under the same header.

So my suggestion here was originally born out of a designated rank power which allows users which have it to comment on sales- a rank power I definitely still explicitly need.. But perhaps also rank powers that are specifically for setting up news and sales posts?

@itinerare itinerare added the enhancement New feature or request label May 19, 2021
@itinerare
Copy link
Collaborator

Noting since I'm thinking about it that it's probably prudent to have a breakdown like so:

  • News edit power
  • Sales edit power
  • Sales comment power, which sales edit power inherently includes but which may be granted separately since official, guest etc artists who should have this access but do not otherwise handle admin affairs are a fairly regular occurrence.

@itinerare itinerare linked a pull request Dec 6, 2023 that will close this issue
itinerare pushed a commit that referenced this issue Dec 10, 2023
* fix issue #728

* fix #96

* fix #113

* Update birthday selector on register

* fix #225

* fix #226

* fix #346

* fix #558

* fix #460

* fix #459

* fix #91

* Apply fixes from #91 to prompt submissions

* refactor: fix blade formatting

* remove character item retention due to return input wackiness

* refactor: fix PHP styling

* array_unique on slugs for gallery

* add missing set active on user sidebars

* add comment history and bugfix for likes

* refactor: fix blade formatting

* tweak function docs and sales comments checks

* refactor: fix blade formatting

* Capitalise 'carbon' in UserService

* refactor: fix PHP styling

---------

Co-authored-by: Ne-wt <Ne-wt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants