Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

500 error when character added to submission is deleted #460

Open
SpeedyD opened this issue Dec 9, 2022 · 0 comments · Fixed by #735
Open

500 error when character added to submission is deleted #460

SpeedyD opened this issue Dec 9, 2022 · 0 comments · Fixed by #735
Labels
bug Something isn't working

Comments

@SpeedyD
Copy link
Contributor

SpeedyD commented Dec 9, 2022

Bug as reported:

(Main branch, last commit parent: da3ebb11)

URL of page: <site>/submissions/view/<id>, <site>/claims/claims/<id>, <site>/admin/submissions/edit/<id> and <site>/admin/claims/edit/<id> (where is the id of the claim/submission in question)
Description of bug: When a character has been deleted entirely, if it was ever part of a submission or claim, whether resolved or not, that submission or claim will give out a 500 error, even in the admin version.
How was the bug caused (exact steps to reproduce): Add a character to a submission or claim. Delete the character. Go to the submission or claim in either public area or the editing page of the admin section.

Further details

...similar to the previous issue (issue #459), but now specifically submissions and claims, which are technically the same thing. Should also be a decently easy fix here.

@itinerare itinerare added the bug Something isn't working label Dec 9, 2022
Ne-wt added a commit to Ne-wt/lorekeeper that referenced this issue Dec 6, 2023
@itinerare itinerare linked a pull request Dec 7, 2023 that will close this issue
itinerare pushed a commit that referenced this issue Dec 10, 2023
* fix issue #728

* fix #96

* fix #113

* Update birthday selector on register

* fix #225

* fix #226

* fix #346

* fix #558

* fix #460

* fix #459

* fix #91

* Apply fixes from #91 to prompt submissions

* refactor: fix blade formatting

* remove character item retention due to return input wackiness

* refactor: fix PHP styling

* array_unique on slugs for gallery

* add missing set active on user sidebars

* add comment history and bugfix for likes

* refactor: fix blade formatting

* tweak function docs and sales comments checks

* refactor: fix blade formatting

* Capitalise 'carbon' in UserService

* refactor: fix PHP styling

---------

Co-authored-by: Ne-wt <Ne-wt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants