Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated code in speciesService leading to redeclaration error #728

Open
phoseatspho opened this issue Nov 17, 2023 · 0 comments · Fixed by #735
Open

Duplicated code in speciesService leading to redeclaration error #728

phoseatspho opened this issue Nov 17, 2023 · 0 comments · Fixed by #735
Labels
bug Something isn't working good first issue Good for newcomers php Pull requests that update Php code
Milestone
v3.0.0

Comments

@phoseatspho
Copy link

Develop branch
app/Services/SpeciesService
Lines 281 - 333 are the develop branch code
Lines 335 - 381 is the original code from the main branch

The presence of both leads to Cannot redeclare App\Services\SpeciesService::populateData() when creating a species admin/data/species/create

removing lines 335-381 fixed this :>
@itinerare itinerare added bug Something isn't working good first issue Good for newcomers php Pull requests that update Php code labels Nov 17, 2023
@itinerare itinerare added this to the v3.0.0 milestone Nov 17, 2023
Ne-wt added a commit to Ne-wt/lorekeeper that referenced this issue Dec 5, 2023
@Ne-wt
fix issue corowne#728
34b472f
@itinerare itinerare linked a pull request Dec 7, 2023 that will close this issue
Misc Bugfixes #735
Merged
itinerare pushed a commit that referenced this issue Dec 10, 2023
@Ne-wt
feat: resolve standing issues (#735)
343035e 
* fix issue #728

* fix #96

* fix #113

* Update birthday selector on register

* fix #225

* fix #226

* fix #346

* fix #558

* fix #460

* fix #459

* fix #91

* Apply fixes from #91 to prompt submissions

* refactor: fix blade formatting

* remove character item retention due to return input wackiness

* refactor: fix PHP styling

* array_unique on slugs for gallery

* add missing set active on user sidebars

* add comment history and bugfix for likes

* refactor: fix blade formatting

* tweak function docs and sales comments checks

* refactor: fix blade formatting

* Capitalise 'carbon' in UserService

* refactor: fix PHP styling

---------

Co-authored-by: Ne-wt <Ne-wt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers php Pull requests that update Php code
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

Misc Bugfixes Ne-wt/lorekeeper
2 participants
@itinerare @phoseatspho