Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QtWebKit needs to be deprecated #53079

Closed
30 of 69 tasks
veprbl opened this issue Dec 30, 2018 · 24 comments
Closed
30 of 69 tasks

QtWebKit needs to be deprecated #53079

veprbl opened this issue Dec 30, 2018 · 24 comments

Comments

@veprbl
Copy link
Member

veprbl commented Dec 30, 2018

QtWebKit was deprecated in Qt 5.6. We are now using an outdated unofficial port:

# Community port of the now unmaintained upstream qtwebkit.
qtwebkit = rec {
src = fetchFromGitHub {
owner = "qtwebkit";
repo = "qtwebkit";
rev = "qtwebkit-${version}";
sha256 = "11lc5sk10d9cyg8jqkbgkqiap72b9rax7hy61nm90zw9749y2yfg";
};
version = "5.212.0-alpha4";
};

In some cases, applications already provide support for using QtWebEngine instead, we just need to enable it. The advantage of using QtWebEngine is that it is supported by the Qt upstream.

This issue is to track progress (or lack thereof) in deprecation of QtWebKit.

Overview

Legend: ✔︎ - dependency can be removed, ✘ - no straightforward solution was found, ? - dependency can be removed at a cost

How to help?

  1. Take an open item from the list that doesn't have a comment, google "<itemname> qtwebengine" and "<itemname> qtwebkit". Report what you find (or add a comment if you can edit the post).
  2. Take an open item from the list that does have a comment and ping a maintainer if the fix is possible. Alternatively try fixing it yourself.
@bhipple
Copy link
Contributor

bhipple commented Mar 10, 2019

I don't think we'll be able to kill the dependency easily in google-musicmanager, since we're already on Google's latest release, which lists this as an explicit dependency:

$ curl http://dl.google.com/linux/musicmanager/deb/dists/stable/main/binary-amd64/Packages
Package: google-musicmanager-beta
Version: 1.0.467.4929-r0
Architecture: amd64
Maintainer: Google Music Team <googleplay-support-music@google.com>
Installed-Size: 16766
Pre-Depends: dpkg (>= 1.14.0)
Depends: libc6 (>= 2.16), libexpat1 (>= 2.0.1), libflac8 (>= 1.3.0), libgcc1 (>= 1:4.1.1), libidn11 (>= 1.13), libqt5core5a (>= 5.2.0), libqt5gui5 (>= 5.0.2) | libqt5gui5-gles (>= 5.0.2), libqt5network5 (>= 5.0.2), libqt5webkit5, libqt5widgets5 (>= 5.2.0), libstdc++6 (>= 4.6), libvorbisfile3 (>= 1.1.2), xdg-utils (>= 1.0.2)

@cpages cpages mentioned this issue Apr 1, 2019
10 tasks
@veprbl veprbl mentioned this issue Apr 23, 2019
10 tasks
@matthewbauer matthewbauer modified the milestones: 19.03, 19.09 May 27, 2019
@KAMiKAZOW
Copy link

We are now using an outdated unofficial port

Not unofficial – endorsed by Qt: https://code.qt.io/cgit/qt/qtwebkit.git/ And currently in the process of a massive overhaul thanks to Patreon funding.

@veprbl
Copy link
Member Author

veprbl commented Aug 12, 2019

@KAMiKAZOW This is definitely a good news for qtwebkit and its users. However, we are using a specific 5.212-alpha version that is outdated and contains known CVE's. Looking at the repo at your link, it doesn't seem to contain any significant update to address those issues. I doubt anyone would endorse this software in its current state.

@KAMiKAZOW
Copy link

Looking at the repo at your link, it doesn't seem to contain any significant update to address those issues.

The development happens here on Github. "My" link was solely a reference proving that it's not unofficial but instead adopted by upstream Qt.

As you can read under https://github.com/qtwebkit/qtwebkit/blob/qtwebkit-dev/ReadMe.md#this-repository-development the qtwebkit-dev branch is the update to current WebKit master.

@veprbl veprbl removed this from the 19.09 milestone Feb 10, 2020
@sikmir
Copy link
Member

sikmir commented Jun 16, 2020

zeal ported to qtwebengine (zealdocs/zeal#1125), not released yet.

@FRidh FRidh mentioned this issue Aug 4, 2020
10 tasks
@bachp
Copy link
Member

bachp commented Aug 6, 2020

Freecad will be ported with the 0.19 release FreeCAD/FreeCAD@75fd723, not released yet

@bachp
Copy link
Member

bachp commented Aug 6, 2020

messagelib no longer depends on qtwebengine since c2366ae

@gebner
Copy link
Member

gebner commented Nov 12, 2020

freecad no longer depends on qtwebkit since we switched to the 0.19 prerelease in #98845/#100972.

@jerith666
Copy link
Contributor

The issue for OpenShot linked in the description is outdated; it's been superseded by OpenShot/openshot-qt#3604.

@milahu
Copy link
Contributor

milahu commented Apr 15, 2022

no straightforward solution was found

example: scrapinghub/splash#349

splash is not in nixpkgs. its needed for the legacy project portia (a GUI for scrapy)

@impl
Copy link
Member

impl commented Sep 6, 2022

p4v doesn't depend on qtwebkit since #110168.

@K900
Copy link
Contributor

K900 commented Nov 13, 2022

apitrace is done: #201032

@gador
Copy link
Contributor

gador commented Nov 19, 2022

teamviewer builds and runs fine without qtwebkit in version 15.29.4
I cannot test the connectivity, though, since I don't have a teamviewer partner to test it with
@jagajaga and @jraygauthier as maintainers

das-g added a commit to das-g/nixpkgs that referenced this issue Nov 19, 2022
@aidalgol
Copy link
Contributor

@das-g How are you going with fixing the kmymoney build? I'm hitting build errors in my attempts to build against qtwebengine.

@das-g
Copy link
Member

das-g commented Nov 19, 2022

@aidalgol working on it, should be ready in some minutes.

@das-g
Copy link
Member

das-g commented Nov 19, 2022

@aidalgol PR to switch kmymoney from qtwebkit to qtwebengine: #201953

das-g added a commit to das-g/nixpkgs that referenced this issue Nov 20, 2022
(to get rid of transitive dependency on qtwebkit)
See PR NixOS#201028 and issue NixOS#53079
@flokli flokli mentioned this issue Nov 20, 2022
31 tasks
@LunNova
Copy link
Member

LunNova commented Nov 20, 2022

qgis depends on it and isn't in the main list.

Looks like it can build with QtWebEngine but won't work due to some bugs, see qgis/QGIS@7c1d616

@totoroot
Copy link
Contributor

totoroot commented Apr 17, 2023

yacas does not rely on QtWebKit, since PR #147826 got merged.
I think we can tick its box ☑️

@totoroot
Copy link
Contributor

totoroot commented Apr 17, 2023

quiterss seems to be unmaintained (see QuiteRSS/quiterss#1566) so the issue dealing with the removal of QtWebKit (QuiteRSS/quiterss#1573) will probably never be resolved.

The suggested move to QuiteRSS2 (https://github.com/QuiteRSS/quiterss2) might make sense, since it uses QtWebEngine, but I'm unsure about any unwanted implications this could lead to.
Also, it too hasn't had commits since May 2020 and there is no stable release.

@totoroot
Copy link
Contributor

totoroot commented Apr 17, 2023

qlandkartegt hasn't seen any updates since 2015 and can therefore probably be considered unmaintained/abandoned:
https://sourceforge.net/projects/qlandkartegt/

On the AUR (patches fetched from there) it has been unmaintained as well:
https://aur.archlinux.org/packages/qlandkartegt

I'd suggest changing the ✔︎ to a ✘ for its entry.

@totoroot
Copy link
Contributor

totoroot commented Apr 17, 2023

copyq does not rely on QtWebKit, since PR #130670 got merged.
I think we can tick its box ☑️

@totoroot
Copy link
Contributor

Issue for a port from QtWebKit to QtWebEngine for kexi and kreport are still open:
pkgs/development/libraries/kreport/

@K900
Copy link
Contributor

K900 commented Apr 17, 2023

Qtwebkit has been marked insecure since #201028. No point in trying to check every single box.

@K900 K900 closed this as completed Apr 17, 2023
@totoroot
Copy link
Contributor

Fantastic 😅
Thanks for the notice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.