brewtarget: 2.3.1 -> 3.0.6 #217648
brewtarget: 2.3.1 -> 3.0.6 #217648
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
avnik
force-pushed
the
update/brewtarget
branch
from
43d4f84
to
f53114f
Compare
There was a problem hiding this comment.
@avnik Could you please also replace Qt's mkDerivation with stdenv.mkDerivation to fix
#180841
For that to work wrapQtAppsHook will be needed.
If you can, please also update it to 3.0.7 which has already been released in the meantime:
https://github.com/Brewtarget/brewtarget/releases/tag/v3.0.7
|
Also this PR would fix the issue with qtwebkit for brewtarget (for cross-reference): |
Drop insecure qtwebkit
|
@totoroot I fixed all suggestions (except bumping to 3.0.7 -- newer brewtarget depends on boost_stacktrace_backtrace which not yet packaged), also rebased PR on newer master |
| nativeBuildInputs = [ cmake ]; | ||
| buildInputs = [ qtbase qttools qtmultimedia qtwebkit qtsvg ]; | ||
| nativeBuildInputs = [ cmake qt5.wrapQtAppsHook ]; | ||
| buildInputs = [ boost xalanc xercesc ] ++ |
There was a problem hiding this comment.
| buildInputs = [ boost xalanc xercesc ] ++ | |
| buildInputs = [ boost curl xalanc xercesc ] ++ |
| , fetchFromGitHub | ||
| , bash | ||
| , boost |
There was a problem hiding this comment.
| , boost | |
| , boost | |
| , curl |
|
@avnik Sorry for the late response. The last I checked, it did not build on darwin, which can be seen in ofborg's tests as well. |
| @@ -2958,7 +2958,7 @@ with pkgs; | |||
|
|
|||
| brakeman = callPackage ../development/tools/analysis/brakeman { }; | |||
|
|
|||
| brewtarget = libsForQt5.callPackage ../applications/misc/brewtarget { } ; | |||
wegank
added
2.status: stale
stale
bot
removed
the
2.status: stale
Upgrade to 3.0.6
Also drop "insecure" qtwebkit
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)