Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compilation with QtWebEngine #1357

Closed
wants to merge 1 commit into from

Conversation

cyplo
Copy link

@cyplo cyplo commented May 27, 2021

Hi !
I find mindforger very useful and I help packaging it for NixOS.
We're trying to deprecate QtWebKit across all NixOS packages.
As part of that work I found that mindforger accepts "CONFIG+=mfwebengine" and then tries to compile with QtWebEngine.
When I ran the build I found that the project does not fully successfully compile with that option though.
This PR is an attempt to fix that - the resulting binary works very well on NixOS, I however haven't tested it on Windows nor MacOS.
I think I shouldn't have broken these targets, just by reading the the code, but would probably be best to test on those ?

For reference - here's the PR I'm trying to land to change the NixOS package definition - it includes these changes as a patch for now, but the reviewers suggested upstreaming first, hence my PR here :)

Hope this helps, please let me know what you think :)

If this makes sense, I would like to open another PR for the second patch that makes the output directories relocatable, but didn't want to spam with PRs without opening up a conversation.

@godlike64
Copy link

I just ran into this issue as I was trying to compile Mindforger on my Gentoo box to try it out, but on Gentoo QtWebkit has already been removed. I cloned the branch with the commit that addresses this, and I was able to compile and run MF properly (still haven't tested it out fully yet). I used:

qmake CONFIG+=mfwebengine -r mindforger.pro

Thanks for the patch!

dvorka added a commit that referenced this pull request Jan 5, 2022
@dvorka
Copy link
Owner

dvorka commented Jan 5, 2022

@cyplo thank you for building MindForger on NixOS and PR contribution! I applied PR manually to both dev/1.54.0 39cb330 (upcoming release) and master 89467aa manually.

@godlike64 thank you for building MindForger on Gentoo and interest in MindForger! 👍

Closing PR as applied.

@dvorka dvorka self-requested a review January 5, 2022 06:51
@dvorka dvorka added this to the 1.54.0 macOS fix release milestone Jan 5, 2022
@dvorka dvorka self-assigned this Jan 9, 2022
@cyplo
Copy link
Author

cyplo commented Jan 24, 2022

thank you ! :)

@cyplo cyplo closed this Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants