Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
I find
mindforger
very useful and I help packaging it for NixOS.We're trying to deprecate
QtWebKit
across all NixOS packages.As part of that work I found that
mindforger
accepts"CONFIG+=mfwebengine"
and then tries to compile with QtWebEngine.When I ran the build I found that the project does not fully successfully compile with that option though.
This PR is an attempt to fix that - the resulting binary works very well on NixOS, I however haven't tested it on Windows nor MacOS.
I think I shouldn't have broken these targets, just by reading the the code, but would probably be best to test on those ?
For reference - here's the PR I'm trying to land to change the NixOS package definition - it includes these changes as a patch for now, but the reviewers suggested upstreaming first, hence my PR here :)
Hope this helps, please let me know what you think :)
If this makes sense, I would like to open another PR for the second patch that makes the output directories relocatable, but didn't want to spam with PRs without opening up a conversation.