qgis, qgis-ltr: disable qtwebkit by default and correctly link grass #208692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hqurve
force-pushed
the
qgis
branch
2 times, most recently
from
5ace2ae
to
a59a3c0
Compare
qtwebkit has been marked has having known vulnerabilities. Since qtlocation was propagated by qtwebkit, it now needs to be explicitly added. See also: archlinux/svntogit-community@783d526
hqurve
changed the title
willcohen
approved these changes
Jan 2, 2023
sikmir
approved these changes
Jan 3, 2023
imincik
added a commit
to imincik/geospatial-nix
that referenced
this pull request
Jan 17, 2023
imincik
added a commit
to imincik/geospatial-nix
that referenced
this pull request
Jan 17, 2023
Nixpkgs PR: NixOS/nixpkgs#208692
imincik
added a commit
to imincik/geospatial-nix
that referenced
this pull request
Jan 17, 2023
Nixpkgs PR: NixOS/nixpkgs#208692
imincik
added a commit
to imincik/geospatial-nix
that referenced
this pull request
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Qtwebkit has been marked as having known vulnerabilities. #53079
Qtlocation was propagated from qtwebkit, so now it needs to be explicitly added. Without it, the build fails. [qtwebkit definition][qtModule definition]
Also, the corresponding change done for archlinux archlinux/svntogit-community@783d526
For the grass change. I am not too sure if it does anything, but the path was wrong.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes